Re: [Spice-devel] [spice-server PATCH 1/3] red_get_surface_cmd: avoid overflow

2017-07-20 Thread Uri Lublin
On 07/20/2017 11:45 AM, Frediano Ziglio wrote: On 07/17/2017 11:22 AM, Frediano Ziglio wrote: Although unlikely, theoretically, multiplying two 32-bit numbers may overflow. Found by coverity. Signed-off-by: Uri Lublin --- server/red-parse-qxl.c | 2 +- 1 file changed,

Re: [Spice-devel] [spice-server PATCH 1/3] red_get_surface_cmd: avoid overflow

2017-07-20 Thread Frediano Ziglio
> > On 07/17/2017 11:22 AM, Frediano Ziglio wrote: > >> > >> Although unlikely, theoretically, multiplying two 32-bit > >> numbers may overflow. > >> > >> Found by coverity. > >> > >> Signed-off-by: Uri Lublin > >> --- > >> server/red-parse-qxl.c | 2 +- > >> 1 file changed,

Re: [Spice-devel] [spice-server PATCH 1/3] red_get_surface_cmd: avoid overflow

2017-07-19 Thread Uri Lublin
On 07/17/2017 11:22 AM, Frediano Ziglio wrote: Although unlikely, theoretically, multiplying two 32-bit numbers may overflow. Found by coverity. Signed-off-by: Uri Lublin --- server/red-parse-qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Spice-devel] [spice-server PATCH 1/3] red_get_surface_cmd: avoid overflow

2017-07-17 Thread Frediano Ziglio
> > Although unlikely, theoretically, multiplying two 32-bit > numbers may overflow. > > Found by coverity. > > Signed-off-by: Uri Lublin > --- > server/red-parse-qxl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red-parse-qxl.c

Re: [Spice-devel] [spice-server PATCH 1/3] red_get_surface_cmd: avoid overflow

2017-07-17 Thread Pavel Grunt
On Sun, 2017-07-16 at 18:47 +0300, Uri Lublin wrote: > Although unlikely, theoretically, multiplying two 32-bit > numbers may overflow. > > Found by coverity. > > Signed-off-by: Uri Lublin Acked-by: Pavel Grunt > --- > server/red-parse-qxl.c | 2 +- > 1