On Mon, Mar 21, 2011 at 06:47:19PM +0100, Christophe Fergeau wrote:
On Mon, Mar 21, 2011 at 05:24:54PM +0200, Alon Levy wrote:
btw, while you're at it, mind trying to compile with clang?
I ran some tests, spice compiled fine with clang using make CC=clang
CXX=clang++ CFLAGS=-Wall
On Mon, Mar 21, 2011 at 04:20:29PM +0100, Christophe Fergeau wrote:
When compiling spice with make CFLAGS=-g3 -ggdb3 -O0 -Wall -Werror,
the build broken because of a few unused variables/missing returns.
This patch fixes these warnings.
Just one comment inline. Looks good otherwise.
---
On Mon, Mar 21, 2011 at 05:24:54PM +0200, Alon Levy wrote:
Well, this is test code, I would want to get back to this eventually, so
could you turn this into a non static (and then the compiler won't complain)
instead? if that doesn't work even #if 0 is better. (again, test code).
Adding
On Mon, Mar 21, 2011 at 05:32:20PM +0200, Alon Levy wrote:
On Mon, Mar 21, 2011 at 05:24:54PM +0200, Alon Levy wrote:
On Mon, Mar 21, 2011 at 04:20:29PM +0100, Christophe Fergeau wrote:
When compiling spice with make CFLAGS=-g3 -ggdb3 -O0 -Wall -Werror,
the build broken because of a few
