Is we are not able to get source bo object from handle we free
destination bo object and call cleanup code however destination
object was already inserted in reloc_info array (num_relocs was
already incremented) so on cleanup we free destination again.

Signed-off-by: Frediano Ziglio <fzig...@redhat.com>
Reviewed-by: Dave Airlie <airl...@redhat.com>
---
 drivers/gpu/drm/qxl/qxl_ioctl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioctl.c
index 230ab84..85b3808 100644
--- a/drivers/gpu/drm/qxl/qxl_ioctl.c
+++ b/drivers/gpu/drm/qxl/qxl_ioctl.c
@@ -240,8 +240,6 @@ static int qxl_process_single_command(struct qxl_device 
*qdev,
                                qxlhw_handle_to_bo(qdev, file_priv,
                                                   reloc.src_handle, release);
                        if (!reloc_info[i].src_bo) {
-                               if (reloc_info[i].dst_bo != cmd_bo)
-                                       
drm_gem_object_unreference_unlocked(&reloc_info[i].dst_bo->gem_base);
                                ret = -EINVAL;
                                goto out_free_bos;
                        }
-- 
2.1.0

_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to