Re: [Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

2011-05-01 Thread Marc-André Lureau
Hi - Original Message - On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote: Missing #ifdef HAVE_CONFIG_H #include config.h #endif It didn't use any config.h define, and the files in common/ don't include config.h. But I would prefer if they do. So, I don't mind

Re: [Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

2011-05-01 Thread Christophe Fergeau
On Sun, May 01, 2011 at 07:08:58AM -0400, Marc-André Lureau wrote: Hi - Original Message - On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote: Missing #ifdef HAVE_CONFIG_H #include config.h #endif It didn't use any config.h define, and the files in

Re: [Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

2011-04-29 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote: Code adapter from RedPeer::ssl_verify_callback() and used by spice-gtk. I looked at this one, and was quickly concerned about the amount of security checks we're trying to do on our own. Basically, we let openssl do the

Re: [Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

2011-04-29 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote: diff --git a/common/ssl_verify.c b/common/ssl_verify.c new file mode 100644 index 000..f7d9482 --- /dev/null +++ b/common/ssl_verify.c @@ -0,0 +1,458 @@ +/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*- */

[Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

2011-01-25 Thread Marc-André Lureau
Code adapter from RedPeer::ssl_verify_callback() and used by spice-gtk. Note: the various VERIFY_OP check in openssl_verify() are exclusive. Is that intended? --- common/Makefile.am |2 + common/ssl_verify.c | 458 +++ common/ssl_verify.h |

Re: [Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

2011-01-25 Thread Marc-André Lureau
Hi, Good to review your own patch once it is sent ;) - Original Message - +++ b/common/Makefile.am @@ -47,6 +47,8 @@ COMMON_SRCS = \ quic_family_tmpl.c \ quic_rgb_tmpl.c \ quic_tmpl.c \ + ssl_verfiy.h \ + ssl_verfiy.c \ $(NULL) + ssl_verify.h \ + ssl_verify.c \ That would