Re: [Spice-devel] [PATCH phodav 00/13] Miscellaneous series

2019-05-23 Thread Marc-André Lureau
Hi

On Thu, May 23, 2019 at 10:37 AM Jakub Janků  wrote:
>
> Hi,
>
> this series contains mostly fixes of some things
> that I came across while reading the spice-webdavd.c code,
> without any order.
>
> Cheers,
>
> Jakub Janků (13):
>   spice: remove G_SOURCE_{REMOVE,CONTINUE} definitions
>   spice: rename my_input_channel
>   spice: handle SIGINT properly
>   spice: quit service quickly
>   spice: clear loop pointer on unref
>   spice: print err when g_open fails
>   spice: unref GSocketAddress
>   spice-win: define SERVICE_NAME
>   spice-win: remove MapDriveEnum
>   spice-win: don't assign drive_letter on error
>   spice: move OutputQueue to file
>   rename README to README.md
>   rename NEWS to NEWS.md

Looks good overall,

Phodav is hosted on GNOME gitlab, please open a MR there, so CI can run.

Thanks

>  NEWS => NEWS.md   |   0
>  README => README.md   |  21 ++--
>  spice/meson.build |   8 +-
>  spice/output-queue.c  | 164 +
>  spice/output-queue.h  |  38 ++
>  spice/spice-webdavd.c | 280 ++
>  6 files changed, 286 insertions(+), 225 deletions(-)
>  rename NEWS => NEWS.md (100%)
>  rename README => README.md (56%)
>  create mode 100644 spice/output-queue.c
>  create mode 100644 spice/output-queue.h
>
> --
> 2.21.0
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH phodav 00/13] Miscellaneous series

2019-05-23 Thread Jakub Janků
Hi,

this series contains mostly fixes of some things 
that I came across while reading the spice-webdavd.c code,
without any order.

Cheers,

Jakub Janků (13):
  spice: remove G_SOURCE_{REMOVE,CONTINUE} definitions
  spice: rename my_input_channel
  spice: handle SIGINT properly
  spice: quit service quickly
  spice: clear loop pointer on unref
  spice: print err when g_open fails
  spice: unref GSocketAddress
  spice-win: define SERVICE_NAME
  spice-win: remove MapDriveEnum
  spice-win: don't assign drive_letter on error
  spice: move OutputQueue to file
  rename README to README.md
  rename NEWS to NEWS.md

 NEWS => NEWS.md   |   0
 README => README.md   |  21 ++--
 spice/meson.build |   8 +-
 spice/output-queue.c  | 164 +
 spice/output-queue.h  |  38 ++
 spice/spice-webdavd.c | 280 ++
 6 files changed, 286 insertions(+), 225 deletions(-)
 rename NEWS => NEWS.md (100%)
 rename README => README.md (56%)
 create mode 100644 spice/output-queue.c
 create mode 100644 spice/output-queue.h

-- 
2.21.0

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel