Re: [Spice-devel] [PATCH spice-gtk] spice-channel: return if has_error is TRUE in spice_channel_write_msg

2019-07-11 Thread Victor Toso
Hi, On Thu, Jun 27, 2019 at 02:27:57PM +0200, Jakub Janku wrote: > Hi, > > On Thu, Jun 27, 2019 at 10:10 AM Frediano Ziglio wrote: > > > > > > > > Avoid linearizing if the message isn't written out anyway > > > > "linearizing" ? What do you mean about that? > > Looking at definitions it seems

Re: [Spice-devel] [PATCH spice-gtk] spice-channel: return if has_error is TRUE in spice_channel_write_msg

2019-06-27 Thread Frediano Ziglio
> > Hi, > > On Thu, Jun 27, 2019 at 10:10 AM Frediano Ziglio wrote: > > > > > > > > Avoid linearizing if the message isn't written out anyway > > > > "linearizing" ? What do you mean about that? > > Looking at definitions it seems not correct to me. > > I was simply referring to the

Re: [Spice-devel] [PATCH spice-gtk] spice-channel: return if has_error is TRUE in spice_channel_write_msg

2019-06-27 Thread Jakub Janku
Hi, On Thu, Jun 27, 2019 at 10:10 AM Frediano Ziglio wrote: > > > > > Avoid linearizing if the message isn't written out anyway > > "linearizing" ? What do you mean about that? > Looking at definitions it seems not correct to me. I was simply referring to the spice_marshaller_linearize() call.

Re: [Spice-devel] [PATCH spice-gtk] spice-channel: return if has_error is TRUE in spice_channel_write_msg

2019-06-27 Thread Frediano Ziglio
> > Avoid linearizing if the message isn't written out anyway "linearizing" ? What do you mean about that? Looking at definitions it seems not correct to me. > (spice_channel_flush_wire checks() this condition as well). > > This also silences the following error: > > (spicy:32087):

[Spice-devel] [PATCH spice-gtk] spice-channel: return if has_error is TRUE in spice_channel_write_msg

2019-06-26 Thread Jakub Janků
Avoid linearizing if the message isn't written out anyway (spice_channel_flush_wire checks() this condition as well). This also silences the following error: (spicy:32087): GSpice-CRITICAL **: 16:22:03.147: spice_session_get_read_only: assertion 'SPICE_IS_SESSION(self)' failed that can be