Re: [Spice-devel] [PATCH spice-gtk v5 1/5] Add check for macOS

> On 31 May 2017, at 10:30, Frediano Ziglio wrote: > > May be a comment like > > "Use correctly ucontext for coroutines under Mac OS X > > Mac OS X requires _XOPEN_SOURCE to be defined in order to > use ucontext type coroutines” OK, will do that. > >> >> On Wed, May

Re: [Spice-devel] [PATCH spice-gtk v5 1/5] Add check for macOS

May be a comment like "Use correctly ucontext for coroutines under Mac OS X Mac OS X requires _XOPEN_SOURCE to be defined in order to use ucontext type coroutines" > > On Wed, May 31, 2017 at 04:20:37AM -0400, Frediano Ziglio wrote: > > It's used by the build, setting with_coroutine change

Re: [Spice-devel] [PATCH spice-gtk v5 1/5] Add check for macOS

On Wed, May 31, 2017 at 04:20:37AM -0400, Frediano Ziglio wrote: > It's used by the build, setting with_coroutine change some conditional > compilation. But this is not in the "Add check for macOS" comment. > > I don't see any patch using the OS_MAC conditional, maybe should > be removed or do

Re: [Spice-devel] [PATCH spice-gtk v5 1/5] Add check for macOS

It's used by the build, setting with_coroutine change some conditional compilation. But this is not in the "Add check for macOS" comment. I don't see any patch using the OS_MAC conditional, maybe should be removed or do you want it for coherence with OS_WIN32 ? Frediano > > Is this used by a

Re: [Spice-devel] [PATCH spice-gtk v5 1/5] Add check for macOS

Is this used by a patch in this series though? I'd rather we delay this until this gets used. Christophe On Tue, May 30, 2017 at 02:52:47PM +0200, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin >

[Spice-devel] [PATCH spice-gtk v5 1/5] Add check for macOS

From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- configure.ac | 15 +++ 1 file changed, 15 insertions(+) diff --git a/configure.ac b/configure.ac index ff00d73..62acafc 100644 --- a/configure.ac +++ b/configure.ac @@