Re: [Spice-devel] [PATCH spice-protocol] stream-device: Specify how padding shoud be inside new structures

2018-02-27 Thread Frediano Ziglio
> > > On 23 Feb 2018, at 11:11, Frediano Ziglio wrote: > > > > Depending on how structures are initialised in the code is > > possible that implicit padding bytes are not initialised > > causing possible information leaks as the entire structure > > with all padding is sent

Re: [Spice-devel] [PATCH spice-protocol] stream-device: Specify how padding shoud be inside new structures

2018-02-23 Thread Christophe de Dinechin
> On 23 Feb 2018, at 11:31, Christophe Fergeau wrote: > > On Fri, Feb 23, 2018 at 10:11:46AM +, Frediano Ziglio wrote: >> Depending on how structures are initialised in the code is >> possible that implicit padding bytes are not initialised >> causing possible

Re: [Spice-devel] [PATCH spice-protocol] stream-device: Specify how padding shoud be inside new structures

2018-02-23 Thread Christophe Fergeau
On Fri, Feb 23, 2018 at 10:11:46AM +, Frediano Ziglio wrote: > Depending on how structures are initialised in the code is > possible that implicit padding bytes are not initialised > causing possible information leaks as the entire structure > with all padding is sent through device/network. >

Re: [Spice-devel] [PATCH spice-protocol] stream-device: Specify how padding shoud be inside new structures

2018-02-23 Thread Christophe de Dinechin
On that topic, curious why the structures are “naturally aligned”? Why aren’t they packed? > On 23 Feb 2018, at 11:11, Frediano Ziglio wrote: > > Depending on how structures are initialised in the code is > possible that implicit padding bytes are not initialised > causing

Re: [Spice-devel] [PATCH spice-protocol] stream-device: Specify how padding shoud be inside new structures

2018-02-23 Thread Christophe de Dinechin
> On 23 Feb 2018, at 11:11, Frediano Ziglio wrote: > > Depending on how structures are initialised in the code is > possible that implicit padding bytes are not initialised > causing possible information leaks as the entire structure > with all padding is sent through

[Spice-devel] [PATCH spice-protocol] stream-device: Specify how padding shoud be inside new structures

2018-02-23 Thread Frediano Ziglio
Depending on how structures are initialised in the code is possible that implicit padding bytes are not initialised causing possible information leaks as the entire structure with all padding is sent through device/network. Signed-off-by: Frediano Ziglio ---