Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-21 Thread Frediano Ziglio
> > I'm late to the party, but a one-line commit log for a patch adding 160 > lines of code is *not* acceptable. > > Christophe > Yes, was a mistake. Frediano > On Fri, Feb 09, 2018 at 09:10:48AM +, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- >

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-21 Thread Christophe Fergeau
I'm late to the party, but a one-line commit log for a patch adding 160 lines of code is *not* acceptable. Christophe On Fri, Feb 09, 2018 at 09:10:48AM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/stream-device.c | 169 >

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-16 Thread Frediano Ziglio
> > > On 9 Feb 2018, at 17:59, Frediano Ziglio wrote: > > > > > > + > > +// read part of the message till we get all > > +if (dev->msg_len < dev->hdr.size) { > > +dev->msg = g_realloc(dev->msg, dev->hdr.size); > > +

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-14 Thread Christophe de Dinechin
> On 9 Feb 2018, at 17:59, Frediano Ziglio wrote: > > + > +// read part of the message till we get all > +if (dev->msg_len < dev->hdr.size) { > +dev->msg = g_realloc(dev->msg, dev->hdr.size); > +dev->msg_len =

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Frediano Ziglio
> > > On 9 Feb 2018, at 14:20, Frediano Ziglio wrote: > > > >>> > >>> On 9 Feb 2018, at 10:10, Frediano Ziglio wrote: > >>> > >>> Signed-off-by: Frediano Ziglio > >>> --- > >>> server/stream-device.c | 169 > >>>

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Christophe de Dinechin
> On 9 Feb 2018, at 14:20, Frediano Ziglio wrote: > >>> >>> On 9 Feb 2018, at 10:10, Frediano Ziglio wrote: >>> >>> Signed-off-by: Frediano Ziglio >>> --- >>> server/stream-device.c | 169 >>>

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Frediano Ziglio
> > > On 9 Feb 2018, at 10:10, Frediano Ziglio wrote: > > > > Signed-off-by: Frediano Ziglio > > --- > > server/stream-device.c | 169 > > +++-- > > 1 file changed, 162 insertions(+), 7 deletions(-) > > > >

Re: [Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Christophe de Dinechin
> On 9 Feb 2018, at 10:10, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > --- > server/stream-device.c | 169 +++-- > 1 file changed, 162 insertions(+), 7 deletions(-) > > Changes since v1: > -

[Spice-devel] [PATCH spice-server v2 1/2] stream-device: handle cursor from device

2018-02-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/stream-device.c | 169 +++-- 1 file changed, 162 insertions(+), 7 deletions(-) Changes since v1: - add some comments with some implementation explanation; - better computation of max cursor