>
> I'm late to the party, but a one-line commit log for a patch adding 160
> lines of code is *not* acceptable.
>
> Christophe
>
Yes, was a mistake.
Frediano
> On Fri, Feb 09, 2018 at 09:10:48AM +, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
>
I'm late to the party, but a one-line commit log for a patch adding 160
lines of code is *not* acceptable.
Christophe
On Fri, Feb 09, 2018 at 09:10:48AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/stream-device.c | 169
>
>
> > On 9 Feb 2018, at 17:59, Frediano Ziglio wrote:
> >
>
>
> > +
> > +// read part of the message till we get all
> > +if (dev->msg_len < dev->hdr.size) {
> > +dev->msg = g_realloc(dev->msg, dev->hdr.size);
> > +
> On 9 Feb 2018, at 17:59, Frediano Ziglio wrote:
>
> +
> +// read part of the message till we get all
> +if (dev->msg_len < dev->hdr.size) {
> +dev->msg = g_realloc(dev->msg, dev->hdr.size);
> +dev->msg_len =
>
> > On 9 Feb 2018, at 14:20, Frediano Ziglio wrote:
> >
> >>>
> >>> On 9 Feb 2018, at 10:10, Frediano Ziglio wrote:
> >>>
> >>> Signed-off-by: Frediano Ziglio
> >>> ---
> >>> server/stream-device.c | 169
> >>>
> On 9 Feb 2018, at 14:20, Frediano Ziglio wrote:
>
>>>
>>> On 9 Feb 2018, at 10:10, Frediano Ziglio wrote:
>>>
>>> Signed-off-by: Frediano Ziglio
>>> ---
>>> server/stream-device.c | 169
>>>
>
> > On 9 Feb 2018, at 10:10, Frediano Ziglio wrote:
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/stream-device.c | 169
> > +++--
> > 1 file changed, 162 insertions(+), 7 deletions(-)
> >
> >
> On 9 Feb 2018, at 10:10, Frediano Ziglio wrote:
>
> Signed-off-by: Frediano Ziglio
> ---
> server/stream-device.c | 169 +++--
> 1 file changed, 162 insertions(+), 7 deletions(-)
>
> Changes since v1:
> -
Signed-off-by: Frediano Ziglio
---
server/stream-device.c | 169 +++--
1 file changed, 162 insertions(+), 7 deletions(-)
Changes since v1:
- add some comments with some implementation explanation;
- better computation of max cursor