Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-22 Thread Snir Sheriber
On 02/22/2017 12:58 PM, Christophe Fergeau wrote: Hey, On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: The authentication type string is just for letting the user know what authentication is in use. Sorry, forgot to reply to this bit, I don't think saying "SASL" in this string

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-22 Thread Daniel P. Berrange
On Wed, Feb 22, 2017 at 11:47:10AM +0100, Christophe Fergeau wrote: > On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: > > Hi, > > > > > > On 02/21/2017 06:37 PM, Christophe Fergeau wrote: > > > On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: > > > > Remove handling w

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-22 Thread Christophe Fergeau
Hey, On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: > The authentication type string is just for letting the user know what > authentication is in use. Sorry, forgot to reply to this bit, I don't think saying "SASL" in this string is useful, this is going to be very cryptic to the

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-22 Thread Christophe de Dinechin
> On 21 Feb 2017, at 16:28, Snir Sheriber wrote: > > Hi, > > > On 02/20/2017 07:00 PM, Christophe de Dinechin wrote: >>> On 19 Feb 2017, at 15:47, Snir Sheriber wrote: >>> >>> Remove handling with failures in the SASL authentication >>> process to separate function >>> --- >>> src/spice-chan

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-22 Thread Christophe Fergeau
On Wed, Feb 22, 2017 at 11:50:21AM +0200, Snir Sheriber wrote: > Hi, > > > On 02/21/2017 06:37 PM, Christophe Fergeau wrote: > > On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: > > > Remove handling with failures in the SASL authentication > > > process to separate function > > > -

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-22 Thread Snir Sheriber
Hi, On 02/21/2017 06:37 PM, Christophe Fergeau wrote: On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: Remove handling with failures in the SASL authentication process to separate function --- src/spice-channel.c | 44 +++- 1 file change

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-21 Thread Christophe Fergeau
On Sun, Feb 19, 2017 at 04:47:17PM +0200, Snir Sheriber wrote: > Remove handling with failures in the SASL authentication > process to separate function > --- > src/spice-channel.c | 44 +++- > 1 file changed, 27 insertions(+), 17 deletions(-) > > diff --gi

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-21 Thread Snir Sheriber
Hi, On 02/20/2017 07:00 PM, Christophe de Dinechin wrote: On 19 Feb 2017, at 15:47, Snir Sheriber wrote: Remove handling with failures in the SASL authentication process to separate function --- src/spice-channel.c | 44 +++- 1 file changed, 27 insertion

Re: [Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-20 Thread Christophe de Dinechin
> On 19 Feb 2017, at 15:47, Snir Sheriber wrote: > > Remove handling with failures in the SASL authentication > process to separate function > --- > src/spice-channel.c | 44 +++- > 1 file changed, 27 insertions(+), 17 deletions(-) > > diff --git a/src/spi

[Spice-devel] [PATCH v2 spice-gtk 1/2] authentication: Handle failed SASL authentication separately

2017-02-19 Thread Snir Sheriber
Remove handling with failures in the SASL authentication process to separate function --- src/spice-channel.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/src/spice-channel.c b/src/spice-channel.c index af67931..cbf1291 100644 -