Re: [Spice-devel] [PATCH vd_agent_linux 1/7] file-xfers: Initialise correctly AgentFileXferTask::file_fd field

2019-01-16 Thread Victor Toso
Hi, On Wed, Jan 16, 2019 at 04:15:50AM -0500, Frediano Ziglio wrote: > > > > Hi, > > > > For some reason I miss in my inbox the 6/7 patch. Looking at, > > seems that mailman got it. > > > > > > https://lists.freedesktop.org/archives/spice-devel/2019-January/047268.html > > > > My only

Re: [Spice-devel] [PATCH vd_agent_linux 1/7] file-xfers: Initialise correctly AgentFileXferTask::file_fd field

2019-01-16 Thread Victor Toso
Hi, For some reason I miss in my inbox the 6/7 patch. Looking at, seems that mailman got it. https://lists.freedesktop.org/archives/spice-devel/2019-January/047268.html My only suggestion is to move the test to root directory instead of srcdir. I'd prefer also to use the glib test framework

[Spice-devel] [PATCH vd_agent_linux 1/7] file-xfers: Initialise correctly AgentFileXferTask::file_fd field

2019-01-15 Thread Frediano Ziglio
Correct invalid value for a file descriptor is -1, not 0. Signed-off-by: Frediano Ziglio --- src/vdagent/file-xfers.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vdagent/file-xfers.c b/src/vdagent/file-xfers.c index b5aedd0..78d5db3 100644 --- a/src/vdagent/file-xfers.c +++