Re: [Spice-devel] [PATCH vdagent-linux 3/4] introduce VDAgentConnection

2018-12-20 Thread Victor Toso
Hi, On Tue, Dec 11, 2018 at 06:39:39PM +0100, Jakub Janku wrote: > Hi, Victor! > > Many thanks for reviewing this series. > > On Thu, Dec 6, 2018 at 4:20 PM Victor Toso wrote: > > > > Hi, > > > > First of all, tested. Seems to work fine! > > Great! > > > > This one I think it can be improved

Re: [Spice-devel] [PATCH vdagent-linux 3/4] introduce VDAgentConnection

2018-12-11 Thread Jakub Janku
Hi, Victor! Many thanks for reviewing this series. On Thu, Dec 6, 2018 at 4:20 PM Victor Toso wrote: > > Hi, > > First of all, tested. Seems to work fine! Great! > > This one I think it can be improved to have a clear design around > VDAgentConnection. The other three patches could be merged

Re: [Spice-devel] [PATCH vdagent-linux 3/4] introduce VDAgentConnection

2018-12-06 Thread Victor Toso
Hi, First of all, tested. Seems to work fine! This one I think it can be improved to have a clear design around VDAgentConnection. The other three patches could be merged faster I think, if you want. On Sun, Sep 30, 2018 at 08:05:22PM +0200, Jakub Janků wrote: > 1) VDAgentConnection > > Add

[Spice-devel] [PATCH vdagent-linux 3/4] introduce VDAgentConnection

2018-09-30 Thread Jakub Janků
1) VDAgentConnection Add vdagent-connection.{c,h} files. Define a new GObject: VDAgentConnection which can be used to easily write messages to and read from the given FD. VDAgentConnection uses GIO and therefore integrates well with GMainLoop. Read messages must begin with a header of a fixed