Re: [Spice-devel] [PATCH x11spice] Call xf86SetDesiredModes() in DUMMYScreenInit().

2022-08-23 Thread Frediano Ziglio
Il giorno mar 23 ago 2022 alle ore 13:27 Henri Verbeet ha scritto: > > Hi Frediano, > > On 23/08/2022 14.01, Frediano Ziglio wrote: > > Looking on the Internet this function is also called in EnterVT > > callback. Don't we need something similar? > > I think that in principle we would, but by its

Re: [Spice-devel] [PATCH x11spice] Call xf86SetDesiredModes() in DUMMYScreenInit().

2022-08-23 Thread Henri Verbeet
Hi Frediano, On 23/08/2022 14.01, Frediano Ziglio wrote: > Looking on the Internet this function is also called in EnterVT > callback. Don't we need something similar? I think that in principle we would, but by its nature of being an "off-screen" driver, spice-video-dummy doesn't (or at least,

Re: [Spice-devel] [PATCH x11spice] Call xf86SetDesiredModes() in DUMMYScreenInit().

2022-08-23 Thread Frediano Ziglio
Il giorno mar 23 ago 2022 alle ore 10:57 Henri Verbeet ha scritto: > > Otherwise, we may end up with no mode (and thus no refresh rate) set if > nothing else (like e.g. .xinitrc) sets a mode for us. > > Signed-off-by: Henri Verbeet > --- > spice-video-dummy/src/spicedummy_driver.c | 2 ++ > 1

Re: [Spice-devel] [PATCH x11spice] Call xf86SetDesiredModes() in DUMMYScreenInit().

2022-08-23 Thread Victor Toso
Hi, On Tue, Aug 23, 2022 at 11:39:52AM +0200, Henri Verbeet wrote: > Otherwise, we may end up with no mode (and thus no refresh rate) set if > nothing else (like e.g. .xinitrc) sets a mode for us. > > Signed-off-by: Henri Verbeet > --- > spice-video-dummy/src/spicedummy_driver.c | 2 ++ > 1

[Spice-devel] [PATCH x11spice] Call xf86SetDesiredModes() in DUMMYScreenInit().

2022-08-23 Thread Henri Verbeet
Otherwise, we may end up with no mode (and thus no refresh rate) set if nothing else (like e.g. .xinitrc) sets a mode for us. Signed-off-by: Henri Verbeet --- spice-video-dummy/src/spicedummy_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git