Hey,
There are a bunch of calloc/malloc throughout the patch with no check
for a NULL return, would be nice to add that.
This also adds inotify monitoring, do we need to add a check for it to
configure.ac? (eg a check for sys/inotify.h)
One small note below for a typo, looks good to me apart
On 10/22/2014 09:38 AM, Christophe Fergeau wrote:
Hey,
There are a bunch of calloc/malloc throughout the patch with no check
for a NULL return, would be nice to add that.
Hmm. I've seen this argued both ways. One side argues that if an
allocation is never expected to fail, that it's best
Forgot to mention that there are more error situations in this function
where it looks like data would be leaked.
Sure, added a few more checks. v3 with configure checking, the typo
fix, and those checks inbound shortly.
Cheers,
Jeremy
___
The initial implementation used a separate thread to drive the audio
playback channel. But if you have adaptive streaming turned on,
you will eventually get a update_client_playback_latency message on the
display channel (which in the Xspice case is being driven by the main,
Xorg, thread).
After
