Re: [Spice-devel] [PATHCH win-qxl 2/8] display: fix broken debug in checked

2011-04-08 Thread Hans de Goede
Hmm, you also change how WAIT_FOR_EVENT get called but don't change the macro ? Also I would prefer for the WAIT_FOR_EVENT changes to get broken out into a different patch. Last some more verbose commit message would be nice (and the same for the separate WAIT_FOR_EVENT changes patch. Regards,

Re: [Spice-devel] [PATHCH win-qxl 2/8] display: fix broken debug in checked

2011-04-08 Thread Alon Levy
On Fri, Apr 08, 2011 at 11:13:47AM +0200, Hans de Goede wrote: Hmm, you also change how WAIT_FOR_EVENT get called but don't change the macro ? Also I would prefer for the WAIT_FOR_EVENT changes to get broken out into a different patch. ok, self NACK, I shouldn't push that TODO - I'll