Re: [Spice-devel] [PATHCH win-qxl 3/8] miniport: add QXL_IO_LOG

2011-04-08 Thread Hans de Goede
Hmm, snprintf.c is missing a copyright header, also implementing our own snprintf feels like a serious case of NIH syndrome. Please use an existing proven implementation like one of these: http://www.jhweiss.de/software/snprintf.html

[Spice-devel] [PATHCH win-qxl 3/8] miniport: add QXL_IO_LOG

2011-04-07 Thread Alon Levy
Until now logging for miniport and display went in different paths, display knew how to use the QXL_IO_LOG port to allow basically seeing the debug messages on the host with the rest of the qemu monitor output. But miniport always went through VideoPortDbg, which made it harder to pretend there is