Re: [Spice-devel] [client 07/11] build-sys: Allow simultaneous support for Pulse and GStreamer audio

2015-11-16 Thread Christophe Fergeau
On Sun, Nov 08, 2015 at 07:39:11PM +0100, Francois Gouget wrote: > On Fri, 6 Nov 2015, Christophe Fergeau wrote: > [...] > > > -AC_ARG_WITH([audio], > > > - AS_HELP_STRING([--with-audio=@<:@gstreamer/pulse/auto/no@:>@], [Select > > > audio backend @<:@default=auto@:>@]), > > >

Re: [Spice-devel] [client 07/11] build-sys: Allow simultaneous support for Pulse and GStreamer audio

2015-11-08 Thread Francois Gouget
On Fri, 6 Nov 2015, Christophe Fergeau wrote: [...] > > -AC_ARG_WITH([audio], > > - AS_HELP_STRING([--with-audio=@<:@gstreamer/pulse/auto/no@:>@], [Select > > audio backend @<:@default=auto@:>@]), > > +AC_ARG_ENABLE([pulse], > > + AS_HELP_STRING([--enable-pulse=@<:@yes/auto/no@:>@], [Enable the

Re: [Spice-devel] [client 07/11] build-sys: Allow simultaneous support for Pulse and GStreamer audio

2015-11-06 Thread Christophe Fergeau
On Thu, Nov 05, 2015 at 12:17:19AM +0100, Francois Gouget wrote: > On Wed, 4 Nov 2015, Christophe Fergeau wrote: > > > Can you explain in the commit log why this is a good thing/why you need > > to do that? > > Not sure how to explain it in the commit log. > > It's essentially like the video

Re: [Spice-devel] [client 07/11] build-sys: Allow simultaneous support for Pulse and GStreamer audio

2015-11-06 Thread Christophe Fergeau
On Tue, Nov 03, 2015 at 01:06:10PM +0100, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > configure.ac | 63 > +-- > src/Makefile.am | 4 ++-- > src/spice-audio.c | 11 +- > 3 files

Re: [Spice-devel] [client 07/11] build-sys: Allow simultaneous support for Pulse and GStreamer audio

2015-11-04 Thread Francois Gouget
On Wed, 4 Nov 2015, Christophe Fergeau wrote: > Can you explain in the commit log why this is a good thing/why you need > to do that? Not sure how to explain it in the commit log. It's essentially like the video decoder support: we don't force the developer to choose between the builtin MJPEG

Re: [Spice-devel] [client 07/11] build-sys: Allow simultaneous support for Pulse and GStreamer audio

2015-11-04 Thread Christophe Fergeau
Can you explain in the commit log why this is a good thing/why you need to do that? Thanks, Christophe On Tue, Nov 03, 2015 at 01:06:10PM +0100, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > configure.ac | 63 >

[Spice-devel] [client 07/11] build-sys: Allow simultaneous support for Pulse and GStreamer audio

2015-11-03 Thread Francois Gouget
Signed-off-by: Francois Gouget --- configure.ac | 63 +-- src/Makefile.am | 4 ++-- src/spice-audio.c | 11 +- 3 files changed, 37 insertions(+), 41 deletions(-) This patch only depends on [client