Re: [Spice-devel] [qxl] xspice: Adjust to X.org 1.19 changes

2016-12-15 Thread Christophe Fergeau
On Thu, Dec 15, 2016 at 02:01:03PM +0200, Uri Lublin wrote: > Hi Christophe, > > Please see some comments below > > On 12/14/2016 12:51 PM, Christophe Fergeau wrote: > > +static int watch_update_mask2(SpiceWatch *watch, int event_mask) > > +{ > > +SetNotifyFd(watch->fd, NULL, X_NOTIFY_NONE,

Re: [Spice-devel] [qxl] xspice: Adjust to X.org 1.19 changes

2016-12-15 Thread Uri Lublin
Hi Christophe, Please see some comments below On 12/14/2016 12:51 PM, Christophe Fergeau wrote: In newer X.org versions, it's no longer supported to modify the set of FDs passed to a BlockHandler method to get notified when the FD has data to be read. This was limited anyway as we could only

Re: [Spice-devel] [qxl] xspice: Adjust to X.org 1.19 changes

2016-12-15 Thread Christophe Fergeau
On Wed, Dec 14, 2016 at 12:07:55PM +0100, Hans de Goede wrote: > Hi, > > On 14-12-16 11:51, Christophe Fergeau wrote: > > In newer X.org versions, it's no longer supported to modify the set of > > FDs passed to a BlockHandler method to get notified when the FD has data > > to be read. This was

Re: [Spice-devel] [qxl] xspice: Adjust to X.org 1.19 changes

2016-12-14 Thread Hans de Goede
Hi, On 14-12-16 11:51, Christophe Fergeau wrote: In newer X.org versions, it's no longer supported to modify the set of FDs passed to a BlockHandler method to get notified when the FD has data to be read. This was limited anyway as we could only get read events this way, and had to do our own

[Spice-devel] [qxl] xspice: Adjust to X.org 1.19 changes

2016-12-14 Thread Christophe Fergeau
In newer X.org versions, it's no longer supported to modify the set of FDs passed to a BlockHandler method to get notified when the FD has data to be read. This was limited anyway as we could only get read events this way, and had to do our own polling to get notified about socket writeability.