Re: [Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

2018-04-22 Thread Sameeh Jubran 
ping.

On Sun, Apr 15, 2018 at 10:44 AM, Sameeh Jubran  wrote:

>
>
> On Fri, Apr 13, 2018 at 7:16 PM, Frediano Ziglio 
> wrote:
>
>> >
>> > Limited the installation of the driver to Windows 8 and up
>> > in order to prevent false driver installation on unsupported OSes
>> > which lead to BSODs.
>> >
>> > Signed-off-by: Basil Salman 
>> > Signed-off-by: Sameeh Jubran 
>> > ---
>> >  qxldod/qxldod.inx | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/qxldod/qxldod.inx b/qxldod/qxldod.inx
>> > index 180275d..5c08305 100755
>> > --- a/qxldod/qxldod.inx
>> > +++ b/qxldod/qxldod.inx
>> > @@ -35,9 +35,9 @@ QxlDod_Files_Driver = 12
>> >  ;
>> >
>> >  [Manufacturer]
>> > -%RHEL%=RHEL,NT$ARCH$
>> > +%RHEL%=RHEL,NT$ARCH$.6.2
>> >
>> > -[RHEL.NT$ARCH$]
>> > +[RHEL.NT$ARCH$.6.2]
>> >  %RHELQxl.DeviceDesc% = QxlDod_Inst, PCI\VEN_1B36_0100_1
>> 1001AF4
>> >
>> >  [QxlDod_Files_Driver]
>>
>> Off topic: as an extra safety, cannot the driver check the version of
>> Windows?
>>
> This can be done in the driver too, however, I think this would be
> superfluous as the driver must be installed using the inf file which
> prevents this scenario in the first place.
>
>>
>> Frediano
>> ___
>> Spice-devel mailing list
>> Spice-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>>
>
>
>
> --
> Respectfully,
> *Sameeh Jubran*
> *Linkedin *
> *Software Engineer @ Daynix .*
>



-- 
Respectfully,
*Sameeh Jubran*
*Linkedin *
*Software Engineer @ Daynix .*
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

2018-04-13 Thread Frediano Ziglio 
> 
> Limited the installation of the driver to Windows 8 and up
> in order to prevent false driver installation on unsupported OSes
> which lead to BSODs.
> 
> Signed-off-by: Basil Salman 
> Signed-off-by: Sameeh Jubran 
> ---
>  qxldod/qxldod.inx | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qxldod/qxldod.inx b/qxldod/qxldod.inx
> index 180275d..5c08305 100755
> --- a/qxldod/qxldod.inx
> +++ b/qxldod/qxldod.inx
> @@ -35,9 +35,9 @@ QxlDod_Files_Driver = 12
>  ;
>  
>  [Manufacturer]
> -%RHEL%=RHEL,NT$ARCH$
> +%RHEL%=RHEL,NT$ARCH$.6.2
>  
> -[RHEL.NT$ARCH$]
> +[RHEL.NT$ARCH$.6.2]
>  %RHELQxl.DeviceDesc% = QxlDod_Inst, PCI\VEN_1B36_0100_11001AF4
>  
>  [QxlDod_Files_Driver]

Off topic: as an extra safety, cannot the driver check the version of Windows?

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

2018-04-13 Thread Frediano Ziglio 
> 
> Limited the installation of the driver to Windows 8 and up
> in order to prevent false driver installation on unsupported OSes
> which lead to BSODs.
> 
> Signed-off-by: Basil Salman 
> Signed-off-by: Sameeh Jubran 
> ---
>  qxldod/qxldod.inx | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qxldod/qxldod.inx b/qxldod/qxldod.inx
> index 180275d..5c08305 100755
> --- a/qxldod/qxldod.inx
> +++ b/qxldod/qxldod.inx
> @@ -35,9 +35,9 @@ QxlDod_Files_Driver = 12
>  ;
>  
>  [Manufacturer]
> -%RHEL%=RHEL,NT$ARCH$
> +%RHEL%=RHEL,NT$ARCH$.6.2
>  
> -[RHEL.NT$ARCH$]
> +[RHEL.NT$ARCH$.6.2]
>  %RHELQxl.DeviceDesc% = QxlDod_Inst, PCI\VEN_1B36_0100_11001AF4
>  
>  [QxlDod_Files_Driver]

Acked-by: Frediano Ziglio 

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

2018-04-13 Thread Basil Salman 
Hi,

We received a bug report: 
https://github.com/virtio-win/kvm-guest-drivers-windows/issues/244 (BZ - Bug 
1542909),
regarding BSOD on Windows 7 when letting windows automatically choose the 
driver from virtio-win iso.
After debugging the issue, we found out that Windows was falsely installing 
wddm drivers for Windows 7 instaed of xddm drivers,
after discussing the issue, we decided to limit the installation of wddm 
drivers for Windows OSes starting from Windows 8 as a fix to this issue.

Thanks,
Basil Salman

Basil Salman (1):
  Prevent installation on OSes earlier than Windows 8

 qxldod/qxldod.inx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.0.windows.1

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

2018-04-13 Thread Basil Salman 
Limited the installation of the driver to Windows 8 and up
in order to prevent false driver installation on unsupported OSes
which lead to BSODs.

Signed-off-by: Basil Salman 
Signed-off-by: Sameeh Jubran 
---
 qxldod/qxldod.inx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qxldod/qxldod.inx b/qxldod/qxldod.inx
index 180275d..5c08305 100755
--- a/qxldod/qxldod.inx
+++ b/qxldod/qxldod.inx
@@ -35,9 +35,9 @@ QxlDod_Files_Driver = 12
 ;
 
 [Manufacturer]
-%RHEL%=RHEL,NT$ARCH$
+%RHEL%=RHEL,NT$ARCH$.6.2
 
-[RHEL.NT$ARCH$]
+[RHEL.NT$ARCH$.6.2]
 %RHELQxl.DeviceDesc% = QxlDod_Inst, PCI\VEN_1B36_0100_11001AF4
 
 [QxlDod_Files_Driver]
-- 
2.7.0.windows.1

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

2018-04-12 Thread Basil Salman 
Hi,

We received a bug report: 
https://github.com/virtio-win/kvm-guest-drivers-windows/issues/244 (BZ - Bug 
1542909),
regarding BSOD on Windows 7 when letting windows automatically choose the 
driver from virtio-win iso.
After debugging the issue, we found out that Windows was falsely installing 
wddm drivers for Windows 7 instaed of xddm drivers,
after discussing the issue, we decided to limit the installation of wddm 
drivers for Windows OSes starting from Windows 8 as a fix to this issue.

Thanks,
Basil Salman

Basil Salman (1):
  Prevent installation on OSes earlier than Windows 8

 qxldod/qxldod.inx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.0.windows.1

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [qxl-wddm-dod] Prevent installation on OSes earlier than Windows 8

2018-04-12 Thread Basil Salman 
Limited the installation of the driver to Windows 8 and up
in order to prevent false driver installation on unsupported OSes
which lead to BSODs.

Signed-off-by: Basil Salman 
Signed-off-by: Sameeh Jubran 
---
 qxldod/qxldod.inx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qxldod/qxldod.inx b/qxldod/qxldod.inx
index 180275d..5c08305 100755
--- a/qxldod/qxldod.inx
+++ b/qxldod/qxldod.inx
@@ -35,9 +35,9 @@ QxlDod_Files_Driver = 12
 ;
 
 [Manufacturer]
-%RHEL%=RHEL,NT$ARCH$
+%RHEL%=RHEL,NT$ARCH$.6.2
 
-[RHEL.NT$ARCH$]
+[RHEL.NT$ARCH$.6.2]
 %RHELQxl.DeviceDesc% = QxlDod_Inst, PCI\VEN_1B36_0100_11001AF4
 
 [QxlDod_Files_Driver]
-- 
2.7.0.windows.1

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel