Re: [Spice-devel] [spice-gtk v1 4/4] channel-display-gst: early return if gst_init failed

2016-10-19 Thread Pavel Grunt
On Wed, 2016-10-19 at 13:31 +0200, Pavel Grunt wrote: > Hey, > > On Tue, 2016-10-18 at 23:27 +0200, Victor Toso wrote: > > From: Victor Toso > > > > If gst_init() fails, gstvideo_init() will warn once about the > > issue > > and never attempt to try again, which is probably

Re: [Spice-devel] [spice-gtk v1 4/4] channel-display-gst: early return if gst_init failed

2016-10-19 Thread Pavel Grunt
Hey, On Tue, 2016-10-18 at 23:27 +0200, Victor Toso wrote: > From: Victor Toso > > If gst_init() fails, gstvideo_init() will warn once about the issue > and never attempt to try again, which is probably fine. > > All the other APIs that might be called such as >

[Spice-devel] [spice-gtk v1 4/4] channel-display-gst: early return if gst_init failed

2016-10-18 Thread Victor Toso
From: Victor Toso If gst_init() fails, gstvideo_init() will warn once about the issue and never attempt to try again, which is probably fine. All the other APIs that might be called such as create_gstreamer_decoder() should not fail silently. Signed-off-by: Victor Toso