Re: [Spice-devel] [spice-gtk v3] smartcard: Warn if multiple readers are detected
On Fri, Feb 22, 2019 at 11:40 AM Christophe Fergeau wrote: > > spice-server does not deal properly with multiple smartcard readers, > only the first one will be working. Add a warning when this happens to > make it easier to diagnose such issues. > > Signed-off-by: Christophe Fergeau ack > --- > src/smartcard-manager.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/src/smartcard-manager.c b/src/smartcard-manager.c > index ceecfdc7..35bb2757 100644 > --- a/src/smartcard-manager.c > +++ b/src/smartcard-manager.c > @@ -389,6 +389,24 @@ typedef struct { > GError *err; > } SmartcardManagerInitArgs; > > + > +static void smartcard_reader_free(gpointer data) > +{ > +g_boxed_free(SPICE_TYPE_SMARTCARD_READER, data); > +} > + > +/* spice-server only supports one smartcard reader being in use */ > +static void smartcard_check_reader_count(void) > +{ > +GList *readers; > + > +readers = > spice_smartcard_manager_get_readers(spice_smartcard_manager_get()); > +if (g_list_length(readers) > 1) { > +g_warning("Multiple smartcard readers are plugged in, only the first > one will be shared with the VM"); > +} > +g_list_free_full(readers, smartcard_reader_free); > +} > + > static gboolean smartcard_manager_init(SmartcardManagerInitArgs *args) > { > gchar *emul_args = NULL; > @@ -442,6 +460,7 @@ init: > "Failed to initialize smartcard"); > goto end; > } > +smartcard_check_reader_count(); > > retval = TRUE; > > -- > 2.20.1 > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-gtk v3] smartcard: Warn if multiple readers are detected
Ping? Or should I just go with one of the earlier versions? On Fri, Feb 22, 2019 at 11:40:32AM +0100, Christophe Fergeau wrote: > spice-server does not deal properly with multiple smartcard readers, > only the first one will be working. Add a warning when this happens to > make it easier to diagnose such issues. > > Signed-off-by: Christophe Fergeau > --- > src/smartcard-manager.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/src/smartcard-manager.c b/src/smartcard-manager.c > index ceecfdc7..35bb2757 100644 > --- a/src/smartcard-manager.c > +++ b/src/smartcard-manager.c > @@ -389,6 +389,24 @@ typedef struct { > GError *err; > } SmartcardManagerInitArgs; > > + > +static void smartcard_reader_free(gpointer data) > +{ > +g_boxed_free(SPICE_TYPE_SMARTCARD_READER, data); > +} > + > +/* spice-server only supports one smartcard reader being in use */ > +static void smartcard_check_reader_count(void) > +{ > +GList *readers; > + > +readers = > spice_smartcard_manager_get_readers(spice_smartcard_manager_get()); > +if (g_list_length(readers) > 1) { > +g_warning("Multiple smartcard readers are plugged in, only the first > one will be shared with the VM"); > +} > +g_list_free_full(readers, smartcard_reader_free); > +} > + > static gboolean smartcard_manager_init(SmartcardManagerInitArgs *args) > { > gchar *emul_args = NULL; > @@ -442,6 +460,7 @@ init: > "Failed to initialize smartcard"); > goto end; > } > +smartcard_check_reader_count(); > > retval = TRUE; > > -- > 2.20.1 > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel signature.asc Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [spice-gtk v3] smartcard: Warn if multiple readers are detected
spice-server does not deal properly with multiple smartcard readers, only the first one will be working. Add a warning when this happens to make it easier to diagnose such issues. Signed-off-by: Christophe Fergeau --- src/smartcard-manager.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/smartcard-manager.c b/src/smartcard-manager.c index ceecfdc7..35bb2757 100644 --- a/src/smartcard-manager.c +++ b/src/smartcard-manager.c @@ -389,6 +389,24 @@ typedef struct { GError *err; } SmartcardManagerInitArgs; + +static void smartcard_reader_free(gpointer data) +{ +g_boxed_free(SPICE_TYPE_SMARTCARD_READER, data); +} + +/* spice-server only supports one smartcard reader being in use */ +static void smartcard_check_reader_count(void) +{ +GList *readers; + +readers = spice_smartcard_manager_get_readers(spice_smartcard_manager_get()); +if (g_list_length(readers) > 1) { +g_warning("Multiple smartcard readers are plugged in, only the first one will be shared with the VM"); +} +g_list_free_full(readers, smartcard_reader_free); +} + static gboolean smartcard_manager_init(SmartcardManagerInitArgs *args) { gchar *emul_args = NULL; @@ -442,6 +460,7 @@ init: "Failed to initialize smartcard"); goto end; } +smartcard_check_reader_count(); retval = TRUE; -- 2.20.1 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel