Ack
(and I pushed them for you)
On 04/07/2011 06:05 PM, Christophe Fergeau wrote:
Hi,
After installing fedora 15, I rebuilt spice with gcc 4.6 (and still with opengl
enabled ;), and found a few more issues which I fixed with these 3 patches.
Christophe
NB: still no commit access to spice
Nice subject prefix :)
Ack.
On 04/07/2011 06:10 PM, Alon Levy wrote:
---
display/driver.c |1 -
display/res.c| 38 ++
2 files changed, 6 insertions(+), 33 deletions(-)
diff --git a/display/driver.c b/display/driver.c
index b129f52..dbe6978
Hmm,
you also change how WAIT_FOR_EVENT get called but
don't change the macro ? Also I would prefer for the
WAIT_FOR_EVENT changes to get broken out into a different patch.
Last some more verbose commit message would be nice (and the same
for the separate WAIT_FOR_EVENT changes patch.
Regards,
Hmm,
snprintf.c is missing a copyright header, also implementing our own
snprintf feels like a serious case of NIH syndrome. Please use an
existing proven implementation like one of these:
http://www.jhweiss.de/software/snprintf.html
Hi,
nit pick, the usual way to do preprocessor macros with { } is:
#define foo(x) \
do { \
bar \
} while (0)
This way you don't end up with a stray ; after the
} which sometimes can lead to issues / warnings.
IE:
if (x)
foo(x);
else
...
Would not work with your way
Ack.
On 04/07/2011 06:10 PM, Alon Levy wrote:
---
display/surface.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/display/surface.h b/display/surface.h
index d741690..e212c46 100644
--- a/display/surface.h
+++ b/display/surface.h
@@ -26,6 +26,9 @@ static _inline
Ack.
On 04/07/2011 06:10 PM, Alon Levy wrote:
---
display/rop.c | 21 +++--
1 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/display/rop.c b/display/rop.c
index dce6e44..29fbe16 100644
--- a/display/rop.c
+++ b/display/rop.c
@@ -1267,7 +1267,15 @@ BOOL
Ack.
On 04/07/2011 06:10 PM, Alon Levy wrote:
---
display/surface.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/display/surface.c b/display/surface.c
index 7146b32..98351e6 100644
--- a/display/surface.c
+++ b/display/surface.c
@@ -106,8 +106,8 @@
Ack.
On 04/07/2011 06:10 PM, Alon Levy wrote:
---
display/surface.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/display/surface.h b/display/surface.h
index d741690..e212c46 100644
--- a/display/surface.h
+++ b/display/surface.h
@@ -26,6 +26,9 @@ static _inline
Hi,
On Fri, Apr 08, 2011 at 11:48:12AM +0200, Hans de Goede wrote:
nit pick, the usual way to do preprocessor macros with { } is:
I was about to nit pick about the same thing ;)
On a side note, I'm curious about the
#define DEBUG_PRINT(arg) DebugPrint arg
which require using double (( as in
On Fri, Apr 08, 2011 at 11:09:59AM +0200, Hans de Goede wrote:
Ack
(and I pushed them for you)
Thanks! This should be the last time,
https://bugs.freedesktop.org/show_bug.cgi?id=35511#c3
Christophe
pgpfnh6m6SaGz.pgp
Description: PGP signature
___
On Fri, Apr 08, 2011 at 11:13:47AM +0200, Hans de Goede wrote:
Hmm,
you also change how WAIT_FOR_EVENT get called but
don't change the macro ? Also I would prefer for the
WAIT_FOR_EVENT changes to get broken out into a different patch.
ok, self NACK, I shouldn't push that TODO - I'll
On Fri, Apr 08, 2011 at 11:48:12AM +0200, Hans de Goede wrote:
Hi,
nit pick, the usual way to do preprocessor macros with { } is:
I'll fix.
#define foo(x) \
do { \
bar \
} while (0)
This way you don't end up with a stray ; after the
} which sometimes can lead to issues
Hi,
I have a stupid question: do spice video drivers exist that work in
windows 2000? I tried installing the qxl driver from the downloads page
-- it appears to install but doesn't work.
Thanks,
Konstantin
___
Spice-devel mailing list
14 matches
Mail list logo
