Re: [Spice-devel] [PATCH 09/15] client: remove c++ wrappers

On Thu, Apr 21, 2011 at 08:06:45PM +0300, Uri Lublin wrote: This breaks windows build with VS. You need to also modify client/windows/redc.vcproj Something like this? diff --git a/client/windows/redc.vcproj b/client/windows/redc.vcproj index b1b7341..0b1ecbf 100644 ---

Re: [Spice-devel] [PATCH 3/8] autotools: correctly build canvas-related code

On Thu, Apr 21, 2011 at 02:00:17PM +0200, Christophe Fergeau wrote: diff --git a/common/Makefile.am b/common/Makefile.am index 0a2f9c1..501a6e1 100644 --- a/common/Makefile.am +++ b/common/Makefile.am @@ -6,7 +6,6 @@ NULL = noinst_LTLIBRARIES = libspice-common.la

[Spice-devel] [PATCH 00/12] More cleanups

Here are again some cleanups, the main highlights are the use of gcc builtin atomic functions to remove some x86 assembly, after this there should no longer be some mandatory x86 assembly, the only remaining bits are a function to get the index of the most significant bit in an integer, and

[Spice-devel] [PATCH 01/12] win32: remove obsolete preprocessor #defines

SW_CANVAS_NO_CHUNKS isn't used anywhere but in this file. SW_CANVAS_CACHE is now defined directly in the files where it's needed so we no longer need it in the .vcproj file. --- client/windows/redc.vcproj |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Spice-devel] [PATCH 07/12] server: use gcc builtin for atomic get/set bit

--- server/red_worker.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/server/red_worker.h b/server/red_worker.h index ae2eaee..b4e2ed2 100644 --- a/server/red_worker.h +++ b/server/red_worker.h @@ -23,12 +23,14 @@ static inline void set_bit(int index, uint32_t

[Spice-devel] [PATCH 08/12] common, server: use ASSERT from spice_common.h

spice_common.h provides an ASSERT macro, no need to duplicate it in many places. For now client/debug.h keeps its own copy since debug.h and spice_common.h have clashes on other macros which are trickier to unify. --- common/canvas_base.c|7 --- common/canvas_utils.c |8

[Spice-devel] [PATCH 09/12] common: use PANIC from spice_common.h

--- common/canvas_base.c |7 --- common/ogl_ctx.c |6 -- common/pixman_utils.c |7 --- 3 files changed, 0 insertions(+), 20 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index a8db367..d11c8ec 100644 --- a/common/canvas_base.c +++

[Spice-devel] [PATCH 10/12] move WARN and WARN_ONCE to spice_common.h

--- common/glc.c |8 common/rop3.c |8 ++-- common/spice_common.h |2 ++ 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/common/glc.c b/common/glc.c index 0396fc9..f85d9f6 100644 --- a/common/glc.c +++ b/common/glc.c @@ -40,14 +40,6 @@

[Spice-devel] [PATCH 11/12] use standard do { } while (0) for spice_common.h macros

--- common/spice_common.h | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/common/spice_common.h b/common/spice_common.h index ed28689..d324ca1 100644 --- a/common/spice_common.h +++ b/common/spice_common.h @@ -28,40 +28,40 @@ abort();

[Spice-devel] [PATCH 12/12] move get_time_stamp to main_channel.c

There is only one user of get_time_stamp from spice_common.h so it's not really useful to keep it there. --- common/spice_common.h |7 --- server/main_channel.c |7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/common/spice_common.h b/common/spice_common.h