Re: [Spice-devel] [PATCH qxl-wddm-dod v4 03/10] Use MmMapIoSpaceEx instead of MmMapIoSpace

2016-09-12 Thread Frediano Ziglio
> > Based on a patch by Sandy Stutsman > > Signed-off-by: Sameeh Jubran > --- > qxldod/QxlDod.cpp | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp > index d07c7b4..93fd8c6 100755 >

Re: [Spice-devel] [PATCH qxl-wddm-dod v4 07/10] Fixing framebuffer usage logic

2016-09-12 Thread Frediano Ziglio
> > This patch fixes 2 issues: > > 1. Framebuffer should only be used in vga mode, > therefore when QxlDevice is active > FrameBufferIsActive flag shouldn't be checked; > 2. FrameBufferIsActive flag should be set true > on successfull frame buffer allocation only. > >

Re: [Spice-devel] (no subject)

2016-09-12 Thread Pavel Grunt
Hello, On Mon, 2016-09-12 at 17:15 +0800, Qingyun Ao wrote: > Hello, all, > > > Is it possible to use spice with h264 feature on Raspberry Pi? If > yes, how? You would need to compile & use spice-gtk and spice server with gstreamer video support. For server it is ./configure --enable-

Re: [Spice-devel] [PATCH qxl-wddm-dod v4 05/10] Use the second bar (VRAM) for qxl command buffer.

2016-09-12 Thread Frediano Ziglio
> > Based on a patch by Sandy Stutsman > > Acked-by: Frediano Ziglio > > Signed-off-by: Sameeh Jubran Merged Frediano ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] [PATCH qxl-wddm-dod v4 02/10] Add arbitrary resolution and monitors_config Escape

2016-09-12 Thread Frediano Ziglio
> This patch adds introduces support for arbitrary resolution and > updating monitor configurations using custom ioctls. > > This patch doesn't make any restriction for minimal resolution at all > as Windows can handle low resolution just fine, moreover the old (XPDM) > driver behaves like this

[Spice-devel] [PATCH] SPICE port draft implementation

2016-09-12 Thread Oliver Gutierrez
--- enums.js| 11 - main.js | 7 +++- port.js | 125 spice.html | 1 + spice_auto.html | 3 +- 5 files changed, 143 insertions(+), 4 deletions(-) create mode 100644 port.js diff --git a/enums.js

[Spice-devel] RFC - SPICE port draft implementation

2016-09-12 Thread Oliver Gutierrez
This is a fist draft of the SPICE port feature in spice-html5 There is only support for receiving messages right now. The port-event and port-data callbacks are set just like other javascript event listeners in the window object (Maybe we can move this to the main channel) Also we need to

[Spice-devel] (no subject)

2016-09-12 Thread Qingyun Ao
Hello, all, Is it possible to use spice with h264 feature on Raspberry Pi? If yes, how? aoqing...@gmail.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH qxl-wddm-dod v4 01/10] Fixed misspelling

2016-09-12 Thread Frediano Ziglio
> Fixed misspelling: HwDeviceInterface > Fixed misspelling: GetDxgkInterface > > Based on a patch by Sandy Stutsman > > Signed-off-by: Sameeh Jubran Acked-by: Frediano Ziglio > --- > qxldod/QxlDod.cpp | 4 ++-- > qxldod/QxlDod.h

Re: [Spice-devel] [PATCH qxl-wddm-dod v4 04/10] Code Analysis fix

2016-09-12 Thread Frediano Ziglio
> > The PAGED_CODE macro ensures that the calling thread is running at an > IRQL that is low enough to permit paging. A call to this macro should > be made at the beginning of every driver routine that either contains > pageable code or accesses pageable code. > > Based on a patch by Sandy

Re: [Spice-devel] [spice-server 1/3] encoders: Introduce RedChunkIterator

2016-09-12 Thread Li Zhijian
On 09/09/2016 09:37 PM, Christophe Fergeau wrote: This will be used by the GStreamer/mjpeg encoders to get linear data out of a SpiceChunks (which is an array of (binary data, size)). --- server/Makefile.am | 2 + server/red-chunk-iterator.c| 144

Re: [Spice-devel] (no subject)

2016-09-12 Thread Christophe Fergeau
Hey, On Mon, Sep 12, 2016 at 05:15:05PM +0800, Qingyun Ao wrote: > Is it possible to use spice with h264 feature on Raspberry Pi? If yes, how? At this point, if you want the h264 encoding/decoding to be hardware-accelerated, no it's not possible. If there are some GStreamer elements providing

[Spice-devel] [PATCH] Avoid recursive inclusion of headers

2016-09-12 Thread Frediano Ziglio
red-common.h included utils.h which included red-common.h Signed-off-by: Frediano Ziglio --- server/main-channel-client.c | 1 + server/red-channel-client.c | 1 + server/red-common.h | 1 - server/red-worker.h | 1 + server/sound.c | 1 +

[Spice-devel] [PATCH] replay: Handle errors in record file

2016-09-12 Thread Frediano Ziglio
Detect errors in record file. This can happen from a wrong version or corruption of files. Allocations are kept into a GList to be able to free in case some errors happened. To check fscanf read all needed information a dummy "%n" is appended to any string and the value stored there is tested.

Re: [Spice-devel] [PATCH] Remove unused structure declaration

2016-09-12 Thread Pavel Grunt
Ack, Pavel On Mon, 2016-09-12 at 12:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/inputs-channel.c | 4 >  1 file changed, 4 deletions(-) > > diff --git a/server/inputs-channel.c b/server/inputs-channel.c > index da0f027..ce86d7e

Re: [Spice-devel] [PATCH] Remove global key_modifiers_timer variable

2016-09-12 Thread Pavel Grunt
On Mon, 2016-09-12 at 12:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt > --- >  server/inputs-channel.c | 13 ++--- >  1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/server/inputs-channel.c

Re: [Spice-devel] [PATCH spice 1/2] agent-filter: Constantify parameter

2016-09-12 Thread Frediano Ziglio
> > Filter should not modify data Acked-by: Frediano Ziglio > --- > server/agent-msg-filter.c | 2 +- > server/agent-msg-filter.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c > index

[Spice-devel] [PATCH] Remove unused structure declaration

2016-09-12 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/inputs-channel.c | 4 1 file changed, 4 deletions(-) diff --git a/server/inputs-channel.c b/server/inputs-channel.c index da0f027..ce86d7e 100644 --- a/server/inputs-channel.c +++ b/server/inputs-channel.c @@ -116,10 +116,6 @@

[Spice-devel] [PATCH] Remove global key_modifiers_timer variable

2016-09-12 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/inputs-channel.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/server/inputs-channel.c b/server/inputs-channel.c index ce86d7e..2738be4 100644 --- a/server/inputs-channel.c +++

[Spice-devel] [PATCH spice 2/2] reds: Refactor agent message forwarding

2016-09-12 Thread Pavel Grunt
--- server/reds.c | 55 --- 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/server/reds.c b/server/reds.c index 800107b..a13a14a 100644 --- a/server/reds.c +++ b/server/reds.c @@ -763,34 +763,18 @@ static void

[Spice-devel] [PATCH spice 1/2] agent-filter: Constantify parameter

2016-09-12 Thread Pavel Grunt
Filter should not modify data --- server/agent-msg-filter.c | 2 +- server/agent-msg-filter.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c index 3e5b225..a11f624 100644 --- a/server/agent-msg-filter.c +++

Re: [Spice-devel] [PATCH spice 2/2] reds: Refactor agent message forwarding

2016-09-12 Thread Pavel Grunt
On Mon, 2016-09-12 at 08:38 -0400, Frediano Ziglio wrote: > I think the rationale of this is to remove the error return > parameter and > make vdi_port_read_buf_process easier/shorter. Yes, also I have some patches which will make use of the return value > > > > > --- > >  server/reds.c | 55

Re: [Spice-devel] [PATCH spice 2/2] reds: Refactor agent message forwarding

2016-09-12 Thread Frediano Ziglio
I think the rationale of this is to remove the error return parameter and make vdi_port_read_buf_process easier/shorter. > > --- > server/reds.c | 55 --- > 1 file changed, 20 insertions(+), 35 deletions(-) > > diff --git a/server/reds.c

[Spice-devel] [PATCH 1/2] Change GList in GQueue

2016-09-12 Thread Frediano Ziglio
This patch is intended to be merged into "RedChannelClient: store pipe items in a GList". GQueue improve GList for pipe usage as tail inserting/removal/access are O(1) instead of O(n). Also getting the number of items is O(1) instead of O(n). Signed-off-by: Frediano Ziglio

[Spice-devel] [PATCH 2/2] Optimise client pipe passing pipe position instead of data

2016-09-12 Thread Frediano Ziglio
This avoid to have the search the data scanning all the queue changing the order of these operations from O(n) to O(1). Signed-off-by: Frediano Ziglio --- server/dcc-send.c | 9 - server/dcc.c| 20 +--- server/dcc.h

[Spice-devel] [PATCH 0/2] Improve "RedChannelClient: store pipe items in a GList" patch

2016-09-12 Thread Frediano Ziglio
I these patches should be merged to the sent patch. Mainly use a GQueue and do some optimization removing some regressions introduced by previous patch. Frediano Ziglio (2): Change GList in GQueue Optimise client pipe passing pipe position instead of data server/dcc-send.c

Re: [Spice-devel] WDDM driver for Win7?

2016-09-12 Thread Frediano Ziglio
> Is there a way to get the WDDM driver to work on Win7? > I am having annoying flicker issues with the XDDM driver, where parts of the > display that refresh (such as a moving chart) produces seizure inducing > flickering on just that part of the display. I am assuming its some "what > changed"

[Spice-devel] [PATCH spice] agent-filter: Use enum as return value

2016-09-12 Thread Pavel Grunt
--- server/agent-msg-filter.c | 4 ++-- server/agent-msg-filter.h | 10 +- server/reds.c | 8 +--- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/server/agent-msg-filter.c b/server/agent-msg-filter.c index a11f624..7921fe7 100644 ---

Re: [Spice-devel] WDDM driver for Win7?

2016-09-12 Thread Vans S
WDDM on windows 10 does not produce the flickers but the mouse is not as snappy as windows 7.  I think this could perhaps be due to Win10 itself.  I read that WDDM is supported from Vista and onward, why cant the qxl-wddm-dod driver work for windows 7 as well, maybe I am doing something wrong

Re: [Spice-devel] [PATCH 10/10] Change RedCharDevicePrivate::clients to GList

2016-09-12 Thread Frediano Ziglio
> > HHey, > > On Fri, Sep 09, 2016 at 10:47:12AM -0400, Frediano Ziglio wrote: > > > > > > More Ring cleanup > > > > Personally I don't approve the rationale. > > > > Rings are used by Qemu and Linux kernel, Qemu calls us directly and > > we deal with Linux too. Not counting all BSD code. So

Re: [Spice-devel] WDDM driver for Win7?

2016-09-12 Thread 谢昆明
WDDM on windows 10 does not produce the flickers but the mouse is not as snappy as windows 7. I think this could perhaps be due to Win10 itself. I read that WDDM is supported from Vista and onward, why cant the qxl-wddm-dod driver work for windows 7 as well, maybe I am doing something wrong

Re: [Spice-devel] WDDM driver for Win7?

2016-09-12 Thread Vans S
That table answers it. Thanks 谢昆明.  I think I need to make a separate discussion now about the flicker, I managed to record video using a physical camera showing the flicker. But any screen recorder soft in the guest does not capture it. On Monday, September 12, 2016 9:13 PM, 谢昆明