Re: [Spice-devel] [spice-server PATCH 1/8] current_remove: rename internal variable 'container'

2016-10-17 Thread Frediano Ziglio
> > It shadows the outer one. > > Signed-off-by: Uri Lublin > --- > > Possibly more meaningful names than container and container2 > should be used > > --- > server/display-channel.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [Spice-devel] [spice-server PATCH 8/8] red-record-qxl: child_output_setup: check fcntl return value

2016-10-17 Thread Frediano Ziglio
> > Also replaced "continue" in while block with an empty > block (added curly braces). > I think you split this in 7/8. > Found by coverity. > > Signed-off-by: Uri Lublin > --- > server/red-record-qxl.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >

Re: [Spice-devel] [spice-server PATCH 3/8] input-channel: add a comment to mark fallthrough in switch

2016-10-17 Thread Frediano Ziglio
> > Signed-off-by: Uri Lublin > --- > server/inputs-channel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/server/inputs-channel.c b/server/inputs-channel.c > index 840d5e9..ee81bb4 100644 > --- a/server/inputs-channel.c > +++ b/server/inputs-channel.c > @@ -285,6

Re: [Spice-devel] [spice-server PATCH 7/8] red-record-qxl: replace continue with empty block

2016-10-17 Thread Frediano Ziglio
> > Spice coding style suggests to use curly braces > for while blocks. > > Signed-off-by: Uri Lublin > --- > server/red-record-qxl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c > index

Re: [Spice-devel] [spice-server PATCH 5/8] mjpeg_encoder_new: allocate memory after sanity check

2016-10-17 Thread Frediano Ziglio
> This patch prevents a leak in case the function returns early > > Found by coverity. > > Signed-off-by: Uri Lublin > --- > server/mjpeg-encoder.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c >

Re: [Spice-devel] [spice-server PATCH 6/8] red_get_image_data_flat: allocate mem after sanity check

2016-10-17 Thread Frediano Ziglio
> > This patch prevents possible memory leak. > > Found by coverity. > > Signed-off-by: Uri Lublin > --- > server/red-parse-qxl.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/server/red-parse-qxl.c b/server/red-parse-qxl.c > index

Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

2016-10-17 Thread Pavel Grunt
Hi Victor, On Sat, 2016-10-15 at 15:38 +0200, Victor Toso wrote: > Hi, > > On Thu, Sep 29, 2016 at 12:28:44PM +0100, Frediano Ziglio wrote: > > Small update for this patchset: > > - fix headers in "Extended protocol documentation"; > > - added some more documentation on attributes. > > > >

Re: [Spice-devel] [PATCH spice-server v3 1/3] Add CommonGraphicsChannelPrivate struct

2016-10-17 Thread Pavel Grunt
On Fri, 2016-10-14 at 10:40 -0400, Frediano Ziglio wrote: > > > > From: Jonathon Jongsma > > > > Encapsulate private data for CommonGraphicsChannel and prepare for > > GObject conversion. > > --- > >  server/common-graphics-channel.c | 33 > >

Re: [Spice-devel] [spice-server PATCH 2/8] image_encoders: check shared_dict before accessing it

2016-10-17 Thread Frediano Ziglio
> > In both image_encoders_restore_glz_dictionary() and > image_encoders_get_glz_dictionary() shared-dict may > be NULL if size is too large, and the server gets > size from the network. > > Both functions end up calling glz_enc_dictionary_create() > that calls glz_dictionary_window_create()

Re: [Spice-devel] [protocol 0/3] Fixing the *_DEPRECATED set of macros

2016-10-17 Thread Francois Gouget
On Thu, 1 Sep 2016, Christophe Fergeau wrote: > On Thu, Aug 11, 2016 at 04:28:58PM +0200, Francois Gouget wrote: > > > > The following patch broke compilation of xf86-video-qxl: > > > > commit b41220b1441b8adea6db9a98e9da1b43a8f426bb > > Author: Christophe Fergeau > >

Re: [Spice-devel] [spice-server PATCH 4/8] main-channel: getpeername/getsockname return early if no sockfd

2016-10-17 Thread Frediano Ziglio
> > I'm not sure that needed as it seems getpeername/getsockname > accept int fd and return -1 for fd=-1 > > Signed-off-by: Uri Lublin > --- > server/main-channel.c | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

2016-10-17 Thread Frediano Ziglio
> > Hi Victor, > > On Sat, 2016-10-15 at 15:38 +0200, Victor Toso wrote: > > Hi, > > > > On Thu, Sep 29, 2016 at 12:28:44PM +0100, Frediano Ziglio wrote: > > > Small update for this patchset: > > > - fix headers in "Extended protocol documentation"; > > > - added some more documentation on

Re: [Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

2016-10-17 Thread Frediano Ziglio
> > From: Jonathon Jongsma > > Encapsulate MainChannel a bit better in preparation for proting to > GObject. > --- > server/main-channel-client.c | 24 +++- > server/main-channel.c| 15 +++ > server/main-channel.h| 2 ++ > 3

Re: [Spice-devel] [PATCH v2 0/4] Protocol file syntax documentation

2016-10-17 Thread Victor Toso
Hi, > > Not sure if I understand you correctly - but you should not modify > > enums.h by yourself. As the first line of the file says, it should > > be generated by spice_codegen.py (spice-common repository), eg: > > > > ./spice_codegen.py -e spice.proto ../spice-protocol/spice/enums.h So, that

Re: [Spice-devel] [spice-gtk v2] clipboard: Fix crash by handling error

2016-10-17 Thread Pavel Grunt
Hey, On Sat, 2016-10-15 at 14:15 +0200, victort...@redhat.com wrote: > From: Victor Toso > > As manual states below, text could be NULL for different reasons and > we should handle that. I've included a debug message to help > identifying possible regressions from wayland's

Re: [Spice-devel] Very poor video performance using Virt Viewer compared to RDP

2016-10-17 Thread Francois Gouget
On Mon, 17 Oct 2016, Brad Wilson wrote: > Ok, so I installed the AC97 audio drivers to fix my audio device in > the guest vm.  Using Virt-Viewer with qxl, the video streaming has > improved and I am seeing closer to 1.5Mbps network traffic now when > watching hd videos but the quality is still

Re: [Spice-devel] [protocol 0/3] Fixing the *_DEPRECATED set of macros

2016-10-17 Thread Francois Gouget
On Mon, 17 Oct 2016, Francois Gouget wrote: [...] > > Imo this SPICE_NO_DEPRECATED is only meant to be used internally by > > spice-gtk even if this is not really documented. I would not consider it > > breakage if this was removed, or changed in incompatible ways. > > And it turns out it's

[Spice-devel] [PATCH spice-server 03/10] Avoid to typedef twice CursorChannel

2016-10-17 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/cursor-channel-client.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/cursor-channel-client.h b/server/cursor-channel-client.h index 2336b95..fab6837 100644 --- a/server/cursor-channel-client.h +++

[Spice-devel] [PATCH spice-server 00/10] Some RHEL6 compatibility patches

2016-10-17 Thread Frediano Ziglio
These patches try to solve (or at least minimize) RHEL6 compatibilty issues. Beside the last one other patches are small and sensible and do not break defined rules. Frediano Ziglio (9): Define a compatibility include for GLib Include GLib compatibility header where needed Avoid to typedef

[Spice-devel] [PATCH spice-server 02/10] Include GLib compatibility header where needed

2016-10-17 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/char-device.c| 1 + server/red-channel-client.c | 1 + 2 files changed, 2 insertions(+) diff --git a/server/char-device.c b/server/char-device.c index 4f01d3c..7775c07 100644 --- a/server/char-device.c +++

[Spice-devel] [PATCH spice-server 08/10] Include main-channel-client.h where MainChannelClient is used

2016-10-17 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/dcc.c | 1 + server/main-channel.c | 3 ++- server/red-qxl.c | 1 + server/reds.c | 1 + server/sound.c| 1 + server/stream.c | 1 + 6 files changed, 7 insertions(+), 1 deletion(-) diff --git

[Spice-devel] [PATCH spice-server 06/10] Include directly used header in dcc.h

2016-10-17 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/dcc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/server/dcc.h b/server/dcc.h index 2456f09..7a07981 100644 --- a/server/dcc.h +++ b/server/dcc.h @@ -25,6 +25,7 @@ #include "pixmap-cache.h" #include "red-worker.h" #include

[Spice-devel] [PATCH spice-server 10/10] RFC: Make code compile using RHEL 6

2016-10-17 Thread Frediano Ziglio
Quite questionable patch. Mostly as come typedef are not defined in the place they naturally should be. Signed-off-by: Frediano Ziglio --- server/main-channel-client.h | 5 + server/main-channel.h| 1 - server/red-channel-client.h | 1 - server/stream.h

[Spice-devel] [PATCH spice-server 01/10] Define a compatibility include for GLib

2016-10-17 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/Makefile.am | 1 + server/glib-compat.h | 47 +++ 2 files changed, 48 insertions(+) create mode 100644 server/glib-compat.h diff --git a/server/Makefile.am b/server/Makefile.am index

[Spice-devel] [PATCH spice-server 04/10] Avoid to typedef twice DisplayChannelClientPrivate

2016-10-17 Thread Frediano Ziglio
DisplayChannelClientPrivate is already defined in dcc.h which is included in dcc-private.h header. Signed-off-by: Frediano Ziglio --- server/dcc-private.h | 1 - 1 file changed, 1 deletion(-) diff --git a/server/dcc-private.h b/server/dcc-private.h index de6ea92..f3aba50

[Spice-devel] protocol: Group the VDAgent clipboard message definitions

2016-10-17 Thread Francois Gouget
Signed-off-by: Francois Gouget --- spice/vd_agent.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/spice/vd_agent.h b/spice/vd_agent.h index 445b458..c49f596 100644 --- a/spice/vd_agent.h +++ b/spice/vd_agent.h @@ -180,6 +180,12 @@ enum

[Spice-devel] [spice-server] Avoid to typedef twice SmartCardChannelClient

2016-10-17 Thread Francois Gouget
SmartCardChannelClient is already defined in smartcard.h which is included in the smartcard-channel-client.h header. Signed-off-by: Francois Gouget --- This patch series is nice and really does help. I would add this patch to it. server/smartcard-channel-client.h | 1

Re: [Spice-devel] [spice-gtk v2] clipboard: Fix crash by handling error

2016-10-17 Thread Victor Toso
Hi, On Mon, Oct 17, 2016 at 02:38:29PM +0200, Pavel Grunt wrote: > Hey, > > On Sat, 2016-10-15 at 14:15 +0200, victort...@redhat.com wrote: > > From: Victor Toso > > > > As manual states below, text could be NULL for different reasons and > > we should handle that. I've

[Spice-devel] [PATCH spice-server 00/10] Some RHEL6 compatibility patches

2016-10-17 Thread Frediano Ziglio
These patches try to solve (or at least minimize) RHEL6 compatibilty issues. Beside the last one other patches are small and sensible and do not break defined rules. Frediano Ziglio (9): Include GLib compatibility header where needed Avoid to typedef twice CursorChannel Avoid to typedef

[Spice-devel] [PATCH spice-server 09/10] red-worker: Do not include not necessary red-channel-client.h

2016-10-17 Thread Frediano Ziglio
Definitions are all in red-channel.h Signed-off-by: Frediano Ziglio --- server/red-worker.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-worker.h b/server/red-worker.h index dc2ff24..cf61a67 100644 --- a/server/red-worker.h +++

[Spice-devel] [PATCH spice-server 07/10] Avoid to typedef twice RedChannel and RedClient

2016-10-17 Thread Frediano Ziglio
These are already defined in red-channel.h which is included in red-channel-client.h header. Signed-off-by: Frediano Ziglio --- server/red-channel-client.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/server/red-channel-client.h b/server/red-channel-client.h index

[Spice-devel] [PATCH spice-server 05/10] Do not typedef DisplayChannel twice

2016-10-17 Thread Frediano Ziglio
Already defined in dcc.h. Signed-off-by: Frediano Ziglio --- server/stream.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/server/stream.h b/server/stream.h index 77223c8..a415e43 100644 --- a/server/stream.h +++ b/server/stream.h @@ -42,9 +42,6 @@ #define

Re: [Spice-devel] protocol: Group the VDAgent clipboard message definitions

2016-10-17 Thread Frediano Ziglio
> > Signed-off-by: Francois Gouget > --- > spice/vd_agent.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/spice/vd_agent.h b/spice/vd_agent.h > index 445b458..c49f596 100644 > --- a/spice/vd_agent.h > +++ b/spice/vd_agent.h > @@

Re: [Spice-devel] [spice-server] Avoid to typedef twice SmartCardChannelClient

2016-10-17 Thread Frediano Ziglio
> > SmartCardChannelClient is already defined in smartcard.h which > is included in the smartcard-channel-client.h header. > > Signed-off-by: Francois Gouget > --- > > This patch series is nice and really does help. > I would add this patch to it. > Is there