qdev->gem.objects was initialized directly in qxl_device_init() rather
than going through qxl_gem_init(), and qxl_gem_fini() was never called.
Signed-off-by: Christophe Fergeau
---
drivers/gpu/drm/qxl/qxl_kms.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
They are not used outside of their respective source file
Signed-off-by: Christophe Fergeau
---
drivers/gpu/drm/qxl/qxl_cmd.c | 2 +-
drivers/gpu/drm/qxl/qxl_display.c | 4 ++--
drivers/gpu/drm/qxl/qxl_drv.h | 3 ---
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/
Hey,
Same series as v2 except that I removed the use of camel case in patch 6/7.
Now it's only using an anonymous enum + int.
Christophe
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spi
The message has to be terminated by a newline as it's not going to get
added automatically.
Signed-off-by: Christophe Fergeau
---
drivers/gpu/drm/qxl/qxl_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
index 28c
qxl_crtc_set_from_monitors_config() is defined in qxl_drv.h but never
implemented.
Signed-off-by: Christophe Fergeau
---
drivers/gpu/drm/qxl/qxl_drv.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index a3c1131..5a4720a 100644
It's always returning 0, and it's always ignored.
---
drivers/gpu/drm/qxl/qxl_drv.h | 2 +-
drivers/gpu/drm/qxl/qxl_gem.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h
index 5a4720a..feac7e6 100644
--- a/driver
The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that
the resolutions we are going to present to user-space are going to be
rounded down to a multiple of 8. In the QXL arbitrary resolution case,
this is not useful.
This commit forces the actual width/height that was requested by t
When the QXL driver receives a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG interrupt,
we currently always notify userspace that there was some hotplug event.
However, gnome-shell/mutter is reacting to this event by attempting a
resolution change, which it does by issueing drmModeRmFB, drmModeAddFB,
and t
On Fri, Nov 04, 2016 at 08:48:48PM +0100, Thorsten Kohfeldt wrote:
> > Binary builds can be found at
> > https://copr.fedorainfracloud.org/coprs/teuf/spice-mingw/build/473299/
>
> Nice offer,
> but I'm a little confused by that plethora of choices:
>
> 3 target releases (F23, F24, rawhide), 2 arc
Hi,
> I think we should try it an see,
Ok, lets try. I'll go pick them up and prepare a pull with this and
some virtio-gpu bits,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spi
>
> It's always returning 0, and it's always ignored.
Missing the Signed-off-by.
Acked-by: Frediano Ziglio
You should add the Acked-by message when posting new
versions of the patch series.
Frediano
> ---
> drivers/gpu/drm/qxl/qxl_drv.h | 2 +-
> drivers/gpu/drm/qxl/qxl_gem.c | 3 +--
> 2
>
> When the QXL driver receives a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG
> interrupt,
> we currently always notify userspace that there was some hotplug event.
>
> However, gnome-shell/mutter is reacting to this event by attempting a
> resolution change, which it does by issueing drmModeRmFB, drmM
On Mo, 2016-11-07 at 09:00 +0100, Christophe Fergeau wrote:
> Hey,
>
> Same series as v2 except that I removed the use of camel case in patch 6/7.
> Now it's only using an anonymous enum + int.
Can you please not drop the "PATCH" from $subject?
thanks,
Gerd
___
On Mon, Nov 07, 2016 at 04:08:48AM -0500, Frediano Ziglio wrote:
> > @@ -124,9 +157,18 @@ void qxl_display_read_client_monitors_config(struct
> > qxl_device *qdev)
> > {
> >
> > struct drm_device *dev = qdev->ddev;
> > - while (qxl_display_copy_rom_client_monitors_config(qdev)) {
> > + i
On Mon, Nov 07, 2016 at 10:07:58AM +0100, Thorsten Kohfeldt wrote:
>
> Am 07.11.2016 um 09:10 schrieb Christophe Fergeau:
> > On Fri, Nov 04, 2016 at 08:48:48PM +0100, Thorsten Kohfeldt wrote:
> > > > Binary builds can be found at
> > > > https://copr.fedorainfracloud.org/coprs/teuf/spice-mingw/bu
Signed-off-by: Frediano Ziglio
---
qxldod/QxlDod.cpp | 2 +-
qxldod/compat.cpp | 10 ++
qxldod/compat.h | 10 ++
qxldod/driver.cpp | 2 +-
4 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
index 69b8db9..85343e4 100755
--- a/
Acked-by: Christophe Fergeau
On Mon, Nov 07, 2016 at 09:29:44AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> qxldod/QxlDod.cpp | 2 +-
> qxldod/compat.cpp | 10 ++
> qxldod/compat.h | 10 ++
> qxldod/driver.cpp | 2 +-
> 4 files changed, 22 inserti
>
>
> Acked-by: Christophe Fergeau
>
> On Mon, Nov 07, 2016 at 09:29:44AM +, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > qxldod/QxlDod.cpp | 2 +-
> > qxldod/compat.cpp | 10 ++
> > qxldod/compat.h | 10 ++
> > qxldod/driver.cpp | 2 +-
> > 4
On Mon, Nov 07, 2016 at 04:40:11AM -0500, Frediano Ziglio wrote:
> >
> >
> > Acked-by: Christophe Fergeau
> >
> > On Mon, Nov 07, 2016 at 09:29:44AM +, Frediano Ziglio wrote:
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > qxldod/QxlDod.cpp | 2 +-
> > > qxldod/compat.cpp | 10 +
On Wed, 2 Nov 2016, Jonathon Jongsma wrote:
[...]
> > /* Callbacks with this type will be called when a complete message has been
> > - * received. The callback may call udscs_destroy_connection, in which case
> > - * *connp must be made NULL (which udscs_destroy_connection takes care of).
> > + *
On Mon, Nov 07, 2016 at 10:53:38AM +0100, Thorsten Kohfeldt wrote:
>
> Am 07.11.2016 um 10:21 schrieb Christophe Fergeau:
> > On Mon, Nov 07, 2016 at 10:07:58AM +0100, Thorsten Kohfeldt wrote:
> > >
> > > BTW,
> > > _all_ binaries' details state 'Version 0.5.1.0, copyright RH 2009'.
> > > Here it
>
> ---
> Changes in v2:
> - pass 'channel' property to char device constructor
> - assert that 'channel' device is non-null in char device set_property
> - minor indentation fix
>
> server/spicevmc.c | 83
> ---
> 1 file changed, 61 insert
Signed-off-by: Frediano Ziglio
---
server/inputs-channel-client.c | 28 +++-
server/inputs-channel-client.h | 13 -
2 files changed, 15 insertions(+), 26 deletions(-)
diff --git a/server/inputs-channel-client.c b/server/inputs-channel-client.c
index 4ab2457..7
Now RED_CHANNEL_CLIENT is a function call so avoid to call multiple
time for the same conversion in the same functions.
This speed up and reduce code and also reduce source line
length.
Signed-off-by: Frediano Ziglio
---
server/dcc.c | 40 +---
ser
Now RED_CHANNEL is a function call so avoid to call multiple
time for the same conversion in the same functions.
This speed up and reduce code and also reduce source line
length.
Signed-off-by: Frediano Ziglio
---
server/cursor-channel.c | 12
server/display-channel.c | 7 ---
Basically optimizations.
Frediano Ziglio (3):
Relax conversion to RedChannel
Relax conversion to RedChannelClient
Move InputsChannelClient and InputsChannelClient definition to C file
server/cursor-channel.c| 12 +++
server/dcc.c | 40 +++--
Hi,
On Fri, Nov 04, 2016 at 10:42:17AM -0500, Jeremy White wrote:
>
> On 10/28/2016 05:18 AM, Christophe Fergeau wrote:
> > xspice needs to be updated to cope with some X.Org 1.19 API changes,
> > better to make that explicit at configure time rather than letting
> > people discover the hard way
>
> On 10/17/2016 01:38 PM, Frediano Ziglio wrote:
> >>
> >> I'm not sure that needed as it seems getpeername/getsockname
> >> accept int fd and return -1 for fd=-1
> >>
> >> Signed-off-by: Uri Lublin
> >> ---
> >> server/main-channel.c | 16 ++--
> >> 1 file changed, 14 insertions(+
>
> On 10/17/2016 01:08 PM, Frediano Ziglio wrote:
> >>
> >> Also replaced "continue" in while block with an empty
> >> block (added curly braces).
> >>
> >
> > I think you split this in 7/8.
>
> Right, I'll remove it.
>
> >
> >> Found by coverity.
> >>
> >> Signed-off-by: Uri Lublin
> >> ---
>
On Mon, Nov 07, 2016 at 11:13:21AM +, Frediano Ziglio wrote:
> Now RED_CHANNEL is a function call so avoid to call multiple
> time for the same conversion in the same functions.
> This speed up and reduce code and also reduce source line
> length.
To be honest, these are not really convinci
Duplicate InputsChannelClient in the short log?
This also seems to be removing InputsChannelClientPrivate, it would be
worth a mention in the log.
Also, what is this bringing us in concrete terms? Ensuring internal
users of InputsChannelClient can't try to inherit from it?
Christophe
On Mon, Nov
Acked-by: Christophe Fergeau
On Thu, Nov 03, 2016 at 01:30:07PM +0100, Pavel Grunt wrote:
> Fail on glib warnings instead of ignoring them
>
> Signed-off-by: Pavel Grunt
> ---
> server/tests/spice-options-test.c | 11 +--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --g
On Fri, Nov 04, 2016 at 11:19:22AM -0500, Jonathon Jongsma wrote:
> Use g_param_spec_object() instead of g_param_spec_pointer() for the
> 'client' and 'channel' properties now that these types are GObjects.
> This improves refcounting and typesafety slightly.
> ---
> server/red-channel-client.c |
>
> On Fri, Nov 04, 2016 at 11:19:22AM -0500, Jonathon Jongsma wrote:
> > Use g_param_spec_object() instead of g_param_spec_pointer() for the
> > 'client' and 'channel' properties now that these types are GObjects.
> > This improves refcounting and typesafety slightly.
> > ---
> > server/red-chan
Acked-by: Christophe Fergeau
On Wed, Nov 02, 2016 at 04:36:40PM +0100, Francois Gouget wrote:
> EADDRINUSE usually means the socket file was left behind after a crash.
>
> Signed-off-by: Francois Gouget
> ---
> src/vdagentd/vdagentd.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deleti
On Wed, Nov 02, 2016 at 04:38:05PM +0100, Francois Gouget wrote:
> udsc is an internal library of sorts that's irrelevant to users.
I've split this in 2 commits (the change which is described in the log +
one with the cosmetic changes) and pushed this.
Acked-by: Christophe Fergeau
>
> Signed-o
On Mon, Oct 31, 2016 at 09:50:54PM +0100, Francois Gouget wrote:
> Group the options more logically and improve their descriptions.
> In the Xorg configuration, always show the default in the
> commented-out sample.
>
> Signed-off-by: Francois Gouget
> ---
> examples/spiceqxl.xorg.conf.example |
>
> On Mon, Oct 31, 2016 at 09:50:54PM +0100, Francois Gouget wrote:
> > Group the options more logically and improve their descriptions.
> > In the Xorg configuration, always show the default in the
> > commented-out sample.
> >
> > Signed-off-by: Francois Gouget
> > ---
> > examples/spiceqxl.
On Mon, 2016-11-07 at 12:16 -0500, Frediano Ziglio wrote:
> >
> >
> > On Fri, Nov 04, 2016 at 11:19:22AM -0500, Jonathon Jongsma wrote:
> > >
> > > Use g_param_spec_object() instead of g_param_spec_pointer() for
> > > the
> > > 'client' and 'channel' properties now that these types are
> > > GOb
39 matches
Mail list logo