>
> I'm a little bit confused. This appears to be the third patch series
> that is designated "v4". That means this should actually be v6, no?
> (although the previous series was sent exactly 1 minute before this
> one, so maybe they're the same?)
>
Yes, did some mistakes preparing and sending ve
>
> On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote:
> > SndWorker has been historically based on RedChannel, initial git
> > commit
> > has:
> > struct SndWorker {
> > Channel base;
> > ...
> > };
>
>
> I'd add a short note to the commit log explaining that this is only
> pos
>
> On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote:
> > This code is the same inside __new_channel but will set the
> > RedsStream from RedChannel.
>
> Shouldn't this code be removed from __new_channel() then?
>
I'd prefer to keep the functionality and remove when the
feature is repla
>
> On Thu, 2016-12-01 at 11:09 +, Frediano Ziglio wrote:
> > Allows to destroy a QXL object
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/red-qxl.c| 25 ++---
> > server/red-qxl.h| 1 +
> > server/red-worker.c | 35 ++
Signed-off-by: Frediano Ziglio
---
server/sound.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/sound.c b/server/sound.c
index 307d292..5e056b6 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -418,7 +418,7 @@ static int snd_record_handle_message(SndChannelClient
Signed-off-by: Frediano Ziglio
---
server/sound.c | 37 ++---
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 59e2e4b..777cdbc 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -1169,15 +1169,15 @@ SPICE_GNUC_
Previously these frames were allocated inside PlaybackChannelClient
while now they are allocated in a different structure.
This allows the samples to outlive the PlaybackChannelClient.
This was possible even before and the client was kept alive.
However we are moving to have RedChannelClient as a b
This code is the same inside __new_channel but will set the
RedsStream from RedChannel.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 46 +-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/server/sound.c b/server/sound.c
index 912dc
red_channel_client_handle_message can handle base messages
so reuse it.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index ed20125..04e08a2 100644
--- a/server/sound.c
+++ b/
Stops using the dummy channel.
Data handling still goes through DummyChannelClient which is why
empty implementation of some required vfuncs is working.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 245 ++
1 file changed, 171 insertions(+),
Signed-off-by: Frediano Ziglio
---
server/red-channel-client-private.h | 11 +++
server/red-channel-client.c | 12 ++--
server/red-channel-client.h | 13 -
3 files changed, 17 insertions(+), 19 deletions(-)
diff --git a/server/red-channel-client-privat
Signed-off-by: Frediano Ziglio
---
server/sound.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 2a4472c..fed6062 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -816,23 +816,6 @@ snd_channel_client_release_recv_buf(RedChannelClie
This make easier the transition to GObject.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index d76481e..59e2e4b 100644
--- a/server/sound.c
+++ b/serve
We support only a single client so don't waste code just
to check this.
The worst stuff can happen is that we'll migrate multiple
connections.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 35 +--
1 file changed, 5 insertions(+), 30 deletions(-)
diff --git
These objects were used by the sound channel as
this channel read/write to/from client directly.
This make the code of this channel quite different
from the other ones.
Also this reduce code duplication from RedChannelClient
and increase encapsulation.
Also there are multiple cleanup following this
Reduce GObject changes as we'll have to load anyway.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 777cdbc..1f50767 100644
--- a/server/sound.c
+++ b/serv
Signed-off-by: Frediano Ziglio
---
server/sound.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 04e08a2..91a0d49 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -93,8 +93,8 @@ GType snd_channel_client_get_type(void) G_
Signed-off-by: Frediano Ziglio
---
server/sound.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index d3b4bbd..2a4472c 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -1433,10 +1433,26 @@ snd_channel_init(SndChannel *s
Signed-off-by: Frediano Ziglio
---
server/sound.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 91a0d49..f7c8120 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -386,7 +386,6 @@ static int snd_playback_send_migrate(PlaybackChan
This patch is quite huge but have some benefits:
- reduce dependency (DummyChannel* and some RedChannelClient internals);
- reuse RedChannelClient instead of reading from the RedsStream
directly.
You can see that SndChannelClient has much less field
as the code to read/write from/to client is re
Almost identical beside the type.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 53 +++
1 file changed, 16 insertions(+), 37 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index fed6062..a4313c4 100644
--- a/server/sound.c
+++ b/s
Signed-off-by: Frediano Ziglio
---
server/Makefile.am| 4 +-
server/dummy-channel-client.c | 138 +---
server/dummy-channel-client.h | 64 +
server/dummy-channel.c| 94 +
server/dummy-channel.h
Signed-off-by: Frediano Ziglio
---
server/sound.c | 51 +--
1 file changed, 21 insertions(+), 30 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 191e4fe..ed20125 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -824,12 +824,11 @@
>
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/server/sound.c b/server/sound.c
> index 04e08a2..91a0d49 100644
> --- a/server/sound.c
> +++ b/server/sound.c
> @@ -93,8 +93,8 @@ GType snd_channel_c
Use new structures and functions to implement statistic code.
Instead of using macro use inline functions.
Inline functions are more type safe.
If statistics are disabled structure and functions became empty;
this allow the code to work and compile with either statistic
disabled or enabled not requ
Allows to see compressed/uncompressed ratio
Signed-off-by: Frediano Ziglio
---
server/spicevmc.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/server/spicevmc.c b/server/spicevmc.c
index 039a50a..8313db6 100644
--- a/server/spicevmc.c
+++ b/server/spicevmc.c
@@ -114,6 +1
> On Thu, 2016-11-24 at 08:57 -0500, Frediano Ziglio wrote:
> > >
> > >
> > > On Thu, Nov 24, 2016 at 10:48:24AM +, Frediano Ziglio wrote:
> > > >
> > > > Signed-off-by: Frediano Ziglio
> > > > ---
> > > > server/red-channel-client.h | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > > >
On Fri, 2016-12-02 at 03:35 -0500, Frediano Ziglio wrote:
> >
> >
> > On Thu, 2016-12-01 at 11:09 +, Frediano Ziglio wrote:
> > >
> > > Allows to destroy a QXL object
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > server/red-qxl.c| 25 ++---
> > > serve
>
> On Fri, 2016-12-02 at 03:35 -0500, Frediano Ziglio wrote:
> > >
> > >
> > > On Thu, 2016-12-01 at 11:09 +, Frediano Ziglio wrote:
> > > >
> > > > Allows to destroy a QXL object
> > > >
> > > > Signed-off-by: Frediano Ziglio
> > > > ---
> > > > server/red-qxl.c| 25 +++
On Fri, 2016-12-02 at 10:51 -0500, Frediano Ziglio wrote:
> >
> >
> > On Fri, 2016-12-02 at 03:35 -0500, Frediano Ziglio wrote:
> > >
> > > >
> > > >
> > > >
> > > > On Thu, 2016-12-01 at 11:09 +, Frediano Ziglio wrote:
> > > > >
> > > > >
> > > > > Allows to destroy a QXL object
> > >
On Fri, 2016-12-02 at 10:18 -0500, Frediano Ziglio wrote:
> >
> > On Thu, 2016-11-24 at 08:57 -0500, Frediano Ziglio wrote:
> > >
> > > >
> > > >
> > > >
> > > > On Thu, Nov 24, 2016 at 10:48:24AM +, Frediano Ziglio
> > > > wrote:
> > > > >
> > > > >
> > > > > Signed-off-by: Frediano
From: Victor Toso
By making video-codecs readeable, we can avoid other objects to access
the internals of DisplayChannel.
The GArray video-codecs is copied as static, no need to unref it
afterwards.
Signed-off-by: Victor Toso
---
server/display-channel.c | 5 -
server/stream.c |
From: Victor Toso
display_channel_set_video_codecs() already exists.
Signed-off-by: Victor Toso
---
server/display-channel.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 52f0a3d..2d475d1 100644
--- a/server/di
>
> On Fri, 2016-12-02 at 10:18 -0500, Frediano Ziglio wrote:
> > >
> > > On Thu, 2016-11-24 at 08:57 -0500, Frediano Ziglio wrote:
> > > >
> > > > >
> > > > >
> > > > >
> > > > > On Thu, Nov 24, 2016 at 10:48:24AM +, Frediano Ziglio
> > > > > wrote:
> > > > > >
> > > > > >
> > > > >
As data is packae in a single piece of memory send it
altogether.
Signed-off-by: Frediano Ziglio
---
server/smartcard-channel-client.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/server/smartcard-channel-client.c
b/server/smartcard-channel-client.c
index 35327dc..95b
>
> As data is packae in a single piece of memory send it
> altogether.
>
typo: packaged
> Signed-off-by: Frediano Ziglio
> ---
> server/smartcard-channel-client.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/server/smartcard-channel-client.c
> b/server/smar
> From: Victor Toso
>
> display_channel_set_video_codecs() already exists.
>
> Signed-off-by: Victor Toso
> ---
> server/display-channel.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/server/display-channel.c b/server/display-channel.c
> index 52f0a3d..2d475d1
On Thu, 2016-12-01 at 11:09 +, Frediano Ziglio wrote:
> Try to arrange destruction in the opposite order of the creation
This patch does more than just re-arrange the order. It also fixes a
bug display_channel_finalize() and frees some things in
spice_server_destroy() that were not freed at al
>
> From: Victor Toso
>
> By making video-codecs readeable, we can avoid other objects to access
> the internals of DisplayChannel.
>
> The GArray video-codecs is copied as static, no need to unref it
> afterwards.
>
> Signed-off-by: Victor Toso
> ---
> server/display-channel.c | 5 -
>
Hi,
On Fri, Dec 02, 2016 at 12:12:02PM -0500, Frediano Ziglio wrote:
> > From: Victor Toso
> >
> > display_channel_set_video_codecs() already exists.
> >
> > Signed-off-by: Victor Toso
> > ---
> > server/display-channel.c | 5 +
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> >
>
> Hi,
>
> On Fri, Dec 02, 2016 at 12:12:02PM -0500, Frediano Ziglio wrote:
> > > From: Victor Toso
> > >
> > > display_channel_set_video_codecs() already exists.
> > >
> > > Signed-off-by: Victor Toso
> > > ---
> > > server/display-channel.c | 5 +
> > > 1 file changed, 1 insertion(+),
Hi,
On Fri, Dec 02, 2016 at 12:17:00PM -0500, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > By making video-codecs readeable, we can avoid other objects to access
> > the internals of DisplayChannel.
> >
> > The GArray video-codecs is copied as static, no need to unref it
> > afterw
Make finalization of DisplayChannel consistent with other code.
Signed-off-by: Frediano Ziglio
---
server/display-channel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/display-channel.c b/server/display-channel.c
index 52f0a3d..cd1334d 100644
--- a/server/displ
Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
---
server/tests/replay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index f32fa2f..23d4125 100644
--- a/server/tests/replay.c
+++ b/server/tests/replay.c
@@ -221,7 +221,6
There could be still some data pending.
Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
---
server/tests/replay.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index 23d4125..8ec65d6 100644
--- a/serve
These patches start destroying objects upon destruction.
Lot of the objects are just allocated but never freed.
This however make hardier to understand automatically leaks
as objects are still linked together.
Currently spice_server_destroy is not called so objects
are freed only when program ends
Signed-off-by: Frediano Ziglio
---
server/reds.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index 17e5ada..d350331 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3592,6 +3592,8 @@ SPICE_GNUC_VISIBLE void spice_server_destroy(SpiceServer
*reds)
Signed-off-by: Frediano Ziglio
Acked-by: Pavel Grunt
---
server/red-replay-qxl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
index 2176068..aeaa545 100644
--- a/server/red-replay-qxl.c
+++ b/server/red-replay-qxl.c
@@ -48,6 +48,7 @@
Allow to dynamically remove QXL interfaces. This could be used to
support hot swapping of QXL cards.
This code is actually not used in any way.
QXL interfaces are destroyed by spice_server_destroy automatically.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 7 +++
1 file changed, 7 inse
Avoid leaking this channel.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 4
1 file changed, 4 insertions(+)
diff --git a/server/reds.c b/server/reds.c
index 479a815..17e5ada 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3592,6 +3592,10 @@ SPICE_GNUC_VISIBLE void spice_server_des
Hi,
On Fri, Dec 02, 2016 at 12:27:45PM -0500, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Fri, Dec 02, 2016 at 12:12:02PM -0500, Frediano Ziglio wrote:
> > > > From: Victor Toso
> > > >
> > > > display_channel_set_video_codecs() already exists.
> > > >
> > > > Signed-off-by: Victor Toso
>
From: Victor Toso
Including g_clear_pointer() in glib-compat.h and using it to avoid
warnings in odd situations.
Signed-off-by: Victor Toso
---
server/display-channel.c | 8 +++-
server/glib-compat.h | 19 +++
2 files changed, 22 insertions(+), 5 deletions(-)
diff --g
>
> Hi,
>
> On Fri, Dec 02, 2016 at 12:17:00PM -0500, Frediano Ziglio wrote:
> > >
> > > From: Victor Toso
> > >
> > > By making video-codecs readeable, we can avoid other objects to access
> > > the internals of DisplayChannel.
> > >
> > > The GArray video-codecs is copied as static, no need
On Fri, 2016-12-02 at 11:17 -0500, Frediano Ziglio wrote:
> >
> >
> > On Fri, 2016-12-02 at 10:18 -0500, Frediano Ziglio wrote:
> > >
> > > >
> > > >
> > > > On Thu, 2016-11-24 at 08:57 -0500, Frediano Ziglio wrote:
> > > > >
> > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
>
Make sure we don't tamper with RedChannelClient internals.
Signed-off-by: Frediano Ziglio
---
server/dcc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index cf5f44c..afe37b1 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -22,7 +22,6 @@
#inc
On Thu, 2016-12-01 at 11:09 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/server/reds.c b/server/reds.c
> index 17e5ada..d350331 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -3592,6
Oops, I just reviewed this patch from a previous series. See my
comments there.
On Fri, 2016-12-02 at 17:43 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/server/reds.c b/server/reds.c
> index
Looks fine to me.
Acked-by: Jonathon Jongsma
On Fri, 2016-12-02 at 17:43 +, Frediano Ziglio wrote:
> Allow to dynamically remove QXL interfaces. This could be used to
> support hot swapping of QXL cards.
> This code is actually not used in any way.
> QXL interfaces are destroyed by spice_
Acked-by: Jonathon Jongsma
On Fri, 2016-12-02 at 10:53 +, Frediano Ziglio wrote:
> Stops using the dummy channel.
> Data handling still goes through DummyChannelClient which is why
> empty implementation of some required vfuncs is working.
>
> Signed-off-by: Frediano Ziglio
> ---
> server
Acked-by: Jonathon Jongsma
On Fri, 2016-12-02 at 10:53 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/sound.c b/server/sound.c
> index 307d292..5e056b6 100644
> --- a/server/
Signed-off-by: Jeremy White
---
This addresses https://bugs.winehq.org/show_bug.cgi?id=11770 for systems with
xdg-email.
v4: Tweaks suggested by Andre.
v3: Replace use of memset with more precise behavior, use return of
MultiByteToWideChar
instead of strlen, make a helper function visibly atomic
> This addresses https://bugs.winehq.org/show_bug.cgi?id=11770 for systems with
> xdg-email.
*Blush*. I really need to configure repo by repo to targets...
Sorry for the confusion.
Cheers,
Jeremy
___
Spice-devel mailing list
Spice-devel@lists.freede
Took me a little while to wrap my brain around why we need to do this,
but I think I understand it pretty well now. I've tried to
rewrite/expand the commit log below in my own words to ensure I
understand it properly. Feel free to use any of the below for the
commit log if it is helpful. Or if it's
Acked-by: Jonathon Jongsma
On Fri, 2016-12-02 at 10:53 +, Frediano Ziglio wrote:
> This make easier the transition to GObject.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 37 +++--
> 1 file changed, 19 insertions(+), 18 deletions(-)
>
> dif
Acked-by: Jonathon Jongsma
On Fri, 2016-12-02 at 10:53 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 37 ++---
> 1 file changed, 18 insertions(+), 19 deletions(-)
>
> diff --git a/server/sound.c b/server/sound.c
> index
Acked-by: Jonathon Jongsma
On Fri, 2016-12-02 at 19:40 +, Frediano Ziglio wrote:
> Make sure we don't tamper with RedChannelClient internals.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/dcc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/server/dcc.c b/
On Fri, 2016-12-02 at 10:53 +, Frediano Ziglio wrote:
> Reduce GObject changes as we'll have to load anyway.
This sentence is a little opaque. Perhaps:
Reduce GObject changes coming in the next commit since we'll need to
change how we access the marshaller anyway. This will make the
following
67 matches
Mail list logo
