Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

On Tue, Jun 13, 2017 at 03:59:06AM -0400, Frediano Ziglio wrote: > I have strange feelings about this series. > > First you removed most of logging test and change the entirely logging. > This is for me an enough reason for a nack. Usually the test define > the behaviour of the API (in this case

[Spice-devel] [PATCH spice-server 0/2] Fix client mouse for Virgl

This small series was an old contro proposal for a patch from Marc-André Lureau. The resulting behaviour of the 2 patches (this and Marc-André one) is the same. The two versions differs mainly by code responsibility based on some terminology definition. In other words, the 2 versions differs

[Spice-devel] [PATCH spice-server 2/2] red-qxl: Rename primary_active to display_active

To avoid confusion use the more generic "display" instead of "primary". "primary" is used in the code widely to mean the primary surface. In the past (before 3D support) having a primary surface mean both the availability of something to render (that is the device was enabled and ready) and the

Re: [Spice-devel] Ultra Wide resolution

Hi, > >    state='connected'/> >    >    > That is the spice agent channel, good. One pitfall I'm aware of is that (on linux) automatically adapting the virtual display size works only after logging in, not yet on the gdm screen. Not sure whenever that is the case on

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

> On 13 Jun 2017, at 11:41, Christophe Fergeau wrote: > > On Tue, Jun 13, 2017 at 11:26:46AM +0200, Christophe de Dinechin wrote: >>> Let's first see if we manage to add useful debug logs to both the client and the server, then we can look into adding this :) >>

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

On Mon, Jun 12, 2017 at 09:32:38PM +, Marc-André Lureau wrote: > Hi > > On Mon, Jun 12, 2017 at 9:11 PM Christophe de Dinechin > wrote: > > > > > > On 12 Jun 2017, at 10:19, marcandre.lur...@redhat.com wrote: > > > > > > From: Marc-André Lureau

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

On Tue, Jun 13, 2017 at 09:45:20AM +0200, Christophe de Dinechin wrote: > > 5. The spice_log_init deals with hard-coded variables in a > > hard-coded way. I purposely had a function taking a string, and > > called either with env vars or command line options. I was thinking > > long-term about

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

Hi - Original Message - > I have strange feelings about this series. > > First you removed most of logging test and change the entirely logging. > This is for me an enough reason for a nack. Usually the test define > the behaviour of the API (in this case logging) and the fact you have >

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

On Tue, Jun 13, 2017 at 11:26:46AM +0200, Christophe de Dinechin wrote: > > > >> Let's first see if we manage to add useful debug logs to both the client > >> and the server, then we can look into adding this :) > > I agree. I was explaining why I had made a choice to have a dedicated >

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

Hi - Original Message - > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL. > This change broke client-side mouse mode, because Spice server relies on > primary surface conditions. > > When GL is enabled, use GL scanout informations. > Mouse mode is always client

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

> On 13 Jun 2017, at 10:42, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> On Tue, Jun 13, 2017 at 09:45:20AM +0200, Christophe de Dinechin wrote: 5. The spice_log_init deals with hard-coded variables in a hard-coded way. I

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

Hi - Original Message - > > > > Hi > > > > - Original Message - > > > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL. > > > This change broke client-side mouse mode, because Spice server relies on > > > primary surface conditions. > > > > > > When GL is

[Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

Since 2.8, QEMU now longer creates QXL primary surfaces when using GL. This change broke client-side mouse mode, because Spice server relies on primary surface conditions. When GL is enabled, use GL scanout informations. Mouse mode is always client when GL surfaces are used. This patch and most

Re: [Spice-devel] [PATCH qxl-wddm-dod v2] ci: Integrate with Appveyor

I’m sending the next version with updated commit message. See more answers below… > On 8 Jun 2017, at 15:00 PM, Dmitry Fleytman wrote: > > Hi Frediano, thanks for review. > See below. > > >> On 8 Jun 2017, at 13:42 PM, Frediano Ziglio >

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

> > Hi > > - Original Message - > > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL. > > This change broke client-side mouse mode, because Spice server relies on > > primary surface conditions. > > > > When GL is enabled, use GL scanout informations. > > Mouse mode

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

> On 13 Jun 2017, at 09:59, Frediano Ziglio wrote: > > I have strange feelings about this series. > > First you removed most of logging test and change the entirely logging. > This is for me an enough reason for a nack. Usually the test define > the behaviour of the API (in

Re: [Spice-devel] Ultra Wide resolution

On 06/13/2017 12:04 AM, guidu...@gmail.com wrote: Hi Uri, I use virt-manager (1.4.1-2) to install and run virtual machines. QEMU version is 2.7.1-6 (latest fedora 25 stable). Below you can see the definition of the Win 7 VM I built just to perform the tests with resolution. I did not added

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

Hi, On Tue, Jun 13, 2017 at 04:42:27AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Tue, Jun 13, 2017 at 09:45:20AM +0200, Christophe de Dinechin wrote: > > > > 5. The spice_log_init deals with hard-coded variables in a > > > > hard-coded way. I purposely had a

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

I have strange feelings about this series. First you removed most of logging test and change the entirely logging. This is for me an enough reason for a nack. Usually the test define the behaviour of the API (in this case logging) and the fact you have to change a lot means that the new one is

Re: [Spice-devel] [PATCH spice-common 0/4] RFC: add structured logging and log category

Hi - Original Message - > Global declarations pros: > - Obeys the DRY principle, as opposed to WET category declarations > (e.g. SPICE_LOG_CATEGORY_DECLARE vs. SPICE_LOG_CATEGORY) True, but SPICE_LOG_CATEGORY_DECLARE should not be needed, I'd rather remove it. > - Makes it possible to

[Spice-devel] [PATCH qxl-wddm-dod v3] ci: Integrate with Appveyor

This patch introduces Appveyor CI configuration file. Having this patch pushed and qxl-wddm-dod repository registered at Appveyor, every push or merge request will be automatically built on their servers. Signed-off-by: Dmitry Fleytman --- .appveyor.yml | 18

[Spice-devel] [PATCH qxl-wddm-dod v3] Introduce Appveyor CI integration

Changes since previous version: 1. Commit message extended. Dmitry Fleytman (1): ci: Integrate with Appveyor .appveyor.yml | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 .appveyor.yml -- 2.7.0.windows.1 ___

Re: [Spice-devel] [PATCH spice-server 1/2] gl: fix client mouse mode

> > Hi > > - Original Message - > > > > > > Hi > > > > > > - Original Message - > > > > Since 2.8, QEMU now longer creates QXL primary surfaces when using GL. > > > > This change broke client-side mouse mode, because Spice server relies > > > > on > > > > primary surface

Re: [Spice-devel] [PATCH qxl-wddm-dod v3] ci: Integrate with Appveyor

> > This patch introduces Appveyor CI configuration file. > > Having this patch pushed and qxl-wddm-dod repository > registered at Appveyor, every push or merge request will > be automatically built on their servers. > > Signed-off-by: Dmitry Fleytman Acked-by: Frediano

[Spice-devel] [PATCH spice-common 1/2] log: remove deprecated SPICE_ABORT_LEVEL support

This feature was marked obsolete by efd1d3cb4d8eee more than an year ago. Signed-off-by: Frediano Ziglio --- common/log.c | 27 ++- tests/test-logging.c | 39 +-- 2 files changed, 3 insertions(+), 63

[Spice-devel] [PATCH spice-common 2/2] log: remove deprecated SPICE_DEBUG_LEVEL support

This feature was marked obsolete by efd1d3cb4d8eee more than an year ago. Signed-off-by: Frediano Ziglio --- common/log.c | 82 tests/test-logging.c | 58 - 2 files changed, 140

Re: [Spice-devel] [PATCH spice-common 3/4] RFC: Add spice log categories

Hi - Original Message - > > If you set G_LOG_USE_STRUCTURED, glib will use structured log API. But > > there is a single structured log handler (contrary to traditional glog > > that can have per-domain). > > Hm, I have yet to play with the API to say for sure but I thought we > could

Re: [Spice-devel] [PATCH spice-common 3/4] RFC: Add spice log categories

Hi, On Tue, Jun 13, 2017 at 05:35:05AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > This code assumes that there is only a single G_LOG_DOMAIN used within > > a particular project, but it's not stated explicity (as far as I can > > tell) > > Kind of, you mean for the

Re: [Spice-devel] [PATCH spice-common 0/2] Remove obsolete environment usage

Hi, On Tue, Jun 13, 2017 at 03:47:52PM +0100, Frediano Ziglio wrote: > Following log discussion and Victor suggestion about removing > these variable as already enough obsolete and documented > proposed a patch to remove them. > Mainly to get some consent and votes. +1, it would remove good

[Spice-devel] [PATCH spice-common 0/2] Remove obsolete environment usage

Following log discussion and Victor suggestion about removing these variable as already enough obsolete and documented proposed a patch to remove them. Mainly to get some consent and votes. Frediano Ziglio (2): log: remove deprecated SPICE_ABORT_LEVEL support log: remove deprecated

Re: [Spice-devel] [PATCH spice-common 3/4] RFC: Add spice log categories

Hi - Original Message - > > > > A category can be enabled with SPICE_DEBUG="cat_name foo*" (*? are > > > > accepted glob-like wildcards). All categories are enabled with > > > > SPICE_DEBUG=1 or 'all'. To list available categories, you can run the > > > > program with SPICE_DEBUG=help. >

Re: [Spice-devel] [PATCH spice-common 1/4] log: replace spice log with glib

Hi, On Mon, Jun 12, 2017 at 05:27:57PM +0200, Christophe Fergeau wrote: > On Mon, Jun 12, 2017 at 12:19:51PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Remove all the deprecated spice log macro/environment variables > > Note that

Re: [Spice-devel] [PATCH spice-common 3/4] RFC: Add spice log categories

Hi, On Tue, Jun 13, 2017 at 09:49:25AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > > > > A category can be enabled with SPICE_DEBUG="cat_name foo*" (*? are > > > > > accepted glob-like wildcards). All categories are enabled with > > > > > SPICE_DEBUG=1 or 'all'. To

Re: [Spice-devel] [PATCH spice-gtk v3] Remove unnecessary debug check from SPICE_DEBUG

On Fri, 2017-06-09 at 14:29 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi > > > > - Original Message - > > > > If I was reading the code of a project and noticed that they > > > > checked a > > > > global variable every time before calling g_debug(), I

Re: [Spice-devel] [PATCH spice-common 3/4] RFC: Add spice log categories

On Tue, 2017-06-13 at 05:35 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > This code assumes that there is only a single G_LOG_DOMAIN used > > within > > a particular project, but it's not stated explicity (as far as I > > can > > tell) > > Kind of, you mean for the

Re: [Spice-devel] [spice-server] Remove use of spice_debug(NULL)

On Tue, Jun 13, 2017 at 07:08:34PM +0200, Christophe Fergeau wrote: > This is causing issues with potential improvements to the logging > system, and I've always found this usage a bit odd anyway. > This means we also need to remove -Wformat-zero-length from our CFLAGS > to avoid warnings from the

[Spice-devel] [spice-server] Remove use of spice_debug(NULL)

This is causing issues with potential improvements to the logging system, and I've always found this usage a bit odd anyway. This means we also need to remove -Wformat-zero-length from our CFLAGS to avoid warnings from the compiler. Signed-off-by: Christophe Fergeau ---

Re: [Spice-devel] Ultra Wide resolution

Hi Uri, I use virt-manager (1.4.1-2) to install and run virtual machines. QEMU version is 2.7.1-6 (latest fedora 25 stable). Below you can see the definition of the Win 7 VM I built just to perform the tests with resolution. I did not added anything other than the default. The "QEMU Guest

Re: [Spice-devel] [PATCH spice-common 0/2] Remove obsolete environment usage

On Tue, 2017-06-13 at 16:53 +0200, Victor Toso wrote: > Hi, > > On Tue, Jun 13, 2017 at 03:47:52PM +0100, Frediano Ziglio wrote: > > Following log discussion and Victor suggestion about removing > > these variable as already enough obsolete and documented > > proposed a patch to remove them. > >