[Spice-devel] Windows 10 and current latest spice guest additions causes blank/black screen issue

Hi guys! Installing current latest spice guest additions from here on Windows 10: https://www.spice-space.org/download/windows/spice-guest-tools/spice-guest-tools-latest.exe (I guess v0.132) causes a fresh Windows 10 installation in oVirt to die with a blank, black screen the moment the client

Re: [Spice-devel] [PATCH spice-server 1/2] red-qxl: Remove AsyncCommand

On Mon, Sep 18, 2017 at 11:17:16AM -0400, Frediano Ziglio wrote: > > > > On Mon, Sep 18, 2017 at 06:19:03AM -0400, Frediano Ziglio wrote: > > > > > > > > On Mon, Sep 11, 2017 at 09:08:54AM +0100, Frediano Ziglio wrote: > > > > > This structure was used to store the cookie for the async > > > > >

[Spice-devel] [PATCH spice-server v2 5/11] reds: Use GLib memory functions for link

Signed-off-by: Frediano Ziglio --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Changes since v1: - rebases on master, one free was removed. diff --git a/server/reds.c b/server/reds.c index 8b081bbe2..683af96ff 100644 --- a/server/reds.c +++

[Spice-devel] [PATCH spice-server] fixup! Start using GLib memory allocation

Capabilities are allocated even in reds.c. Signed-off-by: Frediano Ziglio --- server/reds.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/server/reds.c index dcdc29d63..13842fb1a 100644 --- a/server/reds.c +++ b/server/reds.c @@

Re: [Spice-devel] [PATCH spice-common v2] codegen: Make the compiler work out better way to write unaligned memory

On Mon, Sep 18, 2017 at 10:27:01AM -0400, Frediano Ziglio wrote: > > > > Has this been tested on actual problematic hardware, and improved > > performance? I remember last time this was discussed, the outcome was > > not always what was expected. > > > > Christophe > > > > I don't remember old

Re: [Spice-devel] [PATCH spice-gtk 4/5] InputsChannel: Fix introspection method bindings

- Original Message - > Signed-off-by: Matthew Francis Reviewed-by: Marc-André Lureau > --- > doc/reference/spice-gtk-sections.txt | 8 ++ > src/channel-inputs.c | 146 > ++- >

Re: [Spice-devel] [PATCH spice-gtk 5/5] MainChannel: Fix introspection method bindings

On Tue, Sep 19, 2017 at 7:52 AM Matthew Francis wrote: > Signed-off-by: Matthew Francis > --- > doc/reference/spice-gtk-sections.txt | 11 ++ > src/channel-main.c | 283 > +++ >

Re: [Spice-devel] [PATCH spice-gtk 2/5] DisplayChannel: Fix introspection method bindings

- Original Message - > Signed-off-by: Matthew Francis Reviewed-by: Marc-André Lureau > --- > doc/reference/spice-gtk-sections.txt | 5 ++ > src/channel-display.c| 92 > +++- >

Re: [Spice-devel] [PATCH spice-gtk 3/5] RecordChannel: Fix introspection method bindings

Hi - Original Message - > Signed-off-by: Matthew Francis > --- > doc/reference/spice-gtk-sections.txt | 1 + > src/channel-record.c | 19 +++ > src/channel-record.h | 6 ++ > src/map-file

Re: [Spice-devel] [PATCH spice-gtk 1/5] PortChannel: Fix introspection method bindings

- Original Message - > Signed-off-by: Matthew Francis Reviewed-by: Marc-André Lureau > --- > doc/reference/spice-gtk-sections.txt | 3 ++ > src/channel-port.c | 67 > +++- >

Re: [Spice-devel] [PATCH spice-server v2 3/4] Introduce a macro to help declaring new GObject

Acked-by: Christophe Fergeau On Mon, Sep 18, 2017 at 04:04:56PM +0100, Frediano Ziglio wrote: > The macro will implement most of the boilerplate needed to declare an > object. > Its usage is similar to GLib G_DECLARE_*_TYPE macros. > > Signed-off-by: Frediano Ziglio

[Spice-devel] [PATCH spice-server] Reuse SPICE_DECLARE_TYPE macro

Signed-off-by: Frediano Ziglio --- server/red-channel-client.h | 17 +--- server/red-channel.h| 19 ++--- server/red-client.h | 13 +- server/reds.c | 12 +- server/smartcard.c | 17 +--- server/smartcard.h |

Re: [Spice-devel] [PATCH spice-server v2 4/4] tests: Add a test to check tight loop during ack waiting

Acked-by: Christophe Fergeau On Mon, Sep 18, 2017 at 04:04:57PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/tests/Makefile.am| 1 + > server/tests/test-channel.c | 347 >

Re: [Spice-devel] [PATCH spice-common v2] codegen: Make the compiler work out better way to write unaligned memory

> > On Mon, Sep 18, 2017 at 10:27:01AM -0400, Frediano Ziglio wrote: > > > > > > Has this been tested on actual problematic hardware, and improved > > > performance? I remember last time this was discussed, the outcome was > > > not always what was expected. > > > > > > Christophe > > > > > >

Re: [Spice-devel] [PATCH spice-server 2/4] red-client: Protect concurrent list accesses

On Wed, Aug 30, 2017 at 01:51:26PM +0100, Frediano Ziglio wrote: > The channels list was not protected by a lock in red_client_destroy. > This could cause for instance a RedChannelClient object to be > created while scanning the list so potentially modifying the > list while scanning with all race

Re: [Spice-devel] [PATCH spice-server v2 2/4] red-channel-client: Prevent too tight loop waiting for ACKs

Acked-by: Christophe Fergeau On Mon, Sep 18, 2017 at 04:04:55PM +0100, Frediano Ziglio wrote: > RedChannelClient has a "handle-acks" feature. > If this feature is enabled, after the configured number of messages it > waits for an ACK from the client. > If is waiting for an

Re: [Spice-devel] [PATCH spice-server] red-channel-client: Do not push items adding them to tail

> > On Wed, Sep 13, 2017 at 10:15:14AM +0100, Frediano Ziglio wrote: > > Now the push is done automatically when a PipeItem is added > > (cfr commit 5c460de1a3972b7cf2b9b2944d0b500c3affc363 > > "worker: push data when clients can receive them"), > > forcing a push cause only network fragmentation

Re: [Spice-devel] [PATCH spice-server] red-channel-client: Do not push items adding them to tail

On Tue, Sep 19, 2017 at 08:33:04AM -0400, Frediano Ziglio wrote: > > > > On Wed, Sep 13, 2017 at 10:15:14AM +0100, Frediano Ziglio wrote: > > > Now the push is done automatically when a PipeItem is added > > > (cfr commit 5c460de1a3972b7cf2b9b2944d0b500c3affc363 > > > "worker: push data when

Re: [Spice-devel] [PATCH spice-server] red-channel-client: Do not push items adding them to tail

> > On Tue, Sep 19, 2017 at 08:33:04AM -0400, Frediano Ziglio wrote: > > > > > > On Wed, Sep 13, 2017 at 10:15:14AM +0100, Frediano Ziglio wrote: > > > > Now the push is done automatically when a PipeItem is added > > > > (cfr commit 5c460de1a3972b7cf2b9b2944d0b500c3affc363 > > > > "worker: push

Re: [Spice-devel] [PATCH spice-gtk 3/5] RecordChannel: Fix introspection method bindings

On 19 September 2017 at 18:33, Marc-André Lureau wrote: > > You need to modify spice-pulse.c too Thank you for the quick review. Obviously I'd failed to compile pulseaudio support into my local version. Updated patches to follow for this and your points on 5/5

Re: [Spice-devel] [PATCH spice-server v2] red-channel-client: Simplify red_channel_client_wait_pipe_item_sent loop

On Tue, Sep 12, 2017 at 02:03:24PM +0100, Frediano Ziglio wrote: With some added spaces, the log is a bit easier to read imo :) "Avoid repeating the same code twice. red_channel_client_send sends the pending item (or a part of it). If there are no item pending, the function does nothing (so

[Spice-devel] [PATCH spice-gtk v2 5/5] MainChannel: Fix introspection method bindings

Signed-off-by: Matthew Francis --- doc/reference/spice-gtk-sections.txt | 11 ++ src/channel-main.c | 283 +++ src/channel-main.h | 99 src/map-file | 11 ++

Re: [Spice-devel] [PATCH spice-server v2 5/11] reds: Use GLib memory functions for link

It's a bit small now. I suppose it could be squashed, or left as is. Acked-by: Jonathon Jongsma On Tue, 2017-09-19 at 07:35 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 4 ++-- > 1 file changed, 2

Re: [Spice-devel] [PATCH spice-server 11/11] lz4-encoder: Use GLib memory functions

Can you explain briefly in the commit log about why you chose to change the types? Acked-by: Jonathon Jongsma On Mon, 2017-09-11 at 16:15 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/lz4-encoder.c | 21

[Spice-devel] [PATCH spice-gtk v2 3/5] RecordChannel: Fix introspection method bindings

Signed-off-by: Matthew Francis --- doc/reference/spice-gtk-sections.txt | 1 + src/channel-record.c | 19 +++ src/channel-record.h | 6 ++ src/map-file | 1 + src/spice-glib-sym-file

[Spice-devel] [PATCH spice-gtk v2 2/5] DisplayChannel: Fix introspection method bindings

Signed-off-by: Matthew Francis --- doc/reference/spice-gtk-sections.txt | 5 ++ src/channel-display.c| 92 +++- src/channel-display.h| 22 +++-- src/map-file | 5 ++

[Spice-devel] [PATCH spice-gtk v2 4/5] InputsChannel: Fix introspection method bindings

Signed-off-by: Matthew Francis --- doc/reference/spice-gtk-sections.txt | 8 ++ src/channel-inputs.c | 146 ++- src/channel-inputs.h | 34 ++-- src/map-file | 8 ++

[Spice-devel] [PATCH spice-gtk v2 0/5] Fix introspection method bindings

Various C functions have not been named correctly to be picked up as bound methods under introspection. This renames them to ensure correct binding. Outline: - Rename incorrectly named functions - Introduce deprecated wrappers for the original function names - Update in-tree references to use