Re: [Spice-devel] [PATCH spice-server v2 10/23] dispatcher: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/dispatcher.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/dispatcher.c

Re: [Spice-devel] [PATCH spice-server v2 17/23] worker: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/cursor-channel.c | 2 +- > server/red-worker.c | 8 > 2 files changed, 5 insertions(+), 5 deletions(-) >

Re: [Spice-devel] [PATCH spice-server v2 18/23] tree: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/tree.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/tree.c b/server/tree.c

Re: [Spice-devel] [PATCH spice-server v2 23/23] red-pipe-item: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/cache-item.tmpl.c | 6 +++--- > server/dcc.c | 10 +- > server/inputs-channel.c

Re: [Spice-devel] [PATCH spice-server v2 19/23] inputs-channel: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
I guess this is one of the patches you mentioned in the cover letter that have leaks? Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/inputs-channel.c | 6 +++--- > 1

Re: [Spice-devel] [PATCH spice-server v2 08/23] char-device: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/char-device.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-server v2 09/23] event-loop: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/event-loop.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/event-loop.c

Re: [Spice-devel] [PATCH spice-server v2 11/23] Use GLib memory functions for SpiceChannelEventInfo

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/reds-stream.c | 2 +- > server/reds.c| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-server v2 12/23] reds: Use GLib memory functions for link message

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/reds.c b/server/reds.c

Re: [Spice-devel] [PATCH spice-server v2 16/23] replay-qxl: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/red-replay-qxl.c | 48 --- > - > 1 file changed, 24 insertions(+), 24

Re: [Spice-devel] [PATCH spice-server v2 13/23] reds: Use GLib memory functions for ChannelSecurityOptions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/reds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/reds.c b/server/reds.c >

Re: [Spice-devel] [PATCH spice-server v2 14/23] dcc: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/dcc.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/server/dcc.c

Re: [Spice-devel] [PATCH spice-server v2 15/23] display-channel: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/display-channel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-server v2 20/23] image-cache: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/image-cache.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/image-cache.c

Re: [Spice-devel] [PATCH spice-server v2 21/23] pixmap-cache: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/dcc.c | 8 > server/pixmap-cache.c | 6 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) >

Re: [Spice-devel] [spice-server] build: Prepare for 0.13.91 release

2017-09-22 Thread Frediano Ziglio
> > --- > NEWS | 15 +++ > configure.ac | 2 +- > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index 784747e3f..3f715d2f6 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,18 @@ > +Major Changes in 0.13.91: > += > + >

[Spice-devel] [PATCH spice-common v2 2/3] test-marshallers: Use unaligned structure

2017-09-22 Thread Frediano Ziglio
Allows to test for bad performance on some systems. For instance on ARMv6/ARMv7 which does not support by default 64 bit unaligned read/write this can be checked on Linux using /proc/cpu/alignment file. Signed-off-by: Frediano Ziglio --- tests/test-marshallers.c | 10

[Spice-devel] [PATCH spice-common v2 3/3] test-marshallers: Test demarshalling

2017-09-22 Thread Frediano Ziglio
Generate demarshallers code and check it too. Signed-off-by: Frediano Ziglio --- tests/Makefile.am| 4 tests/test-marshallers.c | 29 ++--- tests/test-marshallers.h | 2 +- 3 files changed, 31 insertions(+), 4 deletions(-) diff --git

Re: [Spice-devel] [spice-server v2] tests: Automatically determine free port to use

2017-09-22 Thread Frediano Ziglio
> > On Thu, Sep 21, 2017 at 11:11:03AM -0400, Frediano Ziglio wrote: > > > > > > Currently, the port used by most tests is hardcoded to 5912. However, > > > the test suite can be run in parallel, so if 2 tests run in parallel, > > > the 2nd one is not going to be able to bind to port 5912 and

Re: [Spice-devel] [PATCH spice-server v2 03/23] reds-stream: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:50 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/reds-stream.c | 37 ++--- > 1 file changed, 14 insertions(+), 23 deletions(-) > > diff

Re: [Spice-devel] [PATCH spice-server v2 02/23] mjpeg: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
On Wed, 2017-09-20 at 08:50 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/mjpeg-encoder.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c >

Re: [Spice-devel] [PATCH spice-server v2 04/23] smartcard: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:50 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/smartcard.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/server/smartcard.c

Re: [Spice-devel] [PATCH spice-server v2 05/23] stream: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
On Wed, 2017-09-20 at 08:50 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/dcc.c| 2 +- > server/stream.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/server/dcc.c b/server/dcc.c > index

Re: [Spice-devel] [PATCH spice-server v2 06/23] spicevmc: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
On Wed, 2017-09-20 at 08:50 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/spicevmc.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/server/spicevmc.c b/server/spicevmc.c > index 6b9b96fc8..7577165f5

Re: [Spice-devel] [PATCH spice-server v2 07/23] gstreamer-encoder: Use GLib memory functions

2017-09-22 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Wed, 2017-09-20 at 08:51 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/gstreamer-encoder.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git