Re: [Spice-devel] [PATCH spice-server v3 06/23] spicevmc: Use GLib memory functions

Acked-by: Jonathon Jongsma On Mon, 2017-09-25 at 09:25 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/spicevmc.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > Changes since v2: > - move

Re: [Spice-devel] [PATCH spice-common v2 1/3] Make the compiler work out better way to write unaligned memory

On Mon, Sep 25, 2017 at 09:04:16AM -0400, Frediano Ziglio wrote: > Yes, intentional and consistent with previous code. > The usage of unsigned for BYTESWAP avoid sign extension during arithmetic. If BYTESWAP has such issues (and I don't think it does), then this should be fixed. ack on being

Re: [Spice-devel] [PATCH spice-common v2 1/3] Make the compiler work out better way to write unaligned memory

> > On Mon, Sep 25, 2017 at 09:04:16AM -0400, Frediano Ziglio wrote: > > Yes, intentional and consistent with previous code. > > The usage of unsigned for BYTESWAP avoid sign extension during arithmetic. > > If BYTESWAP has such issues (and I don't think it does), then this should be > fixed. >

Re: [Spice-devel] [PATCH spice-common v2 1/3] Make the compiler work out better way to write unaligned memory

On Mon, Sep 25, 2017 at 10:22:57AM -0400, Frediano Ziglio wrote: > > > > On Mon, Sep 25, 2017 at 09:04:16AM -0400, Frediano Ziglio wrote: > > > Yes, intentional and consistent with previous code. > > > The usage of unsigned for BYTESWAP avoid sign extension during arithmetic. > > > > If BYTESWAP

Re: [Spice-devel] [PATCH spice-common v2 1/3] Make the compiler work out better way to write unaligned memory

> > On Fri, Sep 22, 2017 at 11:10:02AM +0100, Frediano Ziglio wrote: > > Instead of assuming that the system can safely do unaligned access > > to memory use packed structures to allow the compiler generate > > best code possible. > > A packed structure tells the compiler to not leave padding

Re: [Spice-devel] [PATCH spice-common v2 1/3] Make the compiler work out better way to write unaligned memory

On Fri, Sep 22, 2017 at 11:10:02AM +0100, Frediano Ziglio wrote: > Instead of assuming that the system can safely do unaligned access > to memory use packed structures to allow the compiler generate > best code possible. > A packed structure tells the compiler to not leave padding inside it > and

Re: [Spice-devel] [PATCH spice-server v2 02/23] mjpeg: Use GLib memory functions

> > On Wed, 2017-09-20 at 08:50 +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > > server/mjpeg-encoder.c | 28 ++-- > > 1 file changed, 14 insertions(+), 14 deletions(-) > > > > diff --git a/server/mjpeg-encoder.c

[Spice-devel] [PATCH spice-server v3 06/23] spicevmc: Use GLib memory functions

Signed-off-by: Frediano Ziglio --- server/spicevmc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Changes since v2: - move RedPipeItem stuff in proper patch. diff --git a/server/spicevmc.c b/server/spicevmc.c index 6b9b96fc8..f56f50eda 100644 ---

Re: [Spice-devel] [PATCH spice-server v2 02/23] mjpeg: Use GLib memory functions

On Mon, 2017-09-25 at 03:56 -0400, Frediano Ziglio wrote: > > > > On Wed, 2017-09-20 at 08:50 +0100, Frediano Ziglio wrote: > > > Signed-off-by: Frediano Ziglio > > > --- > > > server/mjpeg-encoder.c | 28 ++-- > > > 1 file changed, 14 insertions(+),

Re: [Spice-devel] [PATCH spice-common v2 1/3] Make the compiler work out better way to write unaligned memory

On Mon, Sep 25, 2017 at 04:37:43PM +0200, Christophe Fergeau wrote: > On Mon, Sep 25, 2017 at 10:22:57AM -0400, Frediano Ziglio wrote: > > > > > > On Mon, Sep 25, 2017 at 09:04:16AM -0400, Frediano Ziglio wrote: > > > > Yes, intentional and consistent with previous code. > > > > The usage of

Re: [Spice-devel] [PATCH spice-server v3 23/23] red-pipe-item: Use GLib memory functions

Acked-by: Jonathon Jongsma On Mon, 2017-09-25 at 13:20 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > Acked-by: Jonathon Jongsma > --- > server/cache-item.tmpl.c | 6 +++--- > server/dcc.c

[Spice-devel] [PATCH spice-server v3 23/23] red-pipe-item: Use GLib memory functions

Signed-off-by: Frediano Ziglio Acked-by: Jonathon Jongsma --- server/cache-item.tmpl.c | 6 +++--- server/dcc.c | 10 +- server/inputs-channel.c | 4 ++-- server/main-channel-client.c | 14