Re: [Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

2017-11-14 Thread Christophe de Dinechin
> On 14 Nov 2017, at 16:57, Frediano Ziglio wrote: > > > On 14 Nov 2017, at 16:22, Frediano Ziglio > wrote: > > > From: Christophe de Dinechin > > > Signed-off-by:

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove plugin settings usage

2017-11-14 Thread Christophe de Dinechin
Frediano Ziglio writes: > Not really maintainable to add all plugins options here. > We should came up with a way to print settings dynamically. > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-streaming-agent 2/3] Rework option handling

2017-11-14 Thread Christophe de Dinechin
> On 14 Nov 2017, at 16:41, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin > > >> >> Several functional objectives: >> >> 1. Be able to share some common options, e.g. fps >> 2. Prepare for the possibility

Re: [Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

2017-11-14 Thread Frediano Ziglio
> > On 14 Nov 2017, at 16:22, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > Signed-off-by: Christophe de Dinechin < dinec...@redhat.com > > > > > > > --- > > > > > > include/spice-streaming-agent/plugin.hpp | 2 +- >

Re: [Spice-devel] [PATCH] usbredirserver: use more popular name instead of usbbus-usbaddr

2017-11-14 Thread Victor Toso
On Fri, Nov 10, 2017 at 06:09:50PM +0800, Chen Hanxiao wrote: > From: Chen Hanxiao > > Usually we use busnum:devnum for a usb device. > Tools such as lsusb, udev did that. > Our original naming is a little confued. s/confued/confusing And pushed as

Re: [Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

2017-11-14 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > include/spice-streaming-agent/plugin.hpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/spice-streaming-agent/plugin.hpp >

[Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

2017-11-14 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- include/spice-streaming-agent/plugin.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/spice-streaming-agent/plugin.hpp

[Spice-devel] [PATCH spice-streaming-agent 3/3] Externalize plugins usage

2017-11-14 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- include/spice-streaming-agent/plugin.hpp | 6 ++ src/concrete-agent.cpp | 11 +++ src/concrete-agent.hpp | 1 +

[Spice-devel] [PATCH spice-streaming-agent 2/3] Rework option handling

2017-11-14 Thread Christophe de Dinechin
From: Christophe de Dinechin Several functional objectives: 1. Be able to share some common options, e.g. fps 2. Prepare for the possibility to update options on the fly Also get rid of the null-terminated C++ vector Signed-off-by: Christophe de Dinechin

[Spice-devel] [PATCH spice-streaming-agent 0/3] Rework option handling

2017-11-14 Thread Christophe de Dinechin
From: Christophe de Dinechin Several objectives: 1) Make it easier for each plugin to deal with its own settings and options 2) Give proper usage information with information from each plugin 3) Enable dynamic application of settings, e.g. for debugging purpose 4) Prepare

Re: [Spice-devel] [PATCH spice-streaming-agent 2/3] Rework option handling

2017-11-14 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Several functional objectives: > > 1. Be able to share some common options, e.g. fps > 2. Prepare for the possibility to update options on the fly > > Also get rid of the null-terminated C++ vector > > Signed-off-by: Christophe de

Re: [Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

2017-11-14 Thread Christophe de Dinechin
> On 14 Nov 2017, at 16:22, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> include/spice-streaming-agent/plugin.hpp | 2 +- >> 1 file changed, 1 insertion(+), 1