Re: [Spice-devel] [spice-server] sound: do not change volume or mute state on migration

> > Hi, > > On Thu, Nov 16, 2017 at 10:58:03AM -0500, Frediano Ziglio wrote: > > > > > > From: Victor Toso > > > > > > On migration, we are resending the current volume and mute state in > > > the Guest. > > > > Maybe is just me but this sentence is confusing. By "we" I

Re: [Spice-devel] [PATCH spice-streaming-agent v2 2/2] Rework option handling

> > From: Christophe de Dinechin > > The overall objective is to pave the way for features that will likely > become important, notably the ability to dynamically adjust quality of > service to respond to network conditions or client load issues. > > Consequently, this

Re: [Spice-devel] [PATCH spice-streaming-agent 2/3] Rework option handling

Sorry for cutting out a lot of context, but this email appeared as HTML in my inbox. > On 16 Nov 2017, at 14:34, Frediano Ziglio wrote: > > Let me clarify one point. I agree the options interface lacks some feature. > Changing > them dynamically will be necessary. > On

[Spice-devel] [spice-server] sound: do not change volume or mute state on migration

From: Victor Toso On migration, we are resending the current volume and mute state in the Guest. If the client user has change its master volume in the guest it might change the client application volume too and the volume jump (increase or decrease) might happen on

Re: [Spice-devel] [spice-server] sound: do not change volume or mute state on migration

> > From: Victor Toso > > On migration, we are resending the current volume and mute state in > the Guest. Maybe is just me but this sentence is confusing. By "we" I think you mean spice-server but the confusion came from the fact that is Qemu that on the new machine try

Re: [Spice-devel] [spice-server] sound: do not change volume or mute state on migration

Hi, On Thu, Nov 16, 2017 at 10:58:03AM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > On migration, we are resending the current volume and mute state in > > the Guest. > > Maybe is just me but this sentence is confusing. By "we" I think you > mean

Re: [Spice-devel] [PATCH spice-common] codegen: Define identity macros for enum types

Hey, Some concrete examples of what you are going to do with it would be useful ;) Christophe On Mon, Nov 13, 2017 at 01:16:32PM +, Frediano Ziglio wrote: > An identity macro in C is a macro defined as > > #define SOME_NAME SOME_NAME > > They are often used to make possible to use

[Spice-devel] [PATCH spice-server v2] stream-channel: Tell client we are just streaming data

This give an hint to client which can optimise rendering. Signed-off-by: Frediano Ziglio --- server/stream-channel.c | 7 +++ 1 file changed, 7 insertions(+) Changes since v1: - add a comment for capability check explanation diff --git a/server/stream-channel.c

Re: [Spice-devel] [PATCH spice-common] codegen: Define identity macros for enum types

> > Hey, > > Some concrete examples of what you are going to do with it would be > useful ;) > > Christophe > > On Mon, Nov 13, 2017 at 01:16:32PM +, Frediano Ziglio wrote: > > An identity macro in C is a macro defined as > > > > #define SOME_NAME SOME_NAME > > > > They are often used

[Spice-devel] [PATCH spice-server] tests: Add a test for streaming devices

Currently create device, open it and pass some messages checking they are handled. Signed-off-by: Frediano Ziglio --- server/tests/Makefile.am | 1 + server/tests/test-stream-device.c | 151 ++ 2 files changed, 152 insertions(+)

Re: [Spice-devel] [PATCH spice-server] stream-channel: Tell client we are just streaming data

> > On Mon, Nov 13, 2017 at 03:47:43PM +, Frediano Ziglio wrote: > > This give an hint to client which can optimise rendering. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/stream-channel.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git

[Spice-devel] [PATCH spice-common v2] codegen: Define identity macros for enum types

An identity macro in C is a macro defined as #define SOME_NAME SOME_NAME They are often used to make possible to use preprocessor to check for values existence like #ifdef SOME_NAME ... use SOME_NAME ... #endif Defining these macro for each enumeration value allows to do finer check in

Re: [Spice-devel] [PATCH spice-streaming-agent] Use true/false for bool value

Acked-by: Christophe Fergeau On Wed, Nov 15, 2017 at 09:44:35AM +, Frediano Ziglio wrote: > Follow up due to read_command declaration change. > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 4 ++-- > 1 file changed, 2

Re: [Spice-devel] [PATCH spice-server] stream-channel: Tell client we are just streaming data

On Mon, Nov 13, 2017 at 03:47:43PM +, Frediano Ziglio wrote: > This give an hint to client which can optimise rendering. > > Signed-off-by: Frediano Ziglio > --- > server/stream-channel.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [Spice-devel] [PATCH spice-common] codegen: Define identity macros for enum types

On Thu, Nov 16, 2017 at 07:12:17AM -0500, Frediano Ziglio wrote: > > > > Hey, > > > > Some concrete examples of what you are going to do with it would be > > useful ;) > > > > Christophe > > > > On Mon, Nov 13, 2017 at 01:16:32PM +, Frediano Ziglio wrote: > > > An identity macro in C is a

Re: [Spice-devel] [PATCH spice-server v2] StreamDevice: Handle incomplete reads of StreamMsgFormat

> > On 16 Nov 2017, at 10:46, Frediano Ziglio wrote: > > > >> > >> This is currently unlikely to happen since we communicate over a pipe > >> and the pipe buffer is sufficiently large to avoid splitting the > >> message. But for completeness, we should handle this scenario.

Re: [Spice-devel] [PATCH spice-streaming-agent 2/3] Rework option handling

> > On 15 Nov 2017, at 13:55, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > Several functional objectives: > > > > > > 1. Be able to share some common options, e.g. fps > > > > > > 2. Prepare for the possibility to

[Spice-devel] libGL error in spice guest

When i test spice OpenGL , i succeed in configuring guest Fedora 26 , host Fedora 26 too , and i can open the guest with virt-viewer , but when i run glxgears -info , i get a black window and the following message:libGL error: MESA-LOADER: failed to retrieve device information MESA-LOADER:

[Spice-devel] [PATCH spice-streaming-agent v2 1/2] Don't tag the plugin interface as 1.0 just yet

From: Christophe de Dinechin This patch series introduces changes in the ABI and API, and I expect a few more to arrive shortly. So I tagged the ABI version as 0.01, and all 0.x versions are considered as incompatible with one another by default. When we reach ABI and API

[Spice-devel] [PATCH spice-streaming-agent v2 2/2] Rework option handling

From: Christophe de Dinechin The overall objective is to pave the way for features that will likely become important, notably the ability to dynamically adjust quality of service to respond to network conditions or client load issues. Consequently, this patch cleans up the

[Spice-devel] [PATCH spice-streaming-agent v2 0/2] Rework option handling

From: Christophe de Dinechin This series reworks option handling to prepare the ABI / API for future dynamic adjustments of settings, for example to allow the agent to deal with QoS in a consistent manner across plugins. In particular, it adds shared "Settings" that are

Re: [Spice-devel] [PATCH spice-server v2] StreamDevice: Handle incomplete reads of StreamMsgFormat

> On 16 Nov 2017, at 10:46, Frediano Ziglio wrote: > >> >> This is currently unlikely to happen since we communicate over a pipe >> and the pipe buffer is sufficiently large to avoid splitting the >> message. But for completeness, we should handle this scenario. >> >>

Re: [Spice-devel] [PATCH spice-streaming-agent v2 1/2] Don't tag the plugin interface as 1.0 just yet

> > From: Christophe de Dinechin > > This patch series introduces changes in the ABI and API, and I expect > a few more to arrive shortly. So I tagged the ABI version as 0.01, > and all 0.x versions are considered as incompatible with one another > by default. When we reach

[Spice-devel] [PATCH] usbredirserver: add support for bind specific address

From: Chen Hanxiao We bind our listen address to in6addr_any, which may be unsecure with multi network cards that belong to internal or external networks. This patch introduces option -4 and -6 to bind a specific address. Signed-off-by: Chen Hanxiao

Re: [Spice-devel] [PATCH spice-streaming-agent 2/3] Rework option handling

> On 15 Nov 2017, at 13:55, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Several functional objectives: >> >> 1. Be able to share some common options, e.g. fps >> 2. Prepare for the possibility to update options on the fly >>

Re: [Spice-devel] [PATCH spice-server v2] StreamDevice: Handle incomplete reads of StreamMsgFormat

> > This is currently unlikely to happen since we communicate over a pipe > and the pipe buffer is sufficiently large to avoid splitting the > message. But for completeness, we should handle this scenario. > > Signed-off-by: Jonathon Jongsma > --- > Since v1: > - updates