Re: [Spice-devel] [PATCH spice-streaming-agent] Remove X11 dependency from send_cursor

On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote: > Allows a better encapsulation in the future > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 28 +--- > 1 file changed, 17 insertions(+), 11 deletions(-) > >

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove X11 dependency from send_cursor

> > On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote: > > Allows a better encapsulation in the future > > > > Signed-off-by: Frediano Ziglio > > --- > > src/spice-streaming-agent.cpp | 28 +--- > > 1 file changed, 17 insertions(+), 11

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove X11 dependency from send_cursor

On Tue, Nov 21, 2017 at 03:25:35AM -0500, Frediano Ziglio wrote: > > > > On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote: > > > Allows a better encapsulation in the future > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > >

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove X11 dependency from send_cursor

> > On Tue, Nov 21, 2017 at 03:25:35AM -0500, Frediano Ziglio wrote: > > > > > > On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote: > > > > Allows a better encapsulation in the future > > > > > > > > Signed-off-by: Frediano Ziglio > > > > --- > > > >

Re: [Spice-devel] [PATCH usbredir] usbredirtestclient: fix a wrong comment

> > From: Chen Hanxiao > > usbredirparser_info is 3. > > Signed-off-by: Chen Hanxiao > --- > usbredirtestclient/usbredirtestclient.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/usbredirtestclient/usbredirtestclient.c

[Spice-devel] [PATCH usbredir v2] usbredirserver: show bus:device of the USB device if specifying vid:pid

From: Chen Hanxiao We use libusb_open_device_with_vid_pid, if multiple devices have the same vid:pid, it will only the first one. This patch will show the bus:device of the chosen one. Signed-off-by: Chen Hanxiao --- v2: control output messages by

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove X11 dependency from send_cursor

On Tue, Nov 21, 2017 at 03:35:55AM -0500, Frediano Ziglio wrote: > > > > On Tue, Nov 21, 2017 at 03:25:35AM -0500, Frediano Ziglio wrote: > > > > > > > > On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote: > > > > > Allows a better encapsulation in the future > > > > > > > > > >

Re: [Spice-devel] [PATCH spice-server] Remove common/mem.h includes

On Mon, Nov 20, 2017 at 04:14:01PM +, Frediano Ziglio wrote: > common/mem.h contains mainly memory allocation functions. > As we decided to move to Glib calls directly avoid to include > function declaration we should not use anymore. Sure, Acked-by: Christophe Fergeau

Re: [Spice-devel] [PATCH spice-server] Reuse SPICE_DECLARE_TYPE macro

Acked-by: Christophe Fergeau On Mon, Nov 20, 2017 at 03:52:27PM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/red-channel-client.h | 17 +--- > server/red-channel.h| 19 ++--- > server/red-client.h

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove X11 dependency from send_cursor

> > On Tue, Nov 21, 2017 at 03:35:55AM -0500, Frediano Ziglio wrote: > > > > > > On Tue, Nov 21, 2017 at 03:25:35AM -0500, Frediano Ziglio wrote: > > > > > > > > > > On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote: > > > > > > Allows a better encapsulation in the future > > > >

Re: [Spice-devel] [PATCH spice-streaming-agent v2 2/2] Rework option handling

On Thu, Nov 16, 2017 at 10:17:28AM -0500, Frediano Ziglio wrote: > > 4. It delegates usage information to the plugins, so that each plugin > >can document its specific options in a consistent way. > > > > 5. It cleans up some confusing or surprising aspects of the interace, > >notably

Re: [Spice-devel] [PATCH spice-common v2] codegen: Define identity macros for enum types

> > One side effect of this patch is that it makes enums.h fairly > unreadable, which is not so good as it's exposed as public API. > I think this header should not take as reference. It's an auto generated file which had not proper comments, people should read spice.proto. > Do you expect to

Re: [Spice-devel] [PATCH spice-server v2] tests: Add a test for streaming devices

On Mon, Nov 20, 2017 at 11:48:53AM +, Frediano Ziglio wrote: > +*/ > +/** > + * Test streaming device > + */ > + > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#include "test-display-base.h" > +#include "test-glib-compat.h" > + > +#ifndef MIN >

[Spice-devel] [PATCH spice-streaming-agent 1/2] Wait to have some client before initialising capture

This saves some resources if no client are connected. Also will allow to get a better capture engine taking into account client supported codecs. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7

[Spice-devel] [PATCH spice-streaming-agent 2/2] Do not use an encoding not supported by the client

This allows for instance old clients to work correctly. Signed-off-by: Frediano Ziglio --- src/concrete-agent.cpp| 5 - src/concrete-agent.hpp| 3 ++- src/spice-streaming-agent.cpp | 6 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git

Re: [Spice-devel] [PATCH spice-common v2] codegen: Define identity macros for enum types

One side effect of this patch is that it makes enums.h fairly unreadable, which is not so good as it's exposed as public API. Do you expect to use this that often? I agree it's convenient, but on the other hand, it's going to make it fairly easy to make "broken" builds if this is used a lot in

Re: [Spice-devel] [PATCH spice-common v3] protocol: Allow to specify a surface will be streamed

ping > > This flag will allow the client to perform some optimisations > on output and buffering processing. > Old clients will ignore this additional flag. > > Signed-off-by: Frediano Ziglio > --- > Changes since v2: > - removed RFC > --- > spice.proto | 13 +++--

Re: [Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

ping wrote: This is a preparatory patch for GTK+ vdagent redesign. Since most of the vdagent code still uses X11 lib, force GDK to use X11 backend by calling gdk_set_allowed_backends("x11"). --- Makefile.am | 2 ++ configure.ac | 1 +

Re: [Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

Hi, On Tue, Nov 21, 2017 at 12:50:23PM +0100, Jakub Janků wrote: > ping Sorry, I'll review it between today and tomorrow. Cheers, > > wrote: > > This is a preparatory patch for GTK+ vdagent redesign. > > Since most of the vdagent code still uses X11 lib, > force

Re: [Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

Hi, On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote: > This is a preparatory patch for GTK+ vdagent redesign. > > Since most of the vdagent code still uses X11 lib, > force GDK to use X11 backend by calling > gdk_set_allowed_backends("x11"). > --- > Makefile.am | 2 ++ >

[Spice-devel] [PATCH spice-server v3] stream-channel: Tell client we are just streaming data

This give an hint to client which can optimise rendering. Signed-off-by: Frediano Ziglio --- server/stream-channel.c | 7 +++ 1 file changed, 7 insertions(+) Changes since v2: - remove conditional code. diff --git a/server/stream-channel.c b/server/stream-channel.c

Re: [Spice-devel] [PATCH spice-server v2] stream-channel: Tell client we are just streaming data

On Tue, Nov 21, 2017 at 12:28:59PM +, Frediano Ziglio wrote: > diff --git a/server/stream-channel.c b/server/stream-channel.c > index c7ca0206..da3f3a4f 100644 > --- a/server/stream-channel.c > +++ b/server/stream-channel.c > @@ -203,6 +203,13 @@ stream_channel_send_item(RedChannelClient *rcc,

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove X11 dependency from send_cursor

Acked-by: Christophe Fergeau On Mon, Nov 20, 2017 at 03:18:14PM +, Frediano Ziglio wrote: > Allows a better encapsulation in the future > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 28 +--- > 1

[Spice-devel] [PATCH spice-server v2] stream-channel: Tell client we are just streaming data

This give an hint to client which can optimise rendering. Signed-off-by: Frediano Ziglio --- configure.ac| 11 +++ server/stream-channel.c | 7 +++ 2 files changed, 18 insertions(+) Changes since v1: - do not require identity macro on

Re: [Spice-devel] [PATCH vdagent v3 1/3] vdagent: add GTK+

Hi, On Tue, Nov 21, 2017 at 5:09 PM, Victor Toso wrote: > > Hi, > > On Mon, Nov 13, 2017 at 06:50:05PM +0100, Jakub Janků wrote: > > This is a preparatory patch for GTK+ vdagent redesign. > > > > Since most of the vdagent code still uses X11 lib, > > force GDK to use X11