Re: [Spice-devel] [PATCH spice-streaming-agent 2/2] Add a macro to deal with the boilerplate of writing a streaming agent plugin

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > include/spice-streaming-agent/plugin.hpp | 8 > 1 file changed, 8 insertions(+) > > diff --git a/include/spice-streaming-agent/plugin.hpp >

Re: [Spice-devel] [PATCH spice-streaming-agent 1/2] Implement version checking for plugins without violating ODR

> > > On 22 Nov 2017, at 18:04, Frediano Ziglio wrote: > > > >> > >> From: Christophe de Dinechin > >> > >> The C++ One Definition Rule (ODR) states that all translation units > >> must see the same definitions. In the current code, when we call > >>

Re: [Spice-devel] [PATCH usbredir v2] usbredirserver: show bus:device of the USB device if specifying vid:pid

> > From: Chen Hanxiao > > We use libusb_open_device_with_vid_pid, if multiple devices > have the same vid:pid, it will only the first one. > > This patch will show the bus:device of the chosen one. > > Signed-off-by: Chen Hanxiao > --- > v2:

Re: [Spice-devel] [PATCH spice-streaming-agent 2/2] Add a macro to deal with the boilerplate of writing a streaming agent plugin

> On 23 Nov 2017, at 12:26, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> include/spice-streaming-agent/plugin.hpp | 8 >> 1 file changed, 8

Re: [Spice-devel] [PATCH usbredir v3] usbredirserver: show bus:device of the USB device if specifying vid:pid

> > From: Chen Hanxiao > > We use libusb_open_device_with_vid_pid, if multiple devices > have the same vid:pid, it will only the first one. > > This patch will show the bus:device of the chosen one. > > Signed-off-by: Chen Hanxiao Acked-by:

Re: [Spice-devel] [PATCH spice-streaming-agent 2/2] Add a macro to deal with the boilerplate of writing a streaming agent plugin

> > > On 23 Nov 2017, at 14:55, Frediano Ziglio wrote: > > > >>> > >>> On 23 Nov 2017, at 12:26, Frediano Ziglio wrote: > >>> > > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin

[Spice-devel] [PATCH] red-stream: fix build without SASL

put red_stream_disable_writev in an #ifdef HAVE_SASL block. red_stream_disable_writev is only called from functions that are already in an #ifdef HAVE_SASL block. Currently when building with SASL disabled, I get: CC red-stream.lo red-stream.c:441:13: error: 'red_stream_disable_writev'

[Spice-devel] [PATCH spice-server 1/3] StreamDevice: Handle incomplete reads of StreamMsgFormat

From: Jonathon Jongsma This is currently unlikely to happen since we communicate over a pipe and the pipe buffer is sufficiently large to avoid splitting the message. But for completeness, we should handle this scenario. Signed-off-by: Jonathon Jongsma

[Spice-devel] [PATCH spice-server 3/3] test-stream-device: Check incomplete reads of StreamMsgFormat

Signed-off-by: Frediano Ziglio --- server/tests/test-stream-device.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/server/tests/test-stream-device.c b/server/tests/test-stream-device.c index c6f47758..656bf56b 100644 ---

[Spice-devel] [PATCH spice-server 2/3] fixup! StreamDevice: Handle incomplete reads of StreamMsgFormat

This fix a regression in message handling. --- server/stream-device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/stream-device.c b/server/stream-device.c index efa6d8db..0953a6d0 100644 --- a/server/stream-device.c +++ b/server/stream-device.c @@ -95,6 +95,7 @@

Re: [Spice-devel] [PATCH spice-streaming-agent 2/2] Add a macro to deal with the boilerplate of writing a streaming agent plugin

> On 23 Nov 2017, at 14:55, Frediano Ziglio wrote: > >>> >>> On 23 Nov 2017, at 12:26, Frediano Ziglio wrote: >>> From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin

[Spice-devel] [PATCH usbredir v3] usbredirserver: show bus:device of the USB device if specifying vid:pid

From: Chen Hanxiao We use libusb_open_device_with_vid_pid, if multiple devices have the same vid:pid, it will only the first one. This patch will show the bus:device of the chosen one. Signed-off-by: Chen Hanxiao --- v3: move dev declaration

Re: [Spice-devel] [PATCH spice-streaming-agent 2/2] Add a macro to deal with the boilerplate of writing a streaming agent plugin

> > > On 23 Nov 2017, at 12:26, Frediano Ziglio wrote: > > > >> > >> From: Christophe de Dinechin > >> > >> Signed-off-by: Christophe de Dinechin > >> --- > >> include/spice-streaming-agent/plugin.hpp | 8 > >> 1 file

Re: [Spice-devel] [PATCH usbredir v2] usbredirserver: show bus:device of the USB device if specifying vid:pid

At 2017-11-23 19:28:42, "Frediano Ziglio" wrote: >> >> From: Chen Hanxiao >> >> We use libusb_open_device_with_vid_pid, if multiple devices >> have the same vid:pid, it will only the first one. >> >> This patch will show the bus:device of the

[Spice-devel] Cannot install spice-guest-tools in Windows 2016

Dear list, I tried to install the latest Spice guest tools in Windows 2016, but the installer says: "Unsupported Windows version". This is the file I was trying to install: https://www.spice-space.org/download/binaries/spice-guest-tools/spice-guest-tools-0.132/spice-guest-tools-0.132.exe Is