Re: [Spice-devel] [PATCH spice-streaming-agent 2/4] mjpeg-fallback: unittest for the options parsing

On Thu, 2018-02-01 at 06:24 -0500, Frediano Ziglio wrote: > > > > Introduce a unit test framework (Catch) to the codebase and a > > simple > > unit test for parsing the options of the mjpeg plugin. > > > > Signed-off-by: Lukáš Hrázký > > --- > > configure.ac

Re: [Spice-devel] [PATCH spice-streaming-agent 0/4] first unit test and options parsing improvements

> > This series introduces a C++ unit test framework called Catch to the > codebase, adds a simple unit test for the options parsing for the mjpeg > plugin and improves on the option parsing code. > > It depends on the header split-off from the previous patch set ([PATCH > spice-streaming-agent

Re: [Spice-devel] [PATCH spice-streaming-agent 2/4] mjpeg-fallback: unittest for the options parsing

> > Introduce a unit test framework (Catch) to the codebase and a simple > unit test for parsing the options of the mjpeg plugin. > > Signed-off-by: Lukáš Hrázký > --- > configure.ac | 3 +++ > src/mjpeg-fallback.cpp| 5 >

Re: [Spice-devel] [PATCH spice-streaming-agent 0/4] first unit test and options parsing improvements

On Thu, 2018-02-01 at 05:42 -0500, Frediano Ziglio wrote: > > > > This series introduces a C++ unit test framework called Catch to > > the > > codebase, adds a simple unit test for the options parsing for the > > mjpeg > > plugin and improves on the option parsing code. > > > > It depends on the

Re: [Spice-devel] [PATCH spice-streaming-agent 1/2] mjpeg plugin: split off the declaration into a header

On Thu, 2018-02-01 at 05:23 -0500, Frediano Ziglio wrote: > > > > > On 31 Jan 2018, at 12:26, Frediano Ziglio > > > wrote: > > > > > > > > > > > > > On 30 Jan 2018, at 17:54, Frediano Ziglio > > > > > wrote: > > > > > > > > > > > > > > > > > > > On

Re: [Spice-devel] spice-vdagent screen resolution auto-adjustment fail

Hi, I agree with you about it. User should not be forced to one DE. Spice server now does not forward messages from spice client to spice server in case it detects QXL in the guest. I 'm not sure but changing this line https://gitlab.com/spice/spice/blob/master/server/agent-msg-filter.c#L107 to

Re: [Spice-devel] [PATCH spice-streaming-agent 2/4] mjpeg-fallback: unittest for the options parsing

On Thu, 2018-02-01 at 06:24 -0500, Frediano Ziglio wrote: > > > > Introduce a unit test framework (Catch) to the codebase and a > > simple > > unit test for parsing the options of the mjpeg plugin. > > > > Signed-off-by: Lukáš Hrázký > > --- > > configure.ac

[Spice-devel] [PATCH spice-streaming-agent 4/5] Implement a daemon/agent separation

This allows to manage properly multiple servers (currently only Xorg). The executable will run as a service forking the proper agent. The agent will then manage the active server. The server receive just minimal information for the various graphic terminals and use to fork the agent.

[Spice-devel] [PATCH spice-streaming-agent 5/5] Provide helper to give information to daemon

This is required so the daemon can manage the various sessions. Signed-off-by: Frediano Ziglio --- data/spice-streaming.desktop.in | 3 +-- spice-streaming-agent.spec.in | 1 + src/Makefile.am | 5 + src/spice-streaming-helper | 24

Re: [Spice-devel] [PATCH spice-streaming-agent 2/4] mjpeg-fallback: unittest for the options parsing

> > On Thu, 2018-02-01 at 06:24 -0500, Frediano Ziglio wrote: > > > > > > Introduce a unit test framework (Catch) to the codebase and a > > > simple > > > unit test for parsing the options of the mjpeg plugin. > > > > > > Signed-off-by: Lukáš Hrázký > > > --- > > >

Re: [Spice-devel] [PATCH spice-streaming-agent 2/4] mjpeg-fallback: unittest for the options parsing

On Thu, 2018-02-01 at 10:13 -0500, Frediano Ziglio wrote: > > > > On Thu, 2018-02-01 at 06:24 -0500, Frediano Ziglio wrote: > > > > > > > > Introduce a unit test framework (Catch) to the codebase and a > > > > simple > > > > unit test for parsing the options of the mjpeg plugin. > > > > > > > >

[Spice-devel] [PATCH spice-streaming-agent 1/5] Install udev rules

Temporary patch that allow the program to work without requiring root permissions. We should use a daemon for this, not open file permission to everybody. Signed-off-by: Frediano Ziglio --- Makefile.am | 4 spice-streaming-agent.spec.in | 1 + 2 files

[Spice-devel] [PATCH spice-streaming-agent 3/5] Starts/stops the agent based on VT status

Check if the current server is active or not and stream only if active. This will allow to support multiple servers running. When multiple servers are running only one have the GPU associated and is writing to the screen. Stop capturing and release resources when the server is not active and vice

[Spice-devel] [PATCH spice-streaming-agent 2/5] Add file with utilities for Xorg

Signed-off-by: Frediano Ziglio --- src/Makefile.am | 2 ++ src/spice-streaming-agent.cpp | 1 + src/xorg-utils.cpp| 33 + src/xorg-utils.hpp| 8 4 files changed, 44 insertions(+) create mode

[Spice-devel] [PATCH spice-streaming-agent 0/5] Support multiple server running.

In order to support multiple servers and avoid to have the device having world permissions a daemon/agent is implemented. The daemon listen to a socket for session information and fork an agent which will handle the active session. Frediano Ziglio (5): Install udev rules Add file with

Re: [Spice-devel] spice-vdagent screen resolution auto-adjustment fail

Hi Victor, Thank you for your message and for the link. Yeah, I am using qxl and actually i read a lot on spice and saw that note on the fact that spice agent might not working the way i want it to work... More over I noticed that the spice-vdagent program flow never walk into "void

Re: [Spice-devel] spice-vdagent screen resolution auto-adjustment fail

Hi, Thank you for the reply. Yeah, I read about Gnome 3 and of course tried it but I just don't like the idea of being fasten to a particular desktop environment that is why i tried to look into changing program code. It seems that it can be more flexible solution... Just noticed that i

Re: [Spice-devel] [PATCH spice-streaming-agent 3/4] mjpeg-fallback-test: use BDD structure for test cases

> > Behaviour Driven Development defines self-describing, story-like > structures for testing that at the same time document them and > descriptive messages when a test fails. > > Signed-off-by: Lukáš Hrázký More or less the same, once you learn the different macros I don't

Re: [Spice-devel] [PATCH spice-streaming-agent 3/4] mjpeg-fallback-test: use BDD structure for test cases

On Thu, 2018-02-01 at 04:17 -0500, Frediano Ziglio wrote: > > > > Behaviour Driven Development defines self-describing, story-like > > structures for testing that at the same time document them and > > descriptive messages when a test fails. > > > > Signed-off-by: Lukáš Hrázký

Re: [Spice-devel] [PATCH spice-streaming-agent 1/2] mjpeg plugin: split off the declaration into a header

> > > On 31 Jan 2018, at 12:26, Frediano Ziglio wrote: > > > >>> > >>> On 30 Jan 2018, at 17:54, Frediano Ziglio wrote: > >>> > > > > On 30 Jan 2018, at 13:29, Lukáš Hrázký wrote: > > > > On Tue, 2018-01-30 at