Re: [Spice-devel] [PATCH spice-server] build: Rename spice-server-enums.tmpl.[ch] to spice-server-enums.[ch].tmpl

2018-03-06 Thread Eduardo Lima (Etrunko)
On 06/03/18 13:37, Christophe Fergeau wrote: > On Tue, Mar 06, 2018 at 11:46:33AM -0300, Eduardo Lima (Etrunko) wrote: >> This is a preparation for meson build, which has built-in support for >> generating enums, but requires the template files to be renamed. It uses >> the basename of template

Re: [Spice-devel] [spice-streaming-agent PATCH] handle_stream_error: add comment for inheriting struct

2018-03-06 Thread Frediano Ziglio
> > Introduced in 548577dc8adae1a558 > > Signed-off-by: Uri Lublin > --- > src/spice-streaming-agent.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index b39782c..e25d47a 100644 > ---

Re: [Spice-devel] [spice-server 2/8] build: Bump glib version

2018-03-06 Thread Frediano Ziglio
> > From spice-gtk b312ca08 commit: > "At the moment: > - Fedora 26 has 2.52 > - Fedora 25 has 2.50 > - Fedora 24 has 2.48 > - CentOS 7 has 2.46 > - Debian 9 has 2.50" > > RHEL6 only have 2.28, but glib 2.32 is only used in a test case at the > moment. Well... or is

Re: [Spice-devel] [spice-server 3/8] tests: basic-event-loop: Silence debug message

2018-03-06 Thread Frediano Ziglio
> > There is currently a debug printf which is always shown when a mainloop > event is triggered. This is unlikely to be useful unless one is > debugging the event loop code. > --- > server/tests/basic-event-loop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH spice-streaming-agent v5 2/2] Implement handling of error messages from the server

2018-03-06 Thread Frediano Ziglio
> > > On 3 Mar 2018, at 10:36, Frediano Ziglio wrote: > > > >>> > >>> On 28 Feb 2018, at 13:53, Lukáš Hrázký wrote: > >>> > >>> Log error messages from the server to syslog (not aborting the agent). > >>> Limits the messages to 1023 bytes, error

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-06 Thread Christophe Fergeau
On Fri, Mar 02, 2018 at 06:06:32PM +0100, Christophe de Dinechin wrote: > > FWIW, I also find myself in agreement with Frediano and Lukas on this point. > > OK. Maybe I misunderstood something. > > Do we agree that the case Frediano raised is someone trying: > > throw Error(“The value of

[Spice-devel] qdh displays

2018-03-06 Thread Peter Carlson
when I connect to my vm using my laptop I get a way different resolution on the guest than with my desktop. My laptop has a resolution of 3840x2160.  A maximized remote-viewer client results in a guest resolution of 1920x991 My desktop has a resolution of 2560x1440.  A mxaimized

[Spice-devel] [spice-server 0/8] Add test-listen test case

2018-03-06 Thread Christophe Fergeau
While working on some bug/new feature for SPICE, I added a test case for our spice_server_set_port/_set_tls/... API. While the work I did this for still needs some work, this test case should be good enough on its own. Christophe ___ Spice-devel

[Spice-devel] [spice-server 1/8] reds: Close sockets when failing to watch them

2018-03-06 Thread Christophe Fergeau
Currently if we fail to set up the watch waiting for accept() to be called on the socket, we still keep the network socket open even if we are not going to be able to use it. This commit makes sure it's closed a set to -1 when such a failure occurs. --- server/reds.c | 5 + 1 file changed, 5

[Spice-devel] [spice-server 8/8] test-listen: Add Unix socket test

2018-03-06 Thread Christophe Fergeau
--- configure.ac | 3 +++ server/tests/Makefile.am | 4 +++- server/tests/test-listen.c | 38 +++--- 3 files changed, 41 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index bcd4bb4d5..863834343 100644 --- a/configure.ac

[Spice-devel] [spice-server 4/8] test-listen: Add test case port/address configuration

2018-03-06 Thread Christophe Fergeau
This test case will be testing the external spice-server API to configure the address/port it's listening on. For now it sets up a listening server, spawns a thread which is going to connect to that port, and check it gets the REDQ magic upon connection. It will be extended to test for Unix

[Spice-devel] [spice-server 2/8] build: Bump glib version

2018-03-06 Thread Christophe Fergeau
From spice-gtk b312ca08 commit: "At the moment: - Fedora 26 has 2.52 - Fedora 25 has 2.50 - Fedora 24 has 2.48 - CentOS 7 has 2.46 - Debian 9 has 2.50" RHEL6 only have 2.28, but glib 2.32 is only used in a test case at the moment. --- configure.ac | 4 ++-- 1 file

[Spice-devel] [spice-server 5/8] test-listen: Add connection attempt to non-open port

2018-03-06 Thread Christophe Fergeau
--- server/tests/test-listen.c | 46 +++--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/server/tests/test-listen.c b/server/tests/test-listen.c index 052dc0b8f..562f07487 100644 --- a/server/tests/test-listen.c +++

[Spice-devel] [spice-server 3/8] tests: basic-event-loop: Silence debug message

2018-03-06 Thread Christophe Fergeau
There is currently a debug printf which is always shown when a mainloop event is triggered. This is unlikely to be useful unless one is debugging the event loop code. --- server/tests/basic-event-loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Spice-devel] [spice-server 6/8] test-listen: Add event loop helpers

2018-03-06 Thread Christophe Fergeau
These factor a bit of common code, and more importantly, help with freeing all event loop related data at the end of each test. --- server/tests/test-listen.c | 120 - 1 file changed, 86 insertions(+), 34 deletions(-) diff --git

[Spice-devel] [spice-server 7/8] test-listen: Add TLS test

2018-03-06 Thread Christophe Fergeau
--- server/tests/test-listen.c | 106 +++-- 1 file changed, 103 insertions(+), 3 deletions(-) diff --git a/server/tests/test-listen.c b/server/tests/test-listen.c index e88105eea..2a15df1ab 100644 --- a/server/tests/test-listen.c +++

Re: [Spice-devel] [spice-streaming-agent v2] build: Don't use -fvisibility when building the agent

2018-03-06 Thread Frediano Ziglio
> > In my testing (x86_64/gcc), this had no impact on the resulting binary, > building with/without it gives the same stripped binary save for its > buildid. > The check for -fvisibility in configure.ac is kept as this is going to > be useful when we ship dlopen'ed plugins. > > Signed-off-by:

[Spice-devel] [PATCH spice-server] build: Rename spice-server-enums.tmpl.[ch] to spice-server-enums.[ch].tmpl

2018-03-06 Thread Eduardo Lima (Etrunko)
This is a preparation for meson build, which has built-in support for generating enums, but requires the template files to be renamed. It uses the basename of template files to generate the output, and in this case it would be the same file for both '.c' and '.h'. Reference

Re: [Spice-devel] [PATCH spice-server] build: Rename spice-server-enums.tmpl.[ch] to spice-server-enums.[ch].tmpl

2018-03-06 Thread Christophe Fergeau
On Tue, Mar 06, 2018 at 11:46:33AM -0300, Eduardo Lima (Etrunko) wrote: > This is a preparation for meson build, which has built-in support for > generating enums, but requires the template files to be renamed. It uses > the basename of template files to generate the output, and in this case > it

Re: [Spice-devel] [spice-server 1/8] reds: Close sockets when failing to watch them

2018-03-06 Thread Christophe Fergeau
On Tue, Mar 06, 2018 at 11:38:15AM -0500, Frediano Ziglio wrote: > Looks fine. > Actually when this function returns -1 spice_server_init returns -1 and Qemu > calls exit so there's no much difference at runtime. > But I suppose this is necessary for your tests. I did not try the tests without

Re: [Spice-devel] [PATCH 06/22] Get rid of C-style memset initializations, use C++ style aggregates

2018-03-06 Thread Christophe Fergeau
On Thu, Mar 01, 2018 at 09:01:37PM +0100, Christophe de Dinechin wrote: > > On 28 Feb 2018, at 17:36, Christophe Fergeau wrote: > > > > My understanding is that the previous iteration was quite controversial, > > I would just drop it from the series unless you get acks from

Re: [Spice-devel] [spice-server 1/8] reds: Close sockets when failing to watch them

2018-03-06 Thread Frediano Ziglio
> > Currently if we fail to set up the watch waiting for accept() to be > called on the socket, we still keep the network socket open even if we > are not going to be able to use it. This commit makes sure it's closed a > set to -1 when such a failure occurs. > --- > server/reds.c | 5 + > 1

Re: [Spice-devel] [PATCH 12/22] Add exception handling classes

2018-03-06 Thread Jonathon Jongsma
On Tue, 2018-03-06 at 11:02 +0100, Christophe Fergeau wrote: > On Fri, Mar 02, 2018 at 06:06:32PM +0100, Christophe de Dinechin > wrote: > > > FWIW, I also find myself in agreement with Frediano and Lukas on > > > this point. > > > > OK. Maybe I misunderstood something. > > > > Do we agree that

Re: [Spice-devel] [PATCH spice-streaming-agent v5 2/2] Implement handling of error messages from the server

2018-03-06 Thread Christophe Fergeau
On Mon, Mar 05, 2018 at 05:58:15PM +0100, Christophe de Dinechin wrote: > > Perhaps you lost the mails saying that the protocol structure don't and > > won't have internal padding. > > Only on x86. It has padding on any ABI with a natural 64-bit alignment. > > I don’t have an Itanium handy, but