[Spice-devel] about spice-gtk folder sharing feature

hi, I rebuild spice-gtk-0.34 with --enableo-webdav and install it ,rebuid virt-viewer-6.0 and install it ,but reomote-viewer folder sharing is not enabled you can see my screeshot below Can you help me to solve this problem?u

Re: [Spice-devel] about spice-gtk folder sharing feature

On Fri, May 18, 2018 at 03:13:57PM +0800, zhanglei_hlj wrote: > hi, I rebuild spice-gtk-0.34 with --enableo-webdav > and install it ,rebuid virt-viewer-6.0 and install it > ,but reomote-viewer folder sharing is not enabled > > you can see my screeshot below Your VM

Re: [Spice-devel] [PATCH spice-common] Fix cast to spice_marshalller_intem_free_func function

> > On 17/05/18 18:15, Jonathon Jongsma wrote: > > Fine with me. > > > > Thanks, I fixed a typo in header before pushing. > > s/spice_marshalller_intem_free_func/spice_marshaller_item_free_func > Can I send a follow up to remove the initial underscore? Looks like some Python naming...

Re: [Spice-devel] [PATCH spice-common] Add .gitlab-ci.yml file

> > On 17/05/18 12:11, Frediano Ziglio wrote: > >> > >> Here is an example of a successful run: > >> > >> https://gitlab.freedesktop.org/etrunko/spice-common/-/jobs/549 > >> > > > > Stupid question. Is it worth doing giving that spice-common is compiled > > and tested from both spice-server and

Re: [Spice-devel] [PATCH spice-streaming-agent v2 8/9] Encapsulate the stream port fd and locking

> > Wrap the streaming virtio port along with the mutex to lock it in a > class. Pass the class temporarily around to functions that need it until > the functions too are consolidated into the class. > > The locking needs to be outside the class for now to prevent situations > like: > 1 - data

Re: [Spice-devel] [PATCH spice-gtk 1/3] RFC channel-display-gst: Prevent accumulating output queue

> > Hi, > > > On 04/19/2018 03:28 PM, Frediano Ziglio wrote: > > display_queue is queued with decoded frames ready to be displayed. > > However current code can insert a timeout before displaying and > > removing the queued frames. As the frames are not compressed the > > usage of memory by

Re: [Spice-devel] [PATCH spice-streaming-agent v2 9/9] Refactor and simplify polling for messages to read

> > Use exceptions for errors, remove the inner loop in read_command, which > should practically never do more than one iteration. Handle EINTR from > poll and report nothing to read, relying on the enclosing loop to poll > for the command on the next iteration. > > Signed-off-by: Lukáš Hrázký

Re: [Spice-devel] [PATCH spice-streaming-agent v2 9/9] Refactor and simplify polling for messages to read

On Fri, 2018-05-18 at 05:27 -0400, Frediano Ziglio wrote: > > > > Use exceptions for errors, remove the inner loop in read_command, which > > should practically never do more than one iteration. Handle EINTR from > > poll and report nothing to read, relying on the enclosing loop to poll > > for

Re: [Spice-devel] [PATCH spice-streaming-agent v2 4/9] Introduce a WriteError exception for write_all()

> > Update the interface to not return the size written, as it is not needed > anymore. > > Signed-off-by: Lukáš Hrázký > --- > src/error.cpp | 1 - > src/error.hpp | 14 + > src/spice-streaming-agent.cpp | 48 >

Re: [Spice-devel] [PATCH spice-streaming-agent v2 5/9] Unify the structure of write_all() and read_all()

> > Both versions are fine, unify for consistency. Use the optically less > verbose version. > > Signed-off-by: Lukáš Hrázký > --- > src/stream-port.cpp | 20 +++- > src/stream-port.hpp | 4 ++-- > 2 files changed, 13 insertions(+), 11 deletions(-) > >

Re: [Spice-devel] [PATCH] Revert "usbredir: Disconnect USB device asynchronously"

On Sat, 2018-05-12 at 11:19 +0800, Qiu Wenbo wrote: > Yes. The situation can be easily reproduced by the patch below. We > have noticed it usually happen on some thin clients (without the > patch). Also, I can reproduce it on my desktop (latest version of > Arch linux, ryzen 1600x) with debug

[Spice-devel] [PATCH spice-streaming-agent v3 5/5] Refactor and simplify polling for messages to read

Use exceptions for errors. Handle EINTR from poll and report nothing to read, relying on the enclosing loop to poll for the command on the next iteration. Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 47 --- 1 file

[Spice-devel] [PATCH spice-streaming-agent v3 0/5] nonblocking mode for stream port and some refactor

Changes since v2: - Removed the acked and pushed commits. - Fixed accidental removal of test-mjpeg-fallback from TESTS. - Added the copyright header to test-stream-port. - Separated the fix for indefinitely looping read on a closed virtio port into it's own patch (including the test case). -

[Spice-devel] [PATCH spice-streaming-agent v3 3/5] Change the mode to NONBLOCK for the virtio port

In blocking mode, a write to the virtio port blocks indefinitely if the server closes the virtio port on it's side. Change to non-blocking mode, so that we can quit the streaming agent in case the port gets closed. Signed-off-by: Lukáš Hrázký ---

[Spice-devel] [PATCH spice-streaming-agent v3 1/5] Add a unit test for the stream port

Signed-off-by: Lukáš Hrázký --- src/unittests/.gitignore | 1 + src/unittests/Makefile.am | 8 ++ src/unittests/test-stream-port.cpp | 55 ++ 3 files changed, 64 insertions(+) create mode 100644

Re: [Spice-devel] [PATCH spice-common] Fix cast to spice_marshalller_intem_free_func function

On 18/05/18 05:42, Frediano Ziglio wrote: >> >> On 17/05/18 18:15, Jonathon Jongsma wrote: >>> Fine with me. >>> >> >> Thanks, I fixed a typo in header before pushing. >> >> s/spice_marshalller_intem_free_func/spice_marshaller_item_free_func >> > > Can I send a follow up to remove the initial

Re: [Spice-devel] [PATCH spice-common] Add .gitlab-ci.yml file

On 18/05/18 05:57, Frediano Ziglio wrote: >> >> On 17/05/18 12:11, Frediano Ziglio wrote: Here is an example of a successful run: https://gitlab.freedesktop.org/etrunko/spice-common/-/jobs/549 >>> >>> Stupid question. Is it worth doing giving that spice-common is compiled

Re: [Spice-devel] [PATCH spice-streaming-agent v3 0/5] nonblocking mode for stream port and some refactor

For the series, Acked-by: Frediano Ziglio Frediano > > Changes since v2: > - Removed the acked and pushed commits. > - Fixed accidental removal of test-mjpeg-fallback from TESTS. > - Added the copyright header to test-stream-port. > - Separated the fix for indefinitely

[Spice-devel] [PATCH spice-common v2] Add support for building with meson/ninja

In a comparison with current autotools build system, meson/ninja provides a huge improvement in build speed, while keeping the same functionalities currently available and being considered more user friendly. The new system coexists within the same repository with the current one, so we can do

Re: [Spice-devel] [RFC spice-gtk v3 1/1] Gstreamer: Use GstVideoOverlay if possible

Hi On Thu, May 17, 2018 at 3:01 PM, Frediano Ziglio wrote: >> >> Hi >> >> On Thu, May 17, 2018 at 1:50 PM, Frediano Ziglio wrote: >> >> >> >> On Wed, May 16, 2018 at 3:54 PM, Frediano Ziglio >> >> wrote: >> >> >> >> >> >> On Wed, May

[Spice-devel] [PATCH spice-streaming-agent v3 2/5] Fix reading from a closed virtio port

Reading from a closed virtio port looped indefinitely, check the read() returning 0 and throw an exception if it happens. Signed-off-by: Lukáš Hrázký --- src/error.hpp | 2 ++ src/stream-port.cpp| 4

[Spice-devel] [PATCH spice-streaming-agent v3 4/5] Encapsulate the stream port fd and locking

Wrap the streaming virtio port along with the mutex to lock it in a class. Pass the class temporarily around to functions that need it until the functions too are consolidated into the class. The locking needs to be outside the class for now to prevent situations like: 1 - data header 2 - cursor

[Spice-devel] [PATCH spice-common] marshaller: Remove initial underscore from static function

This is the only function starting with an underscore, looks out of style. Signed-off-by: Frediano Ziglio --- common/marshaller.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/marshaller.c b/common/marshaller.c index 80cedb7..b55b568 100644

Re: [Spice-devel] [spice-html5] Check if streams array exists in handle_draw_jpeg_onload

On 05/16/2018 05:17 AM, Christophe Fergeau wrote: From: Joel Purra - It seems `SpiceDisplayConn` does not always have the array `this.o.sc.streams` set. - It also seems (stream?) images can be loaded before `streams` is set. - Without `streams`, or the specific stream

Re: [Spice-devel] [PATCH spice-common v2] Add support for building with meson/ninja

On Fri, 2018-05-18 at 11:57 -0300, Eduardo Lima (Etrunko) wrote: > In a comparison with current autotools build system, meson/ninja > provides a huge improvement in build speed, while keeping the same > functionalities currently available and being considered more user > friendly. > > The new