Re: [Spice-devel] [RFC spice-server] fixup! streaming: Restart guest video streams on video-codec changes

2019-08-15 Thread Frediano Ziglio
> > Update of the previous patch that resets only the stream channel whose > preferred codec list has been updated > > Signed-off-by: Kevin Pouget Why not just computing the list and call request_new_stream ? This would require a single file change. > --- > server/main-dispatcher.c | 12

Re: [Spice-devel] [PATCH spice-server] Remove reference to removed ABI

2019-08-15 Thread Uri Lublin
On 8/15/19 11:30 AM, Frediano Ziglio wrote: spice_server_migrate_client_state was removed by commit 3c6b4e415fa1e2ce212d09ba15c90cd58b4ec4b4 Author: Marc-André Lureau Date: Fri Oct 24 17:16:35 2014 +0200 Remove spice-experimental Remove unneded symbols that nobody should

Re: [Spice-devel] [RFC spice-gtk 2/2] channel-display: fix bug when sending preferred video codecs

2019-08-15 Thread Frediano Ziglio
> > The transfer between the codecs array and the message payload cannot > be done with memcpy because the data-type lengths are different > (gint/uint8_t). > > Signed-off-by: Kevin Pouget > --- > src/channel-display.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff

[Spice-devel] [PATCH spice-server] reds: Fix indentation of spice_server_char_device_add_interface

2019-08-15 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index a3795ab90..c294137be 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3301,8 +3301,8 @@ static void reds_on_char_device_destroy(RedsState

[Spice-devel] [PATCH spice-server] Remove reference to removed ABI

2019-08-15 Thread Frediano Ziglio
spice_server_migrate_client_state was removed by commit 3c6b4e415fa1e2ce212d09ba15c90cd58b4ec4b4 Author: Marc-André Lureau Date: Fri Oct 24 17:16:35 2014 +0200 Remove spice-experimental Remove unneded symbols that nobody should be using anyway. ABI is modified with this

Re: [Spice-devel] [spice-gtk v3 8/9] usb-redir: enable redirection of emulated CD drive

2019-08-15 Thread Yuri Benditovich
On Tue, Aug 13, 2019 at 2:29 PM Frediano Ziglio wrote: > > > > > Add implementation of emulated device to build. > > Now it is possible to create emulated CD devices. > > > > Signed-off-by: Yuri Benditovich > > Would be better to compile only if needed, like > >