On Mon, Jan 18, 2016 at 10:05:50AM +0100, Fabiano Fidêncio wrote:
> While doing the work to use GTask isntead of GSimpleAsyncResult I've
instead
> noticed a few error strings that were not marked to be translated.
> I am not exactly sure if it was intentional or not, but I do believe
> that our e
On Mon, Jan 18, 2016 at 04:15:36AM -0500, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > It's being slowly deprecated im glib
s/im/in/
> > https://bugzilla.gnome.org/show_bug.cgi?id=754687
> > ---
> > src/channel-display.c | 6 +++---
> > src/channel-smartcard.c | 4 ++
On Mon, Jan 18, 2016 at 10:05:37AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> For using the new GTask API, let's bump GIO (part of GLib) dependency
> version to 2.36, which is safe based on major distro suppor
On Mon, Jan 18, 2016 at 10:05:38AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/channel-main.c | 83
> ++
> 1 file changed, 34 insertions(+), 49 de
On Mon, Jan 18, 2016 at 10:05:39AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/channel-port.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/channel-port.c b/src/chan
Acked-by: Christophe Fergeau
On Mon, Jan 18, 2016 at 10:05:40AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/channel-usbredir.c | 39 +--
> 1 f
On Mon, Jan 18, 2016 at 10:05:41AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/smartcard-manager.c | 33 +
> 1 file changed, 13 insertions(+), 20 deletions(-)
>
> dif
Acked-by: Christophe Fergeau
On Mon, Jan 18, 2016 at 10:05:42AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/spice-channel.c | 32 +---
> 1 file changed
On Mon, Jan 18, 2016 at 10:05:43AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/spice-gstaudio.c | 48 ++--
> 1 file changed, 10 insertions(+), 38 deletions
On Mon, Jan 18, 2016 at 10:05:44AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/spice-pulse.c | 96
> +++
> 1 file changed, 33 insertions(+), 63 de
self,
> + NULL,
> + spice_usb_device_manager_auto_connect_cb,
> + spice_usb_device_ref(device));
> +
> +g_task_set_source_tag(task,
> + spice_usb_device_manag
On Mon, Jan 18, 2016 at 10:05:48AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/win-usb-driver-install.c | 86
> +---
> 1 file changed, 41 insertions(+), 45 de
On Mon, Jan 18, 2016 at 10:05:49AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
Is there an upstream for wocky-http-proxy where you should send this
patch?
> ---
> src/wocky-http-proxy.c | 47 ++
On Mon, Jan 18, 2016 at 10:05:45AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/usb-acl-helper.c | 76
>
> 1 file changed, 35 insertions(+), 41 de
On Mon, Jan 18, 2016 at 10:05:45AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/usb-acl-helper.c | 76
>
> 1 file changed, 35 insertions(+), 41 de
On Mon, Jan 18, 2016 at 10:05:47AM +0100, Fabiano Fidêncio wrote:
> Instead of using GSimpleAsyncResult, use the new GTask API, which is
> much more straightforward.
> ---
> src/vmcstream.c | 129
> +++-
> 1 file changed, 52 insertions(+), 77 de
On Mon, Jan 18, 2016 at 02:41:42PM -0600, Jonathon Jongsma wrote:
> On Mon, 2016-01-18 at 10:05 +0100, Fabiano Fidêncio wrote:
> > @@ -995,7 +997,7 @@ static void complete_task(SpicePulse *pulse, struct
> > async_task *task, const gcha
> > g_task_return_new_error(task->task,
> >
On Tue, Dec 01, 2015 at 08:30:42AM +0100, Victor Toso wrote:
> Hi,
>
> On Mon, Nov 30, 2015 at 01:04:26PM +0100, Christophe Fergeau wrote:
> > spice_warn_if_fail() is doing the same thing except for the inverted
> > condition. spice_warn_if() is being removed from spice-commo
On Wed, Dec 16, 2015 at 03:15:35PM +0100, Victor Toso wrote:
> Hi,
>
> On Wed, Dec 16, 2015 at 02:27:13PM +0100, Christophe Fergeau wrote:
> > They can be used in spice-server to replace spice_return_if_fail.
> > Currently spice_return_if_fail aborts in spice-server, and it&#
On Fri, Dec 18, 2015 at 11:40:51AM +0100, Christophe Fergeau wrote:
> On Thu, Dec 17, 2015 at 10:43:05PM +0100, Victor Toso wrote:
> > > +/* Checks that spice_return_if_fail() aborts by default */
> > > +static void test_spice_fatal_return_if_fail(void)
> > > +{
&g
On Wed, Dec 16, 2015 at 03:05:07PM +0100, Victor Toso wrote:
> Hi,
>
> On Wed, Dec 16, 2015 at 02:27:08PM +0100, Christophe Fergeau wrote:
> > spice-common has been duplicating glib logging methods for a long while.
> > Now that spice-common is depending on glib, it
On Wed, Jan 20, 2016 at 01:38:52PM +0100, Fabiano Fidêncio wrote:
> On Mon, Jan 18, 2016 at 11:31 AM, Christophe Fergeau
> wrote:
> > On Mon, Jan 18, 2016 at 10:05:38AM +0100, Fabiano Fidêncio wrote:
> >> @@ -1794,15 +1785,15 @@ static void file_xfer_close_cb(GObje
On Wed, Jan 20, 2016 at 02:29:19PM +0100, Fabiano Fidêncio wrote:
> On Wed, Jan 20, 2016 at 2:03 PM, Christophe Fergeau
> wrote:
> > On Wed, Jan 20, 2016 at 01:38:52PM +0100, Fabiano Fidêncio wrote:
> >> On Mon, Jan 18, 2016 at 11:31 AM, Christophe Fergeau
> >>
On Tue, Jan 19, 2016 at 11:54:47AM +, Frediano Ziglio wrote:
> These set of patches try to improve current event loop code.
>
> Patches improve test event loop, make a template from
> them and use for main loop.
> These patches also improve glib main loop patch from Marc and
> supercede fixes
On Wed, Jan 20, 2016 at 02:45:59PM +0100, Fabiano Fidêncio wrote:
> On Wed, Jan 20, 2016 at 2:39 PM, Christophe Fergeau
> wrote:
> > I don't really understand what you are getting at.
> > The way I read the code is
> > "if we have an error, then return from the
On Wed, Jan 20, 2016 at 04:09:44PM +0100, Fabiano Fidêncio wrote:
> >> static void spice_pulse_complete_async_task(struct async_task *task,
> >> const gchar *err_msg)
> >> @@ -1157,19 +1143,13 @@ static void
> >> pulse_stream_restore_info_async(gboolean is_playback,
> >>
On Fri, Dec 18, 2015 at 11:40:51AM +0100, Christophe Fergeau wrote:
> On Thu, Dec 17, 2015 at 10:43:05PM +0100, Victor Toso wrote:
> > > +/* Checks that g_return_if_fail() does not abort by default */
> > > +static void test_spice_non_fatal_g_return_if_fail(void)
> > &g
Hi,
Here is a new iteration of the glib patch series.
Main changes is a rework of the test case, some of the test
cases were not working as expected as g_test_init() sets all warnings and
criticals as being fatal, which is not what we want to have by default
when a test case tries to test G_DEBUG=
spice-common has been duplicating glib logging methods for a long while.
Now that spice-common is depending on glib, it's more consistent to use
glib logging too. However, the code base is still using spice logging
functions.
This commit aims to make spice logging go through glib logging system,
wh
This gives us a baseline of how the SPICE/glib integration is supposed
to behave.
Everything goes through glib logging facilities, and is impacted by
G_MESSAGES_DEBUG/G_DEBUG=fatal-{warnings,criticals}
Messages in the SPICE_LOG_DOMAIN log domain (output either through
spice_log() or g_log()) will
The next commit will introduce a test for log messages. As
libspice-common.la behaviour varies depending on whether
SPICE_DISABLE_ASSERT was defined at compile-time, this test will also
take into account this preprocessor define.
We are more likely to get a consistent build (SPICE_DISABLE_ASSERT be
It's redundant with spice_warn_if_fail(), and can even be confusing.
Acked-by: Jonathon Jongsma
---
common/log.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/common/log.h b/common/log.h
index a56105a..0e03f59 100644
--- a/common/log.h
+++ b/common/log.h
@@ -95,12 +95,6 @@ void spice_
If header guards are working as expected, there should not be multiple
definitions of these macros. If they are redefined somewhere else, this
is a bug we want to fix.
Acked-by: Jonathon Jongsma
---
common/log.h | 26 --
1 file changed, 26 deletions(-)
diff --git a/commo
They can be used in spice-server to replace spice_return_if_fail.
Currently spice_return_if_fail aborts in spice-server, and it's not
always clear whether using a non-aborting g_return_if_fail is acceptable
or not. Having a spice_assert_if_fail alternative makes it clearer that
this is not going to
No need to have our own SPICE_STMT_BEGIN/END and SPICE_STRINGIFY
Acked-by: Jonathon Jongsma
---
common/log.h | 67 ++--
1 file changed, 33 insertions(+), 34 deletions(-)
diff --git a/common/log.h b/common/log.h
index d9e6023..1c54b0f 10064
On Wed, Jan 20, 2016 at 10:15:42AM -0500, Frediano Ziglio wrote:
> > diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
> > index 6f02c99..000b097 100644
> > --- a/server/tests/Makefile.am
> > +++ b/server/tests/Makefile.am
> > @@ -27,10 +27,15 @@ libtest_a_SOURCES =
On Thu, Jan 21, 2016 at 07:35:44AM -0500, Frediano Ziglio wrote:
> >
> > This gives us a baseline of how the SPICE/glib integration is supposed
> > to behave.
> >
> > Everything goes through glib logging facilities, and is impacted by
> > G_MESSAGES_DEBUG/G_DEBUG=fatal-{warnings,criticals}
> >
>
On Thu, Jan 21, 2016 at 07:33:11AM -0500, Frediano Ziglio wrote:
> >
> > The next commit will introduce a test for log messages. As
> > libspice-common.la behaviour varies depending on whether
> > SPICE_DISABLE_ASSERT was defined at compile-time, this test will also
> > take into account this prep
On Thu, Jan 21, 2016 at 07:29:59AM -0500, Frediano Ziglio wrote:
> > +/* Make sure GLib default log handler will show the debug
> > messages. Messing with
> > + * environment variables like this is ugly, but this only
> > happens when the legacy
> > + * SPICE_DEB
On Wed, Jan 20, 2016 at 10:15:42AM -0500, Frediano Ziglio wrote:
> > diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
> > index 6f02c99..000b097 100644
> > --- a/server/tests/Makefile.am
> > +++ b/server/tests/Makefile.am
> > @@ -27,10 +27,15 @@ libtest_a_SOURCES =
They call the functions provided by event_loop_core, but with a NULL
SpiceCoreInterfaceInternal parameter. It makes more sense to pass
event_loop_core rather than NULL.
This will allow to pass the GMainContext to be used through
SpiceCoreInterfaceInternal rather than through a template parameter.
-
---
server/red-worker.c | 29 -
server/red-worker.h | 1 -
2 files changed, 4 insertions(+), 26 deletions(-)
diff --git a/server/red-worker.c b/server/red-worker.c
index 24bb435..f813649 100644
--- a/server/red-worker.c
+++ b/server/red-worker.c
@@ -64,7 +64,6 @@ stru
Hey,
This is a slightly split up version of the RFC I sent earlier which get rid of
the template file which was introduced for the mainloop in favour of a regular
C file.
Since the glib main loop patch hasn't been pushed yet, the red-worker.c changes
can be squashed in to the "worker: use glib m
Since SpiceCoreInterfaceInternal is a private data structure, we can
extend it as we see fit without breaking ABI. In particular, adding a
GMainContext member to it allows us to remove the need for
the event loop template which is currently included in the
basic_event_loop.c test file.
---
server/
From: Frediano Ziglio
Use the glib mainloop instead of writing our own. The glib loop is both
cleaner to use and is more extensible. It is also very mature and
reduces the maintenance burden on the spice server.
Signed-off-by: Marc-André Lureau
Signed-off-by: Jonathon Jongsma
Signed-off-by: Fr
On Mon, Jan 25, 2016 at 09:19:57AM -0500, Frediano Ziglio wrote:
> Hi,
> I found these patches on the refactory branch:
>
> http://cgit.freedesktop.org/~fziglio/spice-server/commit/?h=refactory&id=9e36956b302971aae119cb7d12cdc91345203dcd
> http://cgit.freedesktop.org/~fziglio/spice-server/commit
On Tue, Jan 26, 2016 at 12:11:55PM +, Frediano Ziglio wrote:
> This increase code reuse and make Glib integration more straight forward.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-worker.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/server/
Looks good to me
Acked-by: Christophe Fergeau
Christophe
On Tue, Jan 26, 2016 at 09:44:31AM +, Frediano Ziglio wrote:
> Use a custom GSource.
> This to avoid having to allocate a timer all the time we add one.
>
> Signed-off-by: Frediano Ziglio
> ---
> server
On Tue, Jan 26, 2016 at 06:49:55AM -0500, Frediano Ziglio wrote:
> >
> > On Thu, Jan 21, 2016 at 07:29:59AM -0500, Frediano Ziglio wrote:
> > > > +/* Make sure GLib default log handler will show the debug
> > > > messages. Messing with
> > > > + * environment variables like
On Tue, Jan 26, 2016 at 06:53:20AM -0500, Frediano Ziglio wrote:
> >
> > They can be used in spice-server to replace spice_return_if_fail.
> > Currently spice_return_if_fail aborts in spice-server, and it's not
> > always clear whether using a non-aborting g_return_if_fail is acceptable
> > or not
On Thu, Nov 19, 2015 at 12:48:17PM -0500, Marc-André Lureau wrote:
> Note that all spice_return*_if_fail() in spice-common should be safe
> to move to g_return_if_fail() when I did the conversion (spice-gtk
> doesn't use fatal spice_return)
Actually, I realized today that spice-gtk does *not* buil
On Tue, Jan 26, 2016 at 08:16:20AM -0500, Frediano Ziglio wrote:
> Why instead you merge the other patches and split this one removing that
> macro definition?
I've now pushed this series up to "log: Kill spice_warn_if"
Christophe
signature.asc
Description: PGP signature
___
On Wed, Jan 27, 2016 at 01:51:12PM +0200, Dmitry Fleytman wrote:
> Hello, Spice List
>
> I just got a confirmation that UsbDk backend integration for libusb was
> pushed upstream:
>
> 24c5289 build: Integrate usbdk backend
> 8823c17 usbdk: Introduce usbdk backend
> 5d83aba windows: Rename window
On Wed, Jan 27, 2016 at 02:09:25PM +0200, Dmitry Fleytman wrote:
>
> > On 27 Jan 2016, at 14:00 PM, Christophe Fergeau wrote:
> >
> > On Wed, Jan 27, 2016 at 01:51:12PM +0200, Dmitry Fleytman wrote:
> >> Hello, Spice List
> >>
> >> I just got a
Hey,
On Wed, Jan 27, 2016 at 09:18:14AM -0500, Frediano Ziglio wrote:
> Hi,
> after the analysis of image performance and looking at the way data are sent
> I was thinking about compression at stream level (that is socket instead of
> image
> level).
Makes sense, though we probably do not want
Hey,
On Wed, Jan 27, 2016 at 10:39:32PM +0600, Baurzhan Konurbayev wrote:
> Frediano, libepoxy was missing, but after installing still no luck :(
> Building of space failed again during make process with the message
> "undefined reference to `gl...".
>
> Here are installed packages:
>
> [buildus
On Wed, Jan 27, 2016 at 11:49:28AM -0800, Chris Dickens wrote:
> Hi,
>
> I have addressed this issue with commit c8f71151.
Great, thanks, looks good to me!
Christophe
signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@l
Hey,
On Thu, Jan 28, 2016 at 02:22:22PM +, Frediano Ziglio wrote:
> Fatal error exit usually with abort() causing SIGABRT to be triggered
> which can have problems with core dump degeration depending on system
degeration? generation?
> settings. Capturing and exiting on this signal solve the
Hey,
On Tue, Feb 02, 2016 at 06:10:28PM +0900, Sunny Shin wrote:
> I have a few questions about udp version of spice protocol.
>
> Is there a plan to support udp in spice protocol?
>
> If we support udp, what do we need to implement?
> Is it enough to change tcp channels to udp ones?
Maybe that
e != NULL);
> +
> +g_source_set_callback(timer->source, timer_func, timer, NULL);
> +
> +g_source_attach(timer->source, timer->context);
> +}
> +
> +static void timer_remove(SpiceTimer *timer)
> +{
> +timer_cancel(timer);
> + spice_asse
Hey Fabian,
On Mon, Feb 01, 2016 at 10:37:54AM +0100, Fabian Grünbichler wrote:
> Hello,
>
> I noticed a rather strange (IMHO) behavior of spice-gtk regarding SSL
> certificate verification, and am wondering whether this is intentional.
>
> My current test setups looks like this:
> root cert ->
On Mon, Feb 08, 2016 at 07:57:42PM +0200, Yedidyah Bar David wrote:
> From: Sandro Bonazzola
>
> Avoid suffix in iso labeling: release number with the
> full suffix exceeds the maximum length allowed.
What does the full suffix look like in your builds?
The label in the Makefile is ovirt-wgt-$(DI
Hey,
On Tue, Feb 09, 2016 at 10:02:09AM +0100, Fabian Grünbichler wrote:
> Thanks for your feedback! Yes, that sums it up quite nicely. Filed #1305785
> (https://bugzilla.redhat.com/show_bug.cgi?id=1305785), and am available for
> testing if there are any updates.
I've 'moved' this bug to
https:/
On Tue, Feb 09, 2016 at 03:56:42PM +0200, Yedidyah Bar David wrote:
> On Tue, Feb 9, 2016 at 3:44 PM, Christophe Fergeau
> wrote:
> > On Mon, Feb 08, 2016 at 07:57:42PM +0200, Yedidyah Bar David wrote:
> >> From: Sandro Bonazzola
> >>
> >> Avoid suffix i
Rather than relying on a global 'reds' variable, we can pass the needed
instance through the callback user data.
---
server/reds.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 4fba4f1..d7acab5 100644
--- a/server/reds.c
+++ b/server/r
Commit 3a66b75 changed reds_accept_ssl_connection() to expect a RedState
instance when its called, but the core->watch_add() which is calling it
was not changed accordingly. This causes a crash when connecting through
SSL.
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
This causes:
make[4]: Entering directory '/home/teuf/redhat/spice/server'
CC dcc.lo
dcc.c: In function 'dcc_compress_image_jpeg':
dcc.c:852:26: error: variable 'jpeg_in_type' might be clobbered by 'longjmp' or
'vfork' [-Werror=clobbered]
JpegEncoderImageType jpeg_in_type;
On Fri, Feb 12, 2016 at 06:14:06AM -0500, Frediano Ziglio wrote:
> >
> > [NB: this did not go to the ML]
> > On Fri, Feb 12, 2016 at 05:12:57AM -0500, Frediano Ziglio wrote:
> > > >
> > > > This causes:
> > > > make[4]: Entering directory '/home/teuf/redhat/spice/server'
> > > > CC dcc.lo
Hey,
On Wed, Feb 10, 2016 at 06:00:39AM -0500, Frediano Ziglio wrote:
> >
> > Check that cancelling a timer the timer callback is not called.
> >
> > This can happen in latency code (red-channel.c).
> > In red_channel_client_cancel_ping_timer latency timer is cancelled and
> > state is set to PI
Acked-by: Christophe Fergeau
for the series.
Christophe
On Fri, Feb 12, 2016 at 05:15:44PM +, Frediano Ziglio wrote:
> Check that cancelling a timer the timer callback is not called.
>
> This can happen in latency code (red-channel.c).
> In red_channel_client_cancel_ping_t
They are now carried in the appropriate command through
QXLReleaseInfoExt, so we don't need to pass them around explicitly.
---
server/display-channel.c | 12 ++--
server/display-channel.h | 3 ---
server/red-worker.c | 8 +++-
3 files changed, 9 insertions(+), 14 deletions(-)
It's unused.
---
server/dcc-encoders.h | 1 -
server/dcc.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/server/dcc-encoders.h b/server/dcc-encoders.h
index a244c94..1cfc4f7 100644
--- a/server/dcc-encoders.h
+++ b/server/dcc-encoders.h
@@ -156,7 +156,6 @@ struct RedGlzDrawable {
It's only used in a few debug printfs. If we want these stats, we'll
have to find a better way than forcing a dependency on a high-level
class in a lower-level _unref method just to maintain the stats.
---
server/display-channel.c | 8
server/display-channel.h | 1 -
server/red-worker.c
Hey,
Initally, I was trying to make red_drawable_unref() not take a DisplayChannel*
argument so that it's easier to use from code where you have a RedDrawable but
not
a DisplayChannel * handy. While doing this, I realized that if we use
QXLReleaseInfoExt instead of QXLReleaseInfo in red-parse-qxl
Now that the group_id is known to RedCursorCmd, we don't need to store
it separately in CursorItem.
---
server/cursor-channel.c | 10 +++---
server/cursor-channel.h | 3 +--
server/red-worker.c | 4 ++--
3 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/server/cursor-channe
We can now directly get it from RedDrawable.
---
server/dcc.c | 2 +-
server/display-channel.c | 1 -
server/display-channel.h | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/server/dcc.c b/server/dcc.c
index bd25069..abf3c0d 100644
--- a/server/dcc.c
+++ b/server/
Storing a QXLReleaseInfoExt rather than a QXLReleaseInfo in RedDrawable
gives us a place to store group_id for free. Since we are building a
QXLReleaseInfoExt from QXLReleaseInfo and group_id when destroying a
RedDrawable instance, this is a move in the right direction.
---
server/red-parse-qxl.c
Now it no longer needs external state in order to destroy the
RedDrawable instance when needed, so we can remove this from the
prototype.
---
server/dcc-encoders.c| 3 +--
server/display-channel.c | 2 +-
server/red-worker.c | 5 ++---
server/red-worker.h | 4 +---
4 files changed, 5
---
server/dcc-send.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index ab07634..abb9251 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -501,7 +501,7 @@ static void fill_mask(RedChannelClient *rcc,
SpiceMarshaller *m,
This allows to get rid of the DisplayChannel parameter to
red_drawable_unref()
---
server/red-parse-qxl.h | 1 +
server/red-worker.c| 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/server/red-parse-qxl.h b/server/red-parse-qxl.h
index 8f8d459..179d45c 100644
--- a/se
This should allow to avoid moving the group_id separately from the QXL
commands all over the code.
---
server/cursor-channel.c | 5 +
server/display-channel.c | 11 ++-
server/red-parse-qxl.c | 15 ++-
server/red-parse-qxl.h | 8
server/red-worker.c | 1
Since systemd 209, the various systemd helper libraries are gathered in
a single libsystemd, and libsystemd-login is only built when systemd is
built with compat libraries support. Since commit
https://github.com/systemd/systemd/commit/4de282c
"build-sys: drop libsystemd-{id128,daemon,login,journal
On Tue, Mar 01, 2016 at 09:44:39AM +, Frediano Ziglio wrote:
> This prevents incompatibility if users (like old spice-server/spice-gtk)
> are not expected to have this additional restriction.
>
> Signed-off-by: Frediano Ziglio
> ---
> spice/macros.h | 3 ++-
> 1 file changed, 2 insertions(+)
Hey,
On Mon, Feb 29, 2016 at 01:34:32PM -0600, Jonathon Jongsma wrote:
> Frediano and I talked about this last week and basically agreed on renaming
> RedDispatcher to RedQXL. A little more justification for the rename:
>
> There are already a couple other types with Dispatcher in their names:
>
On Tue, Mar 01, 2016 at 02:41:32PM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Mar 01, 2016 at 09:44:39AM +, Frediano Ziglio wrote:
> > > This prevents incompatibility if users (like old spice-server/spice-gtk)
> > > are not expected to have this additional restriction.
> > >
> > > Signed-o
Looks good to me, ACK.
Christophe
On Wed, Mar 02, 2016 at 11:26:05AM +, Frediano Ziglio wrote:
> This prevents incompatibility if users (like old spice-server/spice-gtk)
> are not expected to have this additional restriction.
>
> Signed-off-by: Frediano Ziglio
> ---
> spice/macros.h | 7 ++
Hey,
On Fri, Feb 26, 2016 at 11:53:25PM +, Eric Grammatico wrote:
> Hello There,
>
> I am currently testing spice-html5. I find it very promessing and I'd
> like to give a hand if possible.
>
> I am currently experiencing an irritating issue with key mapping. I
> win to have French keymap im
Hey,
On Wed, Feb 17, 2016 at 01:54:48PM +0330, Hamid Mazrae Mollaie wrote:
> Hi,
> Tank you for replay.
> yes, my mouse and keyboard are usb and redirect to vm... and all pressed
> key sent to vm
> all hotkeys and Ctrl+Alt+F[n] does not work for example. but if i avoid
> from spice-usbredir-redire
On Tue, Feb 23, 2016 at 01:57:59PM -0600, Jonathon Jongsma wrote:
>
> I'm a bit ambivalent about this change. Although it may generate better code,
> I
> think that it makes the code slightly more difficult to read. I'd almost
> prefer
> a #define to the enum solution. But I guess I don't care t
Hey,
On Wed, Feb 10, 2016 at 12:16:59PM +0200, Yedidyah Bar David wrote:
> From: Sandro Bonazzola
>
> Change-Id: I1bc61dbbaa39a6e0d5d5866065d6c12c5af51bf7
> Signed-off-by: Sandro Bonazzola
> ---
> ovirt-guest-tools-iso.spec.in | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
On Wed, Mar 02, 2016 at 04:59:38PM +0200, Yedidyah Bar David wrote:
> On Wed, Mar 2, 2016 at 4:47 PM, Christophe Fergeau
> wrote:
> > Hey,
> >
> > On Wed, Feb 10, 2016 at 12:16:59PM +0200, Yedidyah Bar David wrote:
> >> From: Sand
Acked-by: Christophe Fergeau
On Tue, Mar 01, 2016 at 04:50:45PM +0100, Francois Gouget wrote:
> This replaces the original mjpeg_encoder API with a VideoEncoder base
> class which can be reimplemented by other encoders.
> This also renames the members and enums from mjpeg_*
I believe this was already reviewed separately, in a way it's odd to
store instance data along with vfunc (ie class) data, but why not, makes
more sense this way indeed.
Acked-by: Christophe Fergeau
On Tue, Mar 01, 2016 at 04:50:32PM +0100, Francois Gouget wrote:
> It has the same lif
Hey,
Mostly looks good, a few comments/questions below.
On Tue, Mar 01, 2016 at 04:50:57PM +0100, Francois Gouget wrote:
> This introduces a pared down GStreamer-based video encoder to serve as
> the basis for later enhancements.
> In this form the new encoder supports both regular and sized stre
ACK series.
On Thu, Mar 03, 2016 at 01:58:16AM +0100, Marc-André Lureau wrote:
> The db argument must end with " or \n.
>
> Found thanks to clang scan-build.
>
> Signed-off-by: Marc-André Lureau
> Reported-by: Miroslav Rezanina
> ---
> src/vcard_emul_nss.c | 4
> 1 file changed, 4 insert
On Wed, Mar 02, 2016 at 01:18:41PM -0500, Frediano Ziglio wrote:
> >
> > This patch allows remote-viewer to redirect output/error streams to
> > files.
> > Also if launched from a console program (for instance from the command
> > prompt) you are able to see output from the console where you launc
On Tue, Mar 01, 2016 at 12:42:20PM -0500, Frediano Ziglio wrote:
> > with QXLState an internal structure as well (defined in reds.h), and
> > RedDispatcher/RedQXL is one of the few members of this QXLState
> > structure. Should they be merged?
> >
>
> I think you should check patch 4/5 :)
Ah ind
On Thu, Mar 03, 2016 at 01:50:30PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Fri, Feb 26, 2016 at 6:58 PM, Frediano Ziglio wrote:
> >>
> >> codegen generated code depends on spice-common code (marshaller, messages
> >> etc),
> >> it makes more sense to keep the generator along this. Otherwise a
On Wed, Mar 02, 2016 at 07:46:26PM +0100, Francois Gouget wrote:
> On Wed, 2 Mar 2016, Christophe Fergeau wrote:
> [...]
> > > +if test "x$enable_gstreamer" != "xno"; then
> > > +SPICE_CHECK_GSTREAMER(GSTREAMER_1_0, 1.0, [gstreamer-1.0
> >
Forgot to add
Acked-by: Christophe Fergeau
(with the small fixes you did below).
On Wed, Mar 02, 2016 at 07:46:26PM +0100, Francois Gouget wrote:
> On Wed, 2 Mar 2016, Christophe Fergeau wrote:
> [...]
> > > +if test "x$enable_gstreamer" != "xno"; th
1 - 100 of 6964 matches
Mail list logo
