Re: [Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

2019-03-29 Thread Daniel P . Berrangé
On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote: > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) > will never return. > > Signed-off-by: Christophe Fergeau > --- > common/log.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/common/log.h

Re: [Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

2019-03-29 Thread Daniel P . Berrangé
On Fri, Mar 29, 2019 at 06:57:59AM -0400, Frediano Ziglio wrote: > > On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote: > > > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) > > > will never return. > > > > > > Signed-off-by: Christophe Fergeau > > > --- > >

Re: [Spice-devel] LGPL or GPL for recorder library

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 03:21:09PM +0200, Christophe de Dinechin wrote: > Hi Frediano, > > > We discussed GPL vs LGPL for the recorder library. > > I made a mistake in commit e7df1041176eda88aea6102d1c4ecd9f144321a6 of > the recorder library trying to “renormalize” the headers before submitting

Re: [Spice-devel] [PATCH spice-server] build: do not warn about address-of-packed-member

2019-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2019 at 12:48:55PM +0300, Uri Lublin wrote: > The gcc warning address-of-packed-member is new and on by > default in gcc 9. > > Many of the structures sent over the network are packed > and with unaligned fields. > > This breaks the build -- due to -Werror. > Tell gcc to not warn

Re: [Spice-devel] Spice on WinXPSP3

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 06:39:10AM -0400, Frediano Ziglio wrote: > > Hi, > > I'm trying to start remote-viewer.exe on WES7 WYSE with Windows XP SP3 > > (32bit) and get stuck with and error message "The procedure entry point > > AcquireSRWLockExlusive could not be located in the dynamic link library

Re: [Spice-devel] [PATCH spice-gtk] meson: Bump minimum required meson_version to 0.50

2019-08-28 Thread Daniel P . Berrangé
On Wed, Aug 28, 2019 at 12:23:23PM -0400, Frediano Ziglio wrote: > > > > This will drop the following warning: > > "Project specifies a minimum meson_version '>= 0.49' but uses > > features which were added in newer versions" > > > > Signed-off-by: Snir Sheriber > > Why not 0.51? From repology

Re: [Spice-devel] help debugging: Assertion `!xcb_xlib_threads_sequence_lost' failed.

2020-01-23 Thread Daniel P . Berrangé
On Thu, Jan 23, 2020 at 11:54:50AM -0500, Cole Robinson wrote: > Hi all, > > For the past year+ we have had a steady trickle of virt-manager X11 > threading crashes. This is the f31 bug I've duped all the other ones > too, but there were a handful that were auto closed by Fedora > end-of-life bug

Re: [Spice-devel] help debugging: Assertion `!xcb_xlib_threads_sequence_lost' failed.

2020-01-29 Thread Daniel P . Berrangé
On Wed, Jan 29, 2020 at 04:19:05AM -0500, Frediano Ziglio wrote: > > > > On Thu, Jan 23, 2020 at 11:54:50AM -0500, Cole Robinson wrote: > > > Hi all, > > > > > > For the past year+ we have had a steady trickle of virt-manager X11 > > > threading crashes. This is the f31 bug I've duped all the oth

Re: [Spice-devel] About decisions and reviews

2020-05-12 Thread Daniel P . Berrangé
On Mon, May 11, 2020 at 12:16:24PM +0200, Marc-André Lureau wrote: > Hi, > > About "Move code to C++": > https://gitlab.freedesktop.org/spice/spice/-/merge_requests/62 > > I would like to know how the decision happened. As long as I have been > involved in the Spice project, we had open discussio

Re: [Spice-devel] SPICE: changing the merge rules - a proposal

2020-05-18 Thread Daniel P . Berrangé
On Fri, May 15, 2020 at 07:05:50PM +0200, Francesco Giudici wrote: > Hi, > the community around the SPICE project always tried to follow one > fundamental, implicit rule for accepting code contributions to the project: > every merge request (beside trivial patches) should be reviewed and acked at

Re: [Spice-devel] Identifying and removing potentially divisive language

2020-07-02 Thread Daniel P . Berrangé
On Wed, Jul 01, 2020 at 04:15:07PM +0200, Victor Toso wrote: > Hi, > > On Wed, Jul 01, 2020 at 10:03:10AM +0200, Kevin Pouget wrote: > > Hello SPICE community, > > > > following Chris Wright (Red Hat CTO) blog post on "Making open > > source more inclusive by eradicating problematic language" [1]

Re: [Spice-devel] Identifying and removing potentially divisive language

2020-07-02 Thread Daniel P . Berrangé
On Thu, Jul 02, 2020 at 10:09:24AM -0400, Frediano Ziglio wrote: > > > On Wed, Jul 01, 2020 at 04:15:07PM +0200, Victor Toso wrote: > > > Hi, > > > > > > On Wed, Jul 01, 2020 at 10:03:10AM +0200, Kevin Pouget wrote: > > > > Hello SPICE community, > > > > > > > > following Chris Wright (Red Hat C

Re: [Spice-devel] [PATCH spice-gtk v2 2/4] uri: learn to parse spice+tls:// form

2018-02-16 Thread Daniel P . Berrangé
On Fri, Feb 16, 2018 at 11:13:06AM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > spice:// has a weird scheme encoding, where it can accept both plain > and tls ports with URI query parameters. However, it's not very > convenient nor very common to use (who really want to

Re: [Spice-devel] [PATCH] build: Add autogen.sh convenience script

2018-02-16 Thread Daniel P . Berrangé
On Fri, Feb 16, 2018 at 04:18:19PM +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > autogen.sh | 9 + > 1 file changed, 9 insertions(+) > create mode 100755 autogen.sh > > diff --git a/autogen.sh b/autogen.sh > new f

Re: [Spice-devel] broken spice dependancy

2018-02-21 Thread Daniel P . Berrangé
On Wed, Feb 21, 2018 at 03:17:12AM -0800, Bat Man wrote: > Can you please remove gtk-doc as a mandatory requirment for installing > spice-gtk. The thing is its supporting library. A cool one but support > none the less. NO ONE reads the documentation. Your build system is > antiquated. Please

Re: [Spice-devel] [PATCH] Use scancode instead of keycode names

2018-03-08 Thread Daniel P . Berrangé
On Thu, Mar 08, 2018 at 04:19:03PM +0100, Olivier Fourdan wrote: > When running on Xwayland, the keycode mapping property is not available, > which causes unknown keycode mapping errors and the keyboard doesn't > work. > > Use a known scancode (“XK_Page_Up”) to check against the AT scancode and >

Re: [Spice-devel] [PATCH] Use scancode instead of keycode names

2018-03-08 Thread Daniel P . Berrangé
On Thu, Mar 08, 2018 at 05:22:01PM +0100, Olivier Fourdan wrote: > Hi, > > On Thu, Mar 8, 2018 at 4:27 PM, Daniel P. Berrangé > wrote: > > > On Thu, Mar 08, 2018 at 04:19:03PM +0100, Olivier Fourdan wrote: > > > When running on Xwayland, the keycode map

Re: [Spice-devel] [PATCH v2] Use scancode instead of keycode names

2018-03-12 Thread Daniel P . Berrangé
, "xfree86")) { > + } else if ((keycodes && STRPREFIX(keycodes, "xfree86")) || > +(XKeysymToKeycode(xdisplay, XK_Page_Up) == 0x63)) { > VNC_DEBUG("Using xfree86 keycode mapping"); >

Re: [Spice-devel] [PATCH RFC] Support for building with Meson

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 11:51:41AM +0100, Christophe de Dinechin wrote: > Hi Eduardo, > > > Thanks for sharing. > > Out of curiosity, I understand why you want to add Meson, but why remove > autotools right away? Note in particular that this will make it impossible to build on a RHEL-7 platfor

Re: [Spice-devel] [PATCH spice-streaming-agent 1/1] rename the virtio port to com.redhat.spice.stream.0

2018-03-23 Thread Daniel P . Berrangé
On Fri, Mar 23, 2018 at 02:22:23PM +0100, Christophe de Dinechin wrote: > > > > On 23 Mar 2018, at 13:52, Lukáš Hrázký wrote: > > > > On Fri, 2018-03-23 at 13:41 +0100, Christophe de Dinechin wrote: > >>> On 23 Mar 2018, at 13:36, Lukáš Hrázký wrote: > >>> > >>> On Fri, 2018-03-23 at 12:00 +0

Re: [Spice-devel] [virt-viewer PATCH] maint: Drop autobuild.sh

2018-05-04 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 05:48:59PM +0200, Andrea Bolognani wrote: > The Test-AutoBuild project, that this script is supposed > to be used with, hasn't seen any activity in ~7 years; > these days, virt-viewer CI builds are happening on the > Jenkins-based CentOS CI environment under the libvirt > um

Re: [Spice-devel] [spice-space-pages] Update git repos and links

2018-05-10 Thread Daniel P . Berrangé
On Thu, May 10, 2018 at 03:48:14PM +0300, Snir Sheriber wrote: > Most of spice related git repositories are now hosted on > gitlab.freedesktop.org/spice > --- > .gitlab-ci.yml | 4 ++-- > developers.rst | 2 +- > download.rst| 26 +- > osx-client.rst | 4 ++-- > s

Re: [Spice-devel] Flatpaking virt-viewer/remote-viewer

2018-05-14 Thread Daniel P . Berrangé
On Sun, May 13, 2018 at 05:23:12PM -0400, Adrian Lucrèce Céleste wrote: > I thought it'd be polite to notify upstream that I've been working on a > flatpak for virt-viewer/remote-viewer. > My progress can be found here: > https://github.com/adriankoshka/flathub/tree/org.virt_manager.virt-viewer >

Re: [Spice-devel] Flatpaking virt-viewer/remote-viewer

2018-05-16 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 10:27:32PM -0400, Adrian Lucrèce Céleste wrote: > I've hit a bit of a snag with virt-viewer. I've got it compiled, running, > but whenever I try to connect to a remote instance, I always get this: > > > [alc@xps org.virt_manager.virt-viewer]$ flatpak run > org.virt_manager

Re: [Spice-devel] [spice-streaming-agent PATCH] spec: only build rpms for x86_64 arch

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 08:19:26PM +0300, Uri Lublin wrote: > We never test on other architectures. > > Signed-off-by: Uri Lublin > --- > spice-streaming-agent.spec.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in > inde

Re: [Spice-devel] [PATCH spice-common] meson: Do not define -DGLIB_VERSION_MAX_ALLOWED

2018-07-06 Thread Daniel P . Berrangé
On Fri, Jul 06, 2018 at 05:33:45PM +0200, Christophe Fergeau wrote: > Ok, g_abort() is only available in 2.50, and only the meson build uses > GLIB_VERSION_MAX_ALLOWED. However, since this can be useful, I'd prefer > that we keep GLIB_VERSION_MAX_ALLOWED, and add it to the autotools > build. This s

Re: [Spice-devel] [spice-gtk v2] usb-device-manager: Set UsbDk backend on libusb 1.0.22

2018-08-07 Thread Daniel P . Berrangé
On Tue, Aug 07, 2018 at 06:25:05AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Tue, Aug 07, 2018 at 06:02:41AM -0400, Frediano Ziglio wrote: > > > > > > > > From: 王凡 > > > > > > > > In libusb 1.0.21, UsbDk is enabled at compile time with --enable-usbdk > > > > option. In libusb 1.0.22

Re: [Spice-devel] [PATCH spice-gtk] spice-widget: Make sure we can use X11 from different thread

2018-11-27 Thread Daniel P . Berrangé
On Mon, Nov 26, 2018 at 09:37:31AM -0500, Frediano Ziglio wrote: > > On Mon, Nov 26, 2018 at 06:27:48AM -0500, Frediano Ziglio wrote: > > > > > > > > Hi, > > > > > > > > On 11/26/18 10:16 AM, Frediano Ziglio wrote: > > > > > In order to support GStreamer overlay this is necessary as some > > > >

Re: [Spice-devel] [PATCH spice-gtk] spice-widget: Make sure we can use X11 from different thread

2018-11-28 Thread Daniel P . Berrangé
On Tue, Nov 27, 2018 at 06:18:21AM -0500, Frediano Ziglio wrote: > > > > On Mon, Nov 26, 2018 at 09:37:31AM -0500, Frediano Ziglio wrote: > > > > On Mon, Nov 26, 2018 at 06:27:48AM -0500, Frediano Ziglio wrote: > > > > > > > > > > > > Hi, > > > > > > > > > > > > On 11/26/18 10:16 AM, Frediano Zi

Re: [Spice-devel] [PATCH spice-server] tests/pki: Use CA/certificate valid until 2048 and with 2048 bits

2018-12-06 Thread Daniel P . Berrangé
On Thu, Dec 06, 2018 at 04:35:56PM +0100, Christophe Fergeau wrote: > On Tue, Dec 04, 2018 at 01:19:31PM +, Frediano Ziglio wrote: > > This changes tests/pki/server-cert.pem and tests/pki/ca-cert.pem to have > > 2048 bits. These certificates were generated using the > > instructions on https://

Re: [Spice-devel] [PATCH spice] reds: don't unlink existing UNIX socket

2018-12-20 Thread Daniel P . Berrangé
On Thu, Dec 20, 2018 at 05:37:40PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since "reds: add Unix socket support" (commit > 5365caeaae537f564d160936e60f71b2dc964ad1), the Spice server will > remove existing socket before binding. > > Although it may seem handy at f

Re: [Spice-devel] [PATCH spice] reds: don't unlink existing UNIX socket

2018-12-20 Thread Daniel P . Berrangé
On Thu, Dec 20, 2018 at 06:58:34PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Dec 20, 2018 at 5:44 PM Daniel P. Berrangé > wrote: > > > > On Thu, Dec 20, 2018 at 05:37:40PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > &g

Re: [Spice-devel] [PATCH] spec: call semanage in posttrans not in post

2019-01-29 Thread Daniel P . Berrangé
On Tue, Jan 29, 2019 at 06:40:32PM +0200, Uri Lublin wrote: > It can happen that selinux-policy (targeted) is installed only after > spice-streaming-agent (upon system installation). In that case > running semanage in post scriptlet will fail. > > In posttrans all packages are already installed, s

Re: [Spice-devel] [PATCH] spec: call semanage in posttrans not in post

2019-01-30 Thread Daniel P . Berrangé
On Wed, Jan 30, 2019 at 04:05:27AM -0500, Frediano Ziglio wrote: > > On Tue, Jan 29, 2019 at 06:40:32PM +0200, Uri Lublin wrote: > > > It can happen that selinux-policy (targeted) is installed only after > > > spice-streaming-agent (upon system installation). In that case > > > running semanage in

Re: [Spice-devel] [PATCH] spec: call semanage in posttrans not in post

2019-01-31 Thread Daniel P . Berrangé
On Thu, Jan 31, 2019 at 10:05:58AM -0500, Frediano Ziglio wrote: > > On Wed, Jan 30, 2019 at 04:05:27AM -0500, Frediano Ziglio wrote: > > > > On Tue, Jan 29, 2019 at 06:40:32PM +0200, Uri Lublin wrote: > > > > > It can happen that selinux-policy (targeted) is installed only after > > > > > spice-st

[Spice-devel] Bug tracker links outdated

2019-03-22 Thread Daniel P . Berrangé
On this page: https://www.spice-space.org/support.html It points to bugzilla for bugs, but spice doesn't exist there anymore. It needs updating to point to gitlab i presume. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.o

Re: [Spice-devel] [PATCH spice-protocol 1/3] Add a .gitpublish

2019-03-22 Thread Daniel P . Berrangé
On Fri, Mar 22, 2019 at 02:56:46PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Set a default profile for git-publish. > (https://github.com/stefanha/git-publish) > > Signed-off-by: Marc-André Lureau > --- > .gitpublish | 4 > 1 file changed, 4 insertions(+) >

Re: [Spice-devel] Qemu with Spice support on Windows10 host: a report

2021-03-24 Thread Daniel P . Berrangé
On Tue, Mar 23, 2021 at 09:27:31PM +0100, Helge Konetzka wrote: > Sadly problems occur after adding more spice with: > "-device virtio-serial-pci -device > virtserialport,chardev=spicechannel0,name=com.redhat.spice.0 -chardev > spicevmc,id=spicechannel0,name=vdagent" > qemu starts logging warnings

Re: [Spice-devel] Fedora 34 guests can no longer paste from host

2021-04-20 Thread Daniel P . Berrangé
On Tue, Apr 20, 2021 at 11:56:23AM +0200, Germano Massullo wrote: > Good day, I always used with success a Fedora 33 KDE host > (qemu/kvm/libvirt+virt-manager) and a F33 KDE guest, and I have always been > to copy paste from host to guest and viceversa > > Now I tested two Fedora 34 Beta guests:

Re: [Spice-devel] Fedora 34 guests can no longer paste from host

2021-04-20 Thread Daniel P . Berrangé
On Tue, Apr 20, 2021 at 02:49:38PM +0200, Germano Massullo wrote: > Il 20/04/21 13:35, Daniel P. Berrangé ha scritto: > > On Tue, Apr 20, 2021 at 11:56:23AM +0200, Germano Massullo wrote: > >> Good day, I always used with success a Fedora 33 KDE host > >> (qemu/kvm/libv

Re: [Spice-devel] Fedora 34 guests can no longer paste from host

2021-04-20 Thread Daniel P . Berrangé
On Tue, Apr 20, 2021 at 03:08:48PM +0200, Germano Massullo wrote: > https://germano.fedorapeople.org/bugreport/spice/spice_vda_fedora34kde.txt > https://germano.fedorapeople.org/bugreport/spice/spice_vda_fedora34gnome.txt In one case the service is not running at all, and in the other case it appe

Re: [Spice-devel] Has SPICE devlopment stopped?

2021-09-10 Thread Daniel P . Berrangé
On Thu, Sep 09, 2021 at 05:20:48PM +0200, inso...@web.de wrote: >Hi, >  >as stated in [1] SPICE has become deprecated in RHEL. Because it seems >that SPICE was mainly devloped by Red Hat I wanted to ask if this means >that the development has stopped. The link you referenced is

Re: [Spice-devel] How to mount webdav inside QEMU

2022-01-18 Thread Daniel P . Berrangé
On Tue, Jan 18, 2022 at 01:11:04AM +0600, Ahmad Ismail wrote: > I run the VM using > > qemu-system-x86_64 -accel kvm,thread=multi -cpu host -smp 2 -m 4096 > -drive file=mint20.3.qcow2,if=virtio \ > -machine vmport=off \ > -vga qxl -usb -device usb-tablet \ > -spice port=5900,addr=127.0.0.1,disable

Re: [Spice-devel] 回复: Re: 回复: Re: 回复: Re: 回复: Re: [PATCH v1 1/2] drm/qxl: replace ioremap by ioremap_cache on arm64

2022-03-24 Thread Daniel P . Berrangé
On Thu, Mar 24, 2022 at 02:21:09PM +0100, Gerd Hoffmann wrote: > On Thu, Mar 24, 2022 at 06:34:02PM +0800, liuco...@kylinos.cn wrote: > >ok, thanks, a lot of our customer use qxl on x86 before, so it still need > >to supoort qxl on arm64. > > Well, qxl isn't the best choice even on x86. T