[Spice-devel] python bindings documentation/sample

2013-11-19 Thread Michal Suchanek
Hello, I installed the python bindings library but I don't see any documentation/sample. I can connect to the server using the python SSL library and the connection appears to work but I don't know how to create a spice session. The Spice GTK C documentation suggests to instantiate SpiceSession

[Spice-devel] building spice-gtk fails

2013-11-19 Thread Michal Suchanek
Hello, I tried to build spice-gtk but I get an error about demarshaller without any error message. The README says to install vala but even with vala installed and enabled the file is not generated. Any idea what might be wrong? Thanks Michal

Re: [Spice-devel] building spice-gtk fails

2013-11-19 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Tue Nov 19 18:23:22 +0100 2013: On Tue, Nov 19, 2013 at 06:19:23PM +0100, Michal Suchanek wrote: Hello, I tried to build spice-gtk but I get an error about demarshaller without any error message. The README says to install vala but even

[Spice-devel] vdagent service is not running

2015-05-06 Thread Michal Suchanek
Hello, I installed the spice guest tools on Windows 7 - the exe installer from spice-space.org. The vdagent service is not running. When I start it it stops. How do I debug this? Thanks Michal ___ Spice-devel mailing list

Re: [Spice-devel] vdagent service is not running

2015-05-06 Thread Michal Suchanek
Excerpts from Victor Toso's message of Wed May 06 13:47:12 +0200 2015: Hi, On Wed, May 06, 2015 at 01:13:24PM +0200, Michal Suchanek wrote: Hello, it appears I have no virtio serial port. Where would that connect, anyway? I am running kvm. The only serial port I have has

Re: [Spice-devel] vdagent service is not running

2015-05-06 Thread Michal Suchanek
if virtio-serial driver is installed and working. vdservice exits when it can't open the spice virtio port. David On St, 2015-05-06 at 12:03 +0200, Michal Suchanek wrote: Hello, I installed the spice guest tools on Windows 7 - the exe installer from spice-space.org. The vdagent

[Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-06-29 Thread Michal Suchanek
the error from ACL helper to the user seems like the best thing we can do. Signed-off-by: Michal Suchanek hramr...@gmail.com --- spice-common | 2 +- src/channel-usbredir.c | 30 ++ 2 files changed, 15 insertions(+), 17 deletions(-) diff --git a/spice-common b

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-06-29 Thread Michal Suchanek
. Hey, On Mon, Jun 29, 2015 at 03:46:56PM +0200, Michal Suchanek wrote: This basically reverts 63c8526c699692b6fdca15db8209730fca7eb817 After this change opening the device node is not tried at all. Imo this is what should be fixed So when user has access to the device node

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-06-29 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Mon Jun 29 17:01:23 +0200 2015: On Mon, Jun 29, 2015 at 04:52:31PM +0200, Suchánek Michal wrote: Or the other way around compiling in policykit support *should not disable* access to already accessible devices. We agree on that, and the log of

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-06-29 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Mon Jun 29 17:22:23 +0200 2015: On Mon, Jun 29, 2015 at 05:11:36PM +0200, Michal Suchanek wrote: Excerpts from Christophe Fergeau's message of Mon Jun 29 17:01:23 +0200 2015: On Mon, Jun 29, 2015 at 04:52:31PM +0200, Suchánek Michal wrote

[Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-06-29 Thread Michal Suchanek
When calling ACL helper fails also try to open the device node directly. Otherwise user-accessible device nodes are rejected when policykit support is compiled in and policy is not set up when in fact the device could be accessed. Signed-off-by: Michal Suchanek hramr...@gmail.com --- src

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-06-30 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Tue Jun 30 09:30:42 +0200 2015: On Mon, Jun 29, 2015 at 06:59:26PM +0200, Michal Suchanek wrote: Excerpts from Christophe Fergeau's message of Mon Jun 29 17:22:23 +0200 2015: On Mon, Jun 29, 2015 at 05:11:36PM +0200, Michal Suchanek wrote

Re: [Spice-devel] [PATCH v4] usbredir: fix redirection of user-accesible device nodes.

2015-07-31 Thread Michal Suchanek
Hello, Excerpts from Michal Suchanek's message of Mon Jul 20 19:10:20 +0200 2015: Excerpts from Hans de Goede's message of Mon Jul 20 17:46:41 +0200 2015: Hi, On 20-07-15 11:51, Christophe Fergeau wrote: Hey, Looks good te me now. Hans, would you mind taking a quick look at

[Spice-devel] [PATCH v4] usbredir: fix redirection of user-accesible device nodes.

2015-07-15 Thread Michal Suchanek
When calling ACL helper fails also try to open the device node directly. Otherwise user-accessible device nodes are rejected when policykit support is compiled in and policy is not set up when in fact the device could be accessed. Signed-off-by: Michal Suchanek hramr...@gmail.com -- v2

Re: [Spice-devel] [PATCH v4] usbredir: fix redirection of user-accesible device nodes.

2015-07-20 Thread Michal Suchanek
Excerpts from Hans de Goede's message of Mon Jul 20 17:46:41 +0200 2015: Hi, On 20-07-15 11:51, Christophe Fergeau wrote: Hey, Looks good te me now. Hans, would you mind taking a quick look at that patch in case you have objections on the change (if

[Spice-devel] [PATCH v3] usbredir: fix redirection of user-accesible device nodes.

2015-07-10 Thread Michal Suchanek
When calling ACL helper fails also try to open the device node directly. Otherwise user-accessible device nodes are rejected when policykit support is compiled in and policy is not set up when in fact the device could be accessed. Signed-off-by: Michal Suchanek hramr...@gmail.com -- v2

Re: [Spice-devel] [PATCH V2] usbredir: fix redirection of user-accesible device nodes.

2015-07-10 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Thu Jul 09 17:11:45 +0200 2015: On Thu, Jul 09, 2015 at 04:58:52PM +0200, Michal Suchanek wrote: Excerpts from Christophe Fergeau's message of Thu Jul 09 16:41:58 +0200 2015: On Thu, Jul 09, 2015 at 03:25:19PM +0100, Michal Suchanek wrote

Re: [Spice-devel] [PATCH V2] usbredir: fix redirection of user-accesible device nodes.

2015-07-10 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Fri Jul 10 10:23:33 +0200 2015: On Fri, Jul 10, 2015 at 10:18:15AM +0200, Michal Suchanek wrote: Excerpts from Christophe Fergeau's message of Thu Jul 09 17:11:45 +0200 2015: On Thu, Jul 09, 2015 at 04:58:52PM +0200, Michal Suchanek wrote

Re: [Spice-devel] [PATCH V2] usbredir: fix redirection of user-accesible device nodes.

2015-07-10 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Fri Jul 10 13:49:28 +0200 2015: On Fri, Jul 10, 2015 at 01:33:41PM +0200, Michal Suchanek wrote: Excerpts from Christophe Fergeau's message of Fri Jul 10 10:23:33 +0200 2015: On Fri, Jul 10, 2015 at 10:18:15AM +0200, Michal Suchanek wrote

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Thu Jul 09 13:47:51 +0200 2015: On Mon, Jun 29, 2015 at 03:46:56PM +0200, Michal Suchanek wrote: When calling ACL helper fails also try to open the device node directly. Otherwise user-accessible device nodes are rejected when policykit

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Michal Suchanek
device nodes are rejected when policykit support is compiled in and policy is not set up when in fact the device could be accessed. Signed-off-by: Michal Suchanek hramr...@gmail.com --- src/channel-usbredir.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff

[Spice-devel] [PATCH V2] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Michal Suchanek
When calling ACL helper fails also try to open the device node directly. Otherwise user-accessible device nodes are rejected when policykit support is compiled in and policy is not set up when in fact the device could be accessed. Signed-off-by: Michal Suchanek hramr...@gmail.com -- v2

Re: [Spice-devel] [RFC PATCH] [linux-vdagent] Lock screen on disconnect

2015-09-23 Thread Michal Suchanek
Hello, On Wed, Sep 23, 2015 at 10:05:40AM -0400, David Mansfield wrote: > Hi, > > The attached is a very simple patch, which is working but possibly not > suitable for inclusion at this point, that locks the x11 session when the > client disconnects. > > Locking is performed using

[Spice-devel] [PATCH v6 2/5] udscs: don't pass message type strings into the server.

2017-01-23 Thread Michal Suchanek
NULLs at the end. Signed-off-by: Michal Suchanek <msucha...@suse.de> --- src/udscs.c | 23 +++ src/udscs.h | 4 ++-- src/vdagent/vdagent.c| 1 - src/vdagentd-proto-strings.h | 3 ++- src/vdagentd/vdagentd.c | 1 - 5

[Spice-devel] [PATCH v6 3/5] Move mouse-specific handling out of virtio_port_read_complete

2017-01-23 Thread Michal Suchanek
Move some mouse-specific code from the start of virtio_port_read_complete to a separate helper as is the case with other message types. Signed-off-by: Michal Suchanek <msucha...@suse.de> --- src/vdagentd/vdagentd.c | 43 --- 1 file changed, 24 inse

[Spice-devel] [PATCH v6 1/5] Quiet uninitialized variable warning.

2017-01-23 Thread Michal Suchanek
Signed-off-by: Michal Suchanek <msucha...@suse.de> --- v2: - use g_return_if_reached --- src/vdagentd/vdagentd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c index a1faf23..e2d6159 100644 --- a/src/vdagentd/vdagentd.c +++ b/src/vd

[Spice-devel] [PATCH v6 5/5] Do endian swapping.

2017-01-23 Thread Michal Suchanek
tive endian. With muliple layers of headers this is a bit tricky. A few message types have to be swapped fully before passing through vdagentd. Signed-off-by: Michal Suchanek <msucha...@suse.de> Signed-off-by: Victor Toso <m...@victortoso.com> --- v2: - introduce helper functions to

[Spice-devel] [PATCH v6 0/5] Endian swapping and misc cleanup patches

2017-01-23 Thread Michal Suchanek
n swapping patch. Thanks Michal Michal Suchanek (4): Quiet uninitialized variable warning. udscs: don't pass message type strings into the server. Move mouse-specific handling out of virtio_port_read_complete Do endian swapping. Victor Toso (1): vdagentd: early return on bad message

[Spice-devel] [PATCH v6 4/5] vdagentd: early return on bad message size

2017-01-23 Thread Michal Suchanek
check on virtio_port_read_complete(). Signed-off-by: Victor Toso <victort...@redhat.com> Signed-off-by: Michal Suchanek <msucha...@suse.de> --- v6 - bring back the proper size check for clipboard messages - sort messages to fixed and variable length and check size accordingly - size the vdagen

[Spice-devel] [PATCH v7 1/3] vdagentd: Quiet uninitialized variable warning.

2017-01-27 Thread Michal Suchanek
led in the switch. Signed-off-by: Michal Suchanek <msucha...@suse.de> --- v2: - use g_return_if_reached v7: - reword --- src/vdagentd/vdagentd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c index e934f3f..5ca0106 100644 --- a/src/vdagentd/v

[Spice-devel] [PATCH v7 2/3] vdagentd: early return on bad message size

2017-01-27 Thread Michal Suchanek
buffer. On the other hand, some fixed size messages were checked only for being too short and not for extra garbage. Signed-off-by: Victor Toso <victort...@redhat.com> Signed-off-by: Michal Suchanek <msucha...@suse.de> --- v6 - bring back the proper size check for clipboard messages - sort

[Spice-devel] [PATCH v7 3/3] vdagentd: Do endian swapping.

2017-01-27 Thread Michal Suchanek
tive endian. With muliple layers of headers this is a bit tricky. A few message types have to be swapped fully before passing through vdagentd. Signed-off-by: Michal Suchanek <msucha...@suse.de> Signed-off-by: Victor Toso <m...@victortoso.com> --- v2: - introduce helper functions to

[Spice-devel] [PATCH] Move mouse-specific handling out of virtio_port_read_complete

2017-01-19 Thread Michal Suchanek
Move some mouse-specific code from the start of virtio_port_read_complete to a separate helper as is the case with other message types. Signed-off-by: Michal Suchanek <msucha...@suse.de> --- src/vdagentd/vdagentd.c | 43 --- 1 file changed, 24 inse

[Spice-devel] [PATCH] Do endian swapping.

2016-11-28 Thread Michal Suchanek
. With muliple layers of headers this is a bit tricky. A few message types have to be swapped fully before passing through vdagentd. Signed-off-by: Michal Suchanek <msucha...@suse.de> --- src/vdagentd/uinput.c | 4 +++ src/vdagentd/vdagentd.c

[Spice-devel] [PATCH v2 1/2] Do endian swapping.

2017-01-06 Thread Michal Suchanek
tive endian. With muliple layers of headers this is a bit tricky. A few message types have to be swapped fully before passing through vdagentd. Signed-off-by: Michal Suchanek <msucha...@suse.de> --- v2: - introduce helper functions to swap (a portion of) a message wholesale - pollute fe

[Spice-devel] [PATCH v2 2/2] Quiet uninitialized variable warning.

2017-01-06 Thread Michal Suchanek
Signed-off-by: Michal Suchanek <msucha...@suse.de> --- src/vdagentd/vdagentd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c index 991514e..60a866e 100644 --- a/src/vdagentd/vdagentd.c +++ b/src/vdagentd/vdagentd.c @@ -334,6 +334,7 @@

[Spice-devel] [PATCH v3 2/2] Quiet uninitialized variable warning.

2017-01-09 Thread Michal Suchanek
Signed-off-by: Michal Suchanek <msucha...@suse.de> --- src/vdagentd/vdagentd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c index 4cac473..f759b4c 100644 --- a/src/vdagentd/vdagentd.c +++ b/src/vdagentd/vdagentd.c @@ -334,6 +334,7 @@

[Spice-devel] [PATCH v3 1/2] Do endian swapping.

2017-01-09 Thread Michal Suchanek
tive endian. With muliple layers of headers this is a bit tricky. A few message types have to be swapped fully before passing through vdagentd. Signed-off-by: Michal Suchanek <msucha...@suse.de> --- v2: - introduce helper functions to swap (a portion of) a message wholesale - pollute fe