---
tests/util.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/util.c b/tests/util.c
index e090f5c..b9b9535 100644
--- a/tests/util.c
+++ b/tests/util.c
@@ -36,7 +36,7 @@ static void test_dos2unix(void)
{
GError *err = NULL;
gchar *tmp;
-int
https://bugzilla.redhat.com/show_bug.cgi?id=1140512
When a file transfer starts / finishes an information message is printed (in
INFO log level)
---
gtk/channel-main.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index
When a file transfer starts / finishes an information message is printed (in
INFO log level).
Also INFO messages about the transfer progress are printed.
---
gtk/channel-main.c | 23 +++
gtk/spice-widget.c | 44 ++--
2 files changed,
Hi,
Thanks for the review. I made changes according to your suggestions. Also all
the logging is now placed just in 'gtk/spice-widget.c'.
Pavel
---
gtk/spice-widget.c | 70 --
1 file changed, 68 insertions(+), 2 deletions(-)
diff --git
When a file transfer starts / finishes an information message is printed (in
INFO log level).
Also INFO messages about the transfer progress are printed.
---
changes since v3:
- all the logging is now placed just in 'gtk/spice-widget.c'
gtk/spice-widget.c | 70
Hi,
I didn't get exactly why you're logging only when the user transfers
just one file.
the method spice_main_file_copy_async() is limited to copy just one file.
Pavel
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
The cursor is grabbed/ungrabbed automatically by spice-gtk,
this patch allows releasing the cursor in the client mouse mode
with a keyboard shortcut.
---
gtk/spice-widget-priv.h | 1 +
gtk/spice-widget.c | 57 ++---
2 files changed, 36
NACK, it's causing problems on vm shutdown
- Original Message -
From: Pavel Grunt pgr...@redhat.com
To: spice-devel@lists.freedesktop.org
Cc: Pavel Grunt pgr...@redhat.com
Sent: Thursday, October 2, 2014 8:12:49 AM
Subject: [Spice-devel][spice-gtk PATCH] Ability to release the cursor
Thanks for the review.
I used info level because it was requested in
https://bugzilla.redhat.com/show_bug.cgi?id=1140512#c0
- Original Message -
When a file transfer starts / finishes an information message is
printed (in
INFO log level).
Also INFO messages about the transfer
The cursor is grabbed/ungrabbed automatically by spice-gtk,
this patch allows releasing the cursor in the client mouse mode
with a keyboard shortcut.
---
v2:
- fix crash on vm shutdown
gtk/spice-widget-priv.h | 1 +
gtk/spice-widget.c | 68 +
Hi,
I don't know why it is possible to release the cursor in the server mouse mode
and not in the client mouse mode.
Also it can help with issues related to
https://bugzilla.redhat.com/show_bug.cgi?id=1121446
- Original Message -
Hi,
- Original Message -
The cursor is
On Thu, Oct 9, 2014 at 12:35 PM, Pavel Grunt pgr...@redhat.com
wrote:
I don't know why it is possible to release the cursor in the server
mouse mode and not in the client mouse mode.
iirc, only the keyboard should be grabbed in client mode.
Sorry to ask again, please describe
Hi,
yes, it ungrabs both the keyboard and the pointer.
I was inaccurate in the commit log.
Pavel
- Original Message -
Hey,
On Thu, Oct 09, 2014 at 08:52:21AM -0400, Pavel Grunt wrote:
Hi,
I don't have any issues. I was just thinking that it can be useful
to
avoid
Message will be used by client for requesting an information about
a version of the agent running on the guest side.
---
The intention is to show this information in virt-viewer
---
spice/vd_agent.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/spice/vd_agent.h
The agent will send an information about its version to the client.
---
depends on
http://lists.freedesktop.org/archives/spice-devel/2014-October/017654.html
---
src/vdagentd.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/vdagentd.c b/src/vdagentd.c
index
The agent will send an information about its version to the client.
---
depends on
http://lists.freedesktop.org/archives/spice-devel/2014-October/017654.html
---
vdagent/vdagent.cpp | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git
---
gtk/spice-session-priv.h | 4
gtk/spice-session.c | 47 ++-
2 files changed, 50 insertions(+), 1 deletion(-)
diff --git a/gtk/spice-session-priv.h b/gtk/spice-session-priv.h
index da43866..70cd5ce 100644
--- a/gtk/spice-session-priv.h
The client will ask the agent for its version and save the agent's answer
in the agent-version property of SpiceSession
---
depends on
http://lists.freedesktop.org/archives/spice-devel/2014-October/017654.html
and on
http://lists.freedesktop.org/archives/spice-devel/2014-October/017655.html
or
Hi,
I wanted to show information about the agent in the Guest Details dialog of
virt-viewer ( http://people.freedesktop.org/~pgrunt/guest_details.png ).
The information about other components (qxl driver, spice server) may also be
displayed there as well.
I think this can be useful for a user
Message will be used by client for requesting an information about
a version of the agent running on the guest side.
---
v2:
- removed 'type' field from VDAgentInformation
- VD_AGENT_INFORMATION changed to VD_AGENT_GUEST_VERSION
VDAgentInformation changed to VDAgentGuestVersion
- added
The agent will send an information about its version to the client
when VD_AGENT_CAP_GUEST_VERSION is set.
---
depends on
http://lists.freedesktop.org/archives/spice-devel/2014-October/017669.html
---
vdagent/vdagent.cpp | 41 -
1 file changed, 40
The agent will send an information about its version to the client
when VD_AGENT_CAP_GUEST_VERSION is set.
---
depends on
http://lists.freedesktop.org/archives/spice-devel/2014-October/017669.html
---
src/vdagentd.c | 16
1 file changed, 16 insertions(+)
diff --git
Please detail how that would help: to me it is introducing an agent
message subtype, and I don't see the need, you can simply use the
agent message type (which is already a subtype of spice main
messages)
I wanted to use the type field to determine the type of information of the
text
The message will be used for transferring the keyboard layout
from the client to the guest. When the agent receives this message,
it tries to set the specified keyboard layout.
https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
VDAgentMessage will be used for the transfer, the type of the
- Original Message -
The message will be used for transferring the keyboard layout
from the client to the guest. When the agent receives this message,
it tries to set the specified keyboard layout.
https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
VDAgentMessage will
The message will be used for transferring the keyboard layout
from the client to the guest. When the agent receives this message,
it tries to set the specified keyboard layout.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
v2:
- the message is a string which is based on xkb symbols
This commit introduces a function for changing the keyboard
layout on the guest side.
---
configure.ac | 2 ++
src/vdagent-x11.c | 15 +++
src/vdagent-x11.h | 3 +++
3 files changed, 20 insertions(+)
diff --git a/configure.ac b/configure.ac
index 79905a8..a5916d1 100644
---
The agent tries to set the appropriate keyboard layout
when the message is received.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
depends on
http://lists.freedesktop.org/archives/spice-devel/2014-November/017821.html
---
src/vdagent.c| 4
This commit introduces function for sending the message to the agent.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
depends on:
http://lists.freedesktop.org/archives/spice-devel/2014-November/017821.html
---
gtk/channel-main.c | 32
The keyboard description of the client will be sent to the guest
when the connection is established.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
gtk/spice-gtk-session-priv.h | 1 +
gtk/spice-gtk-session.c | 72
2 files changed,
Hi,
thanks for the review.
Is it a nul terminated string? ascii only? In which case, no need for
size parameter.
Yes, it is. I will send v2.
Pavel
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
This commit introduces function for sending the message to the agent.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
depends on:
http://lists.freedesktop.org/archives/spice-devel/2014-November/017821.html
v2:
- spice_main_keyboard_description changed to
The keyboard description of the client will be sent to the guest
when the connection is established.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
v2:
- reduced indentation level
- removed checking all the channels
---
gtk/spice-gtk-session-priv.h | 1 +
gtk/spice-gtk-session.c
This commit introduces function for sending the message to the agent.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
depends on:
http://lists.freedesktop.org/archives/spice-devel/2014-November/017821.html
v3:
- added 'Since: 0.27'
- added check for 'data' parameter
- updated
The goal of this message is to make the guest use the same keyboard
layout as the client. In other words to remove the necessity to manually
configure the keyboard layout on the guest.
We can achieve this functionality by informing the agent about
the keyboard layout used by the client. The agent
To let user define the keyboard shortcut for disabling / enabling inputs.
---
gtk/spice-option.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/gtk/spice-option.c b/gtk/spice-option.c
index 958e03c..c028371 100644
--- a/gtk/spice-option.c
+++ b/gtk/spice-option.c
@@ -41,6 +41,7 @@
by using the same keyboard shortcut.
https://bugs.freedesktop.org/show_bug.cgi?id=85331
Pavel Grunt (3):
spice-session: add disable-inputs-sequence property
spice-option: add --spice-disable-inputs-sequence
Check for the disable inputs sequence
gtk/spice-option.c | 5
gtk/spice
Change a value of the disable-inputs property when the sequence is pressed.
---
gtk/spice-widget-priv.h | 2 ++
gtk/spice-widget.c | 66 +++--
2 files changed, 55 insertions(+), 13 deletions(-)
diff --git a/gtk/spice-widget-priv.h
String property defining key sequence for disabling inputs
---
gtk/spice-session-priv.h | 3 +++
gtk/spice-session.c | 45 +
2 files changed, 48 insertions(+)
diff --git a/gtk/spice-session-priv.h b/gtk/spice-session-priv.h
index da43866..60e032e
Hi
- Original Message -
On Fri, Nov 7, 2014 at 3:51 PM, Marc-André Lureau
mlur...@redhat.com wrote:
Hi
- Original Message -
These patches give the user an option to define and use a keyboard
shortcut
for disabling the inputs.
When the inputs are disabled the user
This commit adds the ability to release the keyboard grab when
the release keys (ctrl+alt) are pressed and released. It allows
to use keyboard shortcuts (eg alt+tab, alt+f4) on the client.
The keyboard is grabbed again when the release keys are pressed
and released or when the mouse moves.
This commit adds the ability to release the keyboard grab when
the release keys (ctrl+alt) are pressed and released. It allows
to use keyboard shortcuts (eg alt+tab, alt+f4) on the client.
The keyboard is grabbed again when the release keys are pressed
and released or when the mouse moves.
, Nov 05, 2014 at 03:20:33PM +0100, Pavel Grunt wrote:
The keyboard description of the client will be sent to the guest
when the connection is established.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
v3:
- wrong g_return_val_if_fail replaced by g_warn_if_fail
v2
The keyboard description of the client will be sent to the guest
when the connection is established.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
v4:
- keyboard description for windows clients is based on GetLocaleInfo
instead of parsing g_win32_getlocale
v3:
- wrong
This commit introduces function for sending the message to the agent.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
v4:
- updated spice-glib-sym-file
v3:
- added 'Since: 0.27'
- added check for 'data' parameter
- updated spice-gtk-sections.txt
v2:
-
The property is used to enable sending client's keyboard
description to the guest.
---
gtk/spice-gtk-session.c | 28
1 file changed, 28 insertions(+)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
index 60cf899..d955252 100644
---
This commit introduces a function for changing the keyboard
layout on the guest side.
---
v2:
- check whether the keyboard description string is null-terminated
---
configure.ac | 2 ++
src/vdagent-x11.c | 20
src/vdagent-x11.h | 3 +++
3 files changed, 25
The agent tries to set the appropriate keyboard layout
when the message is received.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
v2:
- use the 'size' parameter in vdagent_x11_set_keyboard_description
---
src/vdagent.c| 4
src/vdagentd-proto-strings.h | 1 +
On Wed, Nov 12, 2014 at 10:11 AM, Pavel Grunt pgr...@redhat.com
wrote:
This commit adds the ability to release the keyboard grab when
the release keys (ctrl+alt) are pressed and released. It allows
to use keyboard shortcuts (eg alt+tab, alt+f4) on the client.
The keyboard
This commit adds the ability to release the keyboard grab when
the release keys (ctrl+alt) are pressed and released. It allows
to use keyboard shortcuts (eg alt+tab, alt+f4) on the client.
The keyboard is grabbed again when the release keys are pressed
and released or when the mouse moves.
Hi,
I can't reproduce it. To make it clear for me, your scenario is: press
ctrl+alt, then alt+tab, then alt+tab back, at this point the keyboard doesn't
have the grab (eg due to a mouse move) and you have to press ctrl+alt two times
to regain it ?
Thank you
Pavel
For some reason, I still
Hi,
I can't reproduce it. To make it clear for me, your scenario is:
press
ctrl+alt, then alt+tab, then alt+tab back, at this point the
keyboard
doesn't have the grab (eg due to a mouse move) and you have to
press
ctrl+alt two times to regain it ?
Exact, I am using
This commit adds the ability to release the keyboard grab when
the release keys (ctrl+alt) are pressed and released. It allows
to use keyboard shortcuts (eg alt+tab, alt+f4) on the client.
The keyboard is grabbed again when the release keys are pressed
and released or when the mouse moves.
In Windows shift key remains stuck when both shift keys are pressed
together. The solution is to release both shift keys when the modifier
for the shift key is not set.
https://bugs.freedesktop.org/show_bug.cgi?id=77259
---
gtk/spice-widget.c | 16
1 file changed, 16
Hey,
I will look into gtk+ code, but I thought it is spice-gtk related
problem because gtk-vnc doesn't hit this issue.
Pavel
- Original Message -
Hey,
Thanks for looking at this bug. It seems it works fine with Linux/X
client, and your patch is win32 specific. So it looks like
Hi,
I wrote a simple test app just for recording key events and I can
confirm that the problem is not in our code. But I am not sure that it is a
gtk+ bug,
because when I run spice.exe using wine, all key events are processed correctly.
It seems to be Windows feature because even Javascript
Hey,
After this patch the authentication dialog for sasl connection does not show up
at all.
Also it is not failing when trying to connect to vnc guest.
Pavel
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
Hi,
It is common that clients attempt to reconnect during the
SPICE_CHANNEL_ERROR_AUTH callback. However, the channel must exit
the coroutine first before reconnection can happen.
---
gtk/spice-channel.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
This patch depends on Fix authentication error handling regression
series.
ACK this and the series
Pavel
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
thanks! ack
thanks, pushed as 4c4d7b20822a8ae916df902dd8218cadfe6f0a17
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Otherwise SpiceDisplay might not get the keyboard grab.
It also silence GSpice-CRITICAL on focus out event:
GSpice-CRITICAL **: spice_gtk_session_request_auto_usbredir: assertion
's-auto_usbredir_reqs 0' failed
---
gtk/spice-widget.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Could you point me to the src for the installer? been meaning to look
into
creating Win 8/12/10 installer for it.
http://www.spice-space.org/download/windows/spice-guest-tools/spice-guest-tools-0.74-src/
___
Spice-devel mailing list
Hi Jeremy,
Hi Pavel,
Mostly looks good; one question:
Shouldn't we go ahead and store the inbound caps?
Well, we have no use for them. I can add the line, if you prefer.
Best regards,
Pavel
___
Spice-devel mailing list
---
filexfer.js | 29 +
main.js | 4
spice.html | 5 +
spice_auto.html | 4
4 files changed, 42 insertions(+)
diff --git a/filexfer.js b/filexfer.js
index 2ba0671..2887e14 100644
--- a/filexfer.js
+++ b/filexfer.js
@@ -24,6 +24,35 @@
---
filexfer.js | 12
main.js | 9 +
2 files changed, 21 insertions(+)
diff --git a/filexfer.js b/filexfer.js
index 2887e14..beabfd8 100644
--- a/filexfer.js
+++ b/filexfer.js
@@ -26,9 +26,20 @@ function SpiceFileXferTask(id, file)
Hi Jeremy,
Hi Pavel,
This looks (mostly) good to me. I'm really troubled by the 2K limit,
and the 5 token window size; that makes transfers painfully slow.
That
is arguably outside the scope of this patch set, though.
In spice-gtk we are also sending 2K agent data messages and it is
---
v2:
- number of agent tokens is set before sending monitor config
---
main.js | 19 +--
spicemsg.js | 15 +++
2 files changed, 32 insertions(+), 2 deletions(-)
diff --git a/main.js b/main.js
index e487551..c71de7a 100644
--- a/main.js
+++ b/main.js
@@ -66,6
---
v2:
- adds missing removeEventListeners
---
filexfer.js | 22 ++
spice.html | 15 +++
spice_auto.html | 15 +++
3 files changed, 52 insertions(+)
diff --git a/filexfer.js b/filexfer.js
index d472240..2ba0671 100644
--- a/filexfer.js
+++
---
main.js | 20 ++--
spicemsg.js | 15 +++
2 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/main.js b/main.js
index e487551..d9c9f75 100644
--- a/main.js
+++ b/main.js
@@ -87,6 +87,8 @@ SpiceMainConn.prototype.process_channel_message =
It is possible to transfer files from the client to the guest
using File API [0] when a spice vd agent is connected.
Methods for the transfer are based on spice-gtk implementation.
[0] http://www.w3.org/TR/file-upload/
---
v3:
- Fixes issues with IE11 by using readAsArrayBuffer instead of
on relevant methods in spice-gtk.
v3: Fixes issues with IE11 by using readAsArrayBuffer instead of
readAsBinaryString
Files are transmitted in bigger chunk size (64 KB instead of 2 KB)
Info message is logged when file is transferred
v2: Files are read only when tokens are available.
Pavel Grunt
Stop reading a file when there are no tokens,
continue reading it when tokens arrive.
---
main.js | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/main.js b/main.js
index 54e6963..d9dced9 100644
--- a/main.js
+++ b/main.js
@@ -58,6 +58,7 @@ function
Messages that were not sent are stored in the queue.
They will be sent later when the client receives more agent tokens.
---
main.js | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/main.js b/main.js
index d9c9f75..d10b594 100644
--- a/main.js
Allowed size for SPICE_MSGC_MAIN_AGENT_DATA message is 2048 Bytes,
larger messages have to be splitted.
---
enums.js | 1 +
main.js | 16 +---
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/enums.js b/enums.js
index fcf27e6..4b678df 100644
--- a/enums.js
+++
The client should inform the agent about capabilities
when the connection is established. This avoid receiving unhandled
agent messages.
---
depends on:
http://lists.freedesktop.org/archives/spice-devel/2015-January/018590.html
Unhandled agent messages are related to the clipboard sharing
We should report that we handle the connected tokens message
by setting the SPICE_MAIN_CAP_AGENT_CONNECTED_TOKENS capability.
---
enums.js | 5 +
spiceconn.js | 4
2 files changed, 9 insertions(+)
diff --git a/enums.js b/enums.js
index d99b38e..fcf27e6 100644
--- a/enums.js
+++
MouseWheelEvent is deprecated and not working in Firefox.
---
display.js | 4 ++--
inputs.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/display.js b/display.js
index 2aa5985..814ada6 100644
--- a/display.js
+++ b/display.js
@@ -691,7 +691,7 @@
Hi,
This series fixes recycling channels on normal disconnect/connect
operations (needed by clients to enable disable sharing folder
dynamically for example).
It also cleans up a bit some code, removing the unnecessary
Channel:channel_disconnect().
Finally, it fixes switch-host code,
From: Daniel P. Berrange berra...@redhat.com
Both Wayland and Xwayland use the evdev + 8 map for keycodes,
just as regular Xorg with evdev does.
This code is copied from gtk-vnc.
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=89105
---
gtk/vncdisplaykeymap.c | 16
1 file
Hi,
Since it is required to prevent automount from racing with auto-usb
redirection, I would say that a warning is ok.
What desktop are you using? If you reach that error, it means there
was a org.gnome.SessionManager.
I tested it in Xfce and KDE. I think there wasn't
It avoids calling D-Bus methods when the bus name
org.gnome.SessionManager does not exist.
GSpice-WARNING **: Error calling 'org.gnome.SessionManager.Inhibit':
GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name
org.gnome.SessionManager was not provided by any .service files
---
The
It avoids calling D-Bus methods when the bus name
org.gnome.SessionManager does not exist.
Silences:
GSpice-WARNING **: Error calling 'org.gnome.SessionManager.Inhibit':
GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name
org.gnome.SessionManager was not provided by any .service
Hi,
Spice-html5 does not support webdav. It is included in spice-gtk since v0.24.
Best regards,
Pavel Grunt
I tried testing the file transfer method of installing this
http://elmarco.fedorapeople.org/spice-webdavd-x86-0.1.24.msi
in a windows 7 guest running on a debian host and it failed
Hi,
Hi John,
John, for Pavel's new code, you would need spice-html5 from the most
recent git tree; there is no release that contains it.
Pavel, let me know if you'd like me to do a release to fix that.
I would wait, the file transfer is the only change since 0.1.5. Of course, it
is
Hi,
Great, thanks. And yeah, IE support is dicey at best. I think the
ideal is that we at least downgrade functionality gracefully, instead
of
failing.
I have been playing with your patches, and they seem to work nicely.
I'll try to comment more formally on the v3 set.
My remaining
Hi Jeremy,
Thank you. You are right about the MediaSource API, spice-html5 in IE11 gets
other errors like Channel type 0 unknown, Channel type 177 unknown and after
that it even kills my VM.
I will try to figure it out.
Best regards,
Pavel
Hi Pavel,
I'm able to run spice-html5 in
Keys should be sent to the guest if the widget has the focus even
when the keyboard grab is released.
---
gtk/spice-widget.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
index 147271c..1f7008a 100644
--- a/gtk/spice-widget.c
+++
Silences the runtime warning in virt-viewer and gnome-boxes (bgo#744432):
Gtk-CRITICAL **: gtk_widget_queue_draw_area: assertion 'width = 0' failed
---
gtk/spice-widget.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
index 1f7008a..f5e8aab 100644
Hi Jeremy,
Thanks a lot for your feedback.
Hi Pavel,
This looks like a great addition; thanks for doing this work.
I've got a few general questions, and then some specific comments on
some of the patches.
General questions: what browsers have you tested this with?
Ostensibly,
Since you're genuinely using this message, shouldn't we now advertise
the connected token CAP?
I am not sure what CAP you mean. We send the SPICE_MSGC_MAIN_AGENT_START
message when the SPICE_MSG_MAIN_AGENT_CONNECTED_TOKENS message is received.
Best regards,
Pavel
+if (msg.type == SPICE_MSG_MAIN_AGENT_DATA)
+{
+var agent_data = new SpiceMsgcMainAgentData(0, msg.data);
This should be a separate type; SpiceMsgMainAgentData, not Msgc.
+SpiceMainConn.prototype.file_xfer_start = function(file)
+{
+var task_id, xfer_start,
As far as I know, the server will only use the conencted_tokens
message
is we report SPICE_MAIN_CAP_AGENT_CONNECTED_TOKENS. But we do not
report that cap (or any main channel caps).
You could readily do it using the same logic that is found in pushing
CAP_OPUS.
Cheers,
Jeremy
It is possible to transfer files from the client to the guest
using File API [0] when a spice vd agent is connected.
Methods for the transfer are based on spice-gtk implementation.
[0] http://www.w3.org/TR/file-upload/
---
v2:
- adds task counter, missing check for the task existence,
methods in spice-gtk.
v2: Files are read only when tokens are available.
Pavel Grunt (5):
Handle agent tokens
Send agent messages only when have agent tokens
Implement methods for transfering files from client to guest
Use drag and drop for transfering files from client to guest
Read file
---
v2:
- adds missing removeEventListeners
---
filexfer.js | 22 ++
spice.html | 15 +++
spice_auto.html | 15 +++
3 files changed, 52 insertions(+)
diff --git a/filexfer.js b/filexfer.js
index d472240..2ba0671 100644
--- a/filexfer.js
+++
---
main.js | 20 ++--
spicemsg.js | 15 +++
2 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/main.js b/main.js
index e487551..d9c9f75 100644
--- a/main.js
+++ b/main.js
@@ -87,6 +87,8 @@ SpiceMainConn.prototype.process_channel_message =
Messages that were not sent are stored in the queue.
They will be sent later when the client receives more agent tokens.
---
main.js | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/main.js b/main.js
index d9c9f75..d10b594 100644
--- a/main.js
Stop reading file when there are no tokens,
continue reading it when tokens arrive.
---
main.js | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/main.js b/main.js
index 5c4a470..7c36342 100644
--- a/main.js
+++ b/main.js
@@ -58,6 +58,7 @@ function
We should report that we handle the connected tokens message
by setting the SPICE_MAIN_CAP_AGENT_CONNECTED_TOKENS capability.
---
Depends on
http://lists.freedesktop.org/archives/spice-devel/2015-January/018538.html
---
enums.js | 5 +
spiceconn.js | 4
2 files changed, 9
It is possible to transfer files from the client to the guest
using File API [0] when a spice vd agent is connected.
Methods for the transfer are based on spice-gtk implementation.
[0] http://www.w3.org/TR/file-upload/
---
enums.js| 6
filexfer.js | 26 ++
1 - 100 of 1597 matches
Mail list logo
