On 01/26/2016 02:11 PM, Baurzhan Konurbayev wrote:
Thanks for the reply.
We would like to try hardware acceleration for our thin clients and
therefore, tried to apply the patch called "Add GStreamer support for
video streaming", https://patchwork.freedesktop.org/series/1874/
Hi,
There is a n
On 01/26/2016 10:26 PM, Jonathon Jongsma wrote:
From: Frediano Ziglio
Signed-off-by: Frediano Ziglio
Signed-off-by: Jonathon Jongsma
---
Good idea. Here's a proposed re-wording of the documentation.
Changes:
- for get_command(), I changed the verb from 'request' to 'retrieve' to make
.so.0
#1 0x7f7647aa0f04 in __new_sem_wait_slow.constprop.0 () at
/lib64/libpthread.so.0
#2 0x7f7647aa0faa in sem_wait@@GLIBC_2.2.5 () at /lib64/libpthread.so.0
#3 0x7f75ac63ee41 in thread_encoding_proc () at /lib64/libvpx.so.2
#4 0x7f7647a9960a in start_thread () at /lib64/libpthread.
On 01/27/2016 06:09 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
common/log.c| 2 +-
common/marshaller.c | 7 +--
common/marshaller.h | 2 +-
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/common/log.c b/common/log.c
index 607aa82..a9bbebc 100644
On 02/27/2016 03:22 PM, Victor Toso wrote:
Hi,
On Fri, Feb 26, 2016 at 01:00:35PM -0500, Ryan wrote:
While reading the spec, some small grammar issues made it sounds
funky — I fixed some of them here:
https://github.com/Fuzion24/usbredir/commit/b3593f0f464aa9dc5150d38ff3e401cd25488f1b.patch
T
---
server/tests/replay.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index f3b670f..83411d3 100644
--- a/server/tests/replay.c
+++ b/server/tests/replay.c
@@ -47,6 +47,8 @@ static QXLWorker *qxl_worker = NULL;
static gboolean star
ed by spice-server, the "--skip"
only skips the sleep of "--slow".
Uri Lublin (3):
replay: learn how to count commands
replay: learn how to skip the first N (slow) commands
replay: do not use argv after g_option_context_parse
server/tests/replay.c | 29
Apparently, after using g_option_context_parse with G_OPTION_REMAINING
argv is modified and should not be used.
This patch uses "file" instead of "argv" and makes sure
file is freed later.
No free is called upon error - exit takes care of it.
---
server/tests/replay.c | 8
1 file changed,
Note that the commands are executed by spice-server.
The "skip" is only done on the "sleep" part of the
"slow" command-line option.
This is helpful to run quickly through uninsteresting commands
in a beginning of a recorded file and going slowly when
interesting parts appear
---
server/tests/repl
On 03/02/2016 03:00 PM, Christophe Fergeau wrote:
Hey,
On Wed, Feb 17, 2016 at 01:54:48PM +0330, Hamid Mazrae Mollaie wrote:
Hi,
Tank you for replay.
yes, my mouse and keyboard are usb and redirect to vm... and all pressed
key sent to vm
all hotkeys and Ctrl+Alt+F[n] does not work for example.
mplified
- Help string for count starts with a capital letter.
- ++ncommands instead of ncommands++ (same in this scenario)
Uri Lublin (3):
replay: learn how to count commands
replay: learn how to skip the first N (slow) commands
replay: do not use argv after g_option_context_p
Apparently, after using g_option_context_parse with G_OPTION_REMAINING
argv is modified and should not be used.
This patch uses "file" instead of "argv" and makes sure
file is freed later.
No free is called upon error - exit takes care of it.
Signed-off-by: Uri Lublin
Acked
Note that the commands are executed by spice-server.
The "skip" is only done on the "sleep" part of the
"slow" command-line option.
This is helpful to run quickly through uninsteresting commands
in a beginning of a recorded file and going slowly when
interesting parts appear
---
server/tests/repl
---
server/tests/replay.c | 8
1 file changed, 8 insertions(+)
diff --git a/server/tests/replay.c b/server/tests/replay.c
index f3b670f..0451b9a 100644
--- a/server/tests/replay.c
+++ b/server/tests/replay.c
@@ -47,6 +47,8 @@ static QXLWorker *qxl_worker = NULL;
static gboolean started
On 04/04/2016 12:13 PM, Christophe Fergeau wrote:
On Mon, Apr 04, 2016 at 10:02:08AM +0200, Fabiano Fidêncio wrote:
---
src/controller/test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/controller/test.c b/src/controller/test.c
index 649aca5..2909b06 100644
--- a/s
On 05/02/2016 11:25 AM, Frediano Ziglio wrote:
This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb
("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice
was changed.
This could be reproduced with:
- start rhel7 machine
- connect remote viewer (RV)
- RV: login
- co
On 04/12/2016 12:18 PM, hongzhen_...@sina.com wrote:
Hello
Could you tell me how to reduce the image resolution or definition ?
I plan to reduce the image definition so that decrease data
transmission from server to client .
For example ,I assume if I have a low bandwid
On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote:
The problem happens when you run 'make dist' in a system without
asciidoc installed. Even though in configure time there is a check for
building the manual, it is required to be built for distribution.
Hi,
I think we should not force buildi
On 05/02/2016 03:32 PM, Eduardo Lima (Etrunko) wrote:
On 05/02/2016 07:39 AM, Uri Lublin wrote:
On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote:
The problem happens when you run 'make dist' in a system without
asciidoc installed. Even though in configure time there is a check fo
On 05/03/2016 01:53 PM, Frediano Ziglio wrote:
On 05/02/2016 11:25 AM, Frediano Ziglio wrote:
This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb
("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice
was changed.
This could be reproduced with:
- start rhel7 mach
On 05/03/2016 06:36 PM, Frediano Ziglio wrote:
On 05/02/2016 07:39 AM, Uri Lublin wrote:
On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote:
The problem happens when you run 'make dist' in a system without
asciidoc installed. Even though in configure time there is a check for
bu
On 05/04/2016 11:51 AM, Frediano Ziglio wrote:
On 05/03/2016 01:53 PM, Frediano Ziglio wrote:
On 05/02/2016 11:25 AM, Frediano Ziglio wrote:
This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb
("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice
was changed.
On 05/05/2016 03:54 PM, Eduardo Lima (Etrunko) wrote:
On 05/05/2016 09:33 AM, Frediano Ziglio wrote:
Frediano Ziglio (2):
remove dangling pointer for RedCharDeviceVDIPort
Revert "Remove use of opaque from vdi_port_read_one_msg_from_device"
server/reds.c | 16 ++--
1 file change
Only 9 0's are required
Signed-off-by: Uri Lublin
---
src/mjpeg-fallback.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.cpp
index 09f3769..1b263f2 100644
--- a/src/mjpeg-fallback.cpp
+++ b/src/mjpeg-fallback.cpp
@@ -26,7
1 second is 10^9 nanosecond, not 10^10.
Signed-off-by: Uri Lublin
Acked-by: Victor Toso
---
changes since V1:
- Subject and log message reworded (Frediano, Victor)
---
src/mjpeg-fallback.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mjpeg-fallback.cpp b/src
On 4/3/19 7:33 PM, James Freeman wrote:
Hi all,
Conscious this might not be a SPICE issue but trying to debug where the
issue is right now. I'm working with someone who is using RHV 4.2 with a
vGPU configuration. At present we are stuck on a problem whereby the
vGPU can be successfully assign
~~
Signed-off-by: Uri Lublin
---
common/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/Makefile.am b/common/Makefile.am
index 2dd6d04..a904dae 100644
--- a/common/Makefile.am
+++ b/common/Makefile.am
@@ -114,7 +114,7 @@ generated_client_demar
Fix out-of-tree builds.
Uri Lublin (1):
codegen Makefile: add common/ to --include client_marshallers.h
---
subprojects/spice-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/subprojects/spice-common b/subprojects/spice-common
index 47ba8e0..5bcfa71 16
--- a
Signed-off-by: Uri Lublin
---
.gitlab-ci.yml | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index adf53e1..dbfb7ad 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -30,10 +30,13 @@ fedora-autotools:
- (cd spice-protocol
There are two patches:
The first picks the fixed spice-common
The second adds a gitlab-ci test for out-of-tree builds
Uri Lublin (2):
spice-common: update submodule
gitlab-ci: build out-of-tree too
.gitlab-ci.yml | 7 +--
subprojects/spice-common | 2 +-
2 files changed, 6
On 4/23/19 6:24 PM, Uri Lublin wrote:
There are two patches:
The first picks the fixed spice-common
The second adds a gitlab-ci test for out-of-tree builds
gitlab-ci pipeline with both patches:
https://gitlab.freedesktop.org/uril/spice-gtk/pipelines/32682
gitlab-ci pipeline with
Signed-off-by: Uri Lublin
---
The relevant job of the pipeline is:
https://gitlab.freedesktop.org/uril/spice/-/jobs/269735
---
.gitlab-ci.yml | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9ce95c00e..43cdb45ac 100644
--- a/.gitlab
On 4/30/19 1:15 PM, Frediano Ziglio wrote:
This is for SPICE server (missing in the subject).
Yes, sorry.
Signed-off-by: Uri Lublin
---
The relevant job of the pipeline is:
https://gitlab.freedesktop.org/uril/spice/-/jobs/269735
---
.gitlab-ci.yml | 5 -
1 file changed, 4
One test is enough -- do it in makecheck.
Must git clean first any previous builds.
Signed-off-by: Uri Lublin
---
Since V1:
- Add a comment about out-of-tree
- cleanup previous builds using git clean
pipeline task:
https://gitlab.freedesktop.org/uril/spice/-/jobs/272659
BTW, should we
Signed-off-by: Uri Lublin
---
Since V1:
- Add a comment about out-of-tree
- cleanup previous builds using git clean
pipeline task:
https://gitlab.freedesktop.org/uril/spice/-/jobs/272659
BTW, should we cleanup before/after every task ?
should we rm -rf builddir ? spice-protoco
On 5/1/19 4:53 PM, Frediano Ziglio wrote:
Allows to catch possible exception building the object.
Also will allow to more safely handle logger dependency.
The subject confused me a bit, as I thought about Makefile/Linking.
Perhaps change to something like - make agent object not static
Also se
On 5/1/19 4:53 PM, Frediano Ziglio wrote:
Allows the plugins to add information to the log.
Hi,
Looks good.
Don't you need to bump the version ?
Some comments below.
Signed-off-by: Frediano Ziglio
---
include/spice-streaming-agent/plugin.hpp | 5 +
src/concrete-agent.cpp
On 5/2/19 2:13 PM, Frediano Ziglio wrote:
Allows to catch possible exception building the object.
Also will allow to more safely handle logger dependency.
Signed-off-by: Frediano Ziglio
Acked-by: Uri Lublin
Uri.
---
src/concrete-agent.cpp| 11 +++
src/concrete
On 5/2/19 2:13 PM, Frediano Ziglio wrote:
Allows the plugins to add information to the log.
Signed-off-by: Frediano Ziglio
Acked-by: Uri Lublin
Uri.
---
include/spice-streaming-agent/plugin.hpp | 7 ++-
src/concrete-agent.cpp | 21 +
src
The gcc warning address-of-packed-member is new and on by
default in gcc 9.
Many of the structures sent over the network are packed
and with unaligned fields.
This breaks the build -- due to -Werror.
Tell gcc to not warn about it.
Signed-off-by: Uri Lublin
---
m4/manywarnings.m4 | 1
On 5/7/19 12:53 PM, Frediano Ziglio wrote:
The gcc warning address-of-packed-member is new and on by
default in gcc 9.
Many of the structures sent over the network are packed
and with unaligned fields.
This breaks the build -- due to -Werror.
Tell gcc to not warn about it.
Signed-off-by: Uri
On 5/8/19 4:06 PM, Frediano Ziglio wrote:
Copy to/from unaligned field to avoid potential unaligned access.
Although it adds a copy it's not in a hot path (migration) and
the structure is pretty small.
Signed-off-by: Frediano Ziglio
Ack, but see one comment below.
I wrote a similar patch, yo
On 5/7/19 12:57 PM, Daniel P. Berrangé wrote:
On Tue, May 07, 2019 at 12:48:55PM +0300, Uri Lublin wrote:
The gcc warning address-of-packed-member is new and on by
default in gcc 9.
Many of the structures sent over the network are packed
and with unaligned fields.
This breaks the build -- due
On 5/30/19 5:22 PM, Frediano Ziglio wrote:
g_object_unref is directly used.
OK.
I see there are some comments referring to red_char_device_destroy.
Consider removing those comments or rewriting them.
Uri.
Signed-off-by: Frediano Ziglio
---
server/char-device.c | 6 --
server/char-d
On 6/1/19 3:14 PM, Frediano Ziglio wrote:
As we don't use any token there's no reason to not queue
directly instead of passing through RedCharDevice.
This will make easier to limit the queue which currently is
unlimited.
Hi,
If we need flow control, how difficult would it be to add support
for
On 6/5/19 6:18 AM, Hongzhi.Song wrote:
There are folowing compile errors on Linux 32bit system with -Werror
for gcc.
red-channel.c:207:73: error: format '%x' expects argument of type
'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=]
|207| red_channel_debug(self, "thre
On 6/12/19 9:30 AM, Frediano Ziglio wrote:
Some typos/improves (just commit message)
Subject: [PATCH spice-server 1/2] Fix compile warnings on Linux 32bit system
Better "Remove compile warnings ..."
Both are OK.
Based on a patch from Hongzhi.Song .
There are following compile errors o
On 6/11/19 9:43 PM, Frediano Ziglio wrote:
Make sure the project compile and pass tests without problems
on a 32 bit architecture.
Signed-off-by: Frediano Ziglio
Ack.
Uri
---
.gitlab-ci.yml | 22 ++
1 file changed, 22 insertions(+)
diff --git a/.gitlab-ci.yml b/.
On 6/12/19 1:53 PM, Frediano Ziglio wrote:
On Windows Fedora 30 reports these errors:
In file included from
/usr/x86_64-w64-mingw32/sys-root/mingw/include/openssl/crypto.h:29,
from
/usr/x86_64-w64-mingw32/sys-root/mingw/include/openssl/bio.h:20,
from
/usr/x
On 6/13/19 1:23 PM, Frediano Ziglio wrote:
This constant fits in a 32 bit signed integer so it does not need the
suffix. However some of the derived constants don't so use an uint64_t
cast to avoid the long vs long long confusion (such as in print
statements).
Also some of the expressions these
the same.
Uri.
Windows and Unix (so Linux) include files for network are quite
different so the #ifdef. I included this header as I noted that
this was done in reds.c and the problem didn't happen so for
coherence I included that specific header.
Acked-by: Uri Lublin
__
On 6/13/19 2:47 PM, Frediano Ziglio wrote:
On 6/13/19 1:23 PM, Frediano Ziglio wrote:
This constant fits in a 32 bit signed integer so it does not need the
suffix. However some of the derived constants don't so use an uint64_t
cast to avoid the long vs long long confusion (such as in print
sta
On 6/15/19 2:59 PM, Frediano Ziglio wrote:
This constant fits in a 32 bit signed integer so it does not need the
suffix. However some of the derived constants don't so use an uint64_t
cast to avoid the long vs long long confusion (such as in print
statements).
Also some of the expressions these
On 6/3/19 2:22 PM, Frediano Ziglio wrote:
This patch came from some experiments using an emulated MIPS machine.
On such architecture due to not supporting alignment access the
compiler is more strict about conversion complaining with some
pointer casts. Use different conversion to avoid these war
On 6/3/19 2:22 PM, Frediano Ziglio wrote:
The formula is here to make sure glyph is aligned to 4 bytes so
tell to the compiler to avoid a warning.
What's the warning ?
Is it that the pointer may be unaligned (which is imposible
if you start from an aligned address) ?
Looks complicated to me, e
On 6/18/19 8:03 PM, Frediano Ziglio wrote:
On 6/3/19 2:22 PM, Frediano Ziglio wrote:
The formula is here to make sure glyph is aligned to 4 bytes so
tell to the compiler to avoid a warning.
What's the warning ?
Trying to reproduce but the updated environment it's slow like
hell (it's more
On 6/3/19 2:22 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
---
server/jpeg-encoder.c | 7 +++
server/mjpeg-encoder.c | 21 +++--
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/server/jpeg-encoder.c b/server/jpeg-encoder.c
index 269ed8aa7..
On 6/21/19 12:45 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
Ack.
Uri.
---
server/dcc-send.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index ea2128e27..b14619a2b 100644
--- a/server/dcc-send.c
+++ b/server/dcc-
On 6/25/19 7:38 AM, Francois Gouget wrote:
On Mon, 17 Jun 2019, Uri Lublin wrote:
On 6/15/19 2:59 PM, Frediano Ziglio wrote:
This constant fits in a 32 bit signed integer so it does not need the
suffix. However some of the derived constants don't so use an uint64_t
cast to avoid the lo
On 6/25/19 7:35 PM, Francois Gouget wrote:
On Tue, 25 Jun 2019, Frediano Ziglio wrote:
[...]
uint64_t foo = 1234;
spice_debug("foo=%" PRId64, foo / NSEC_PER_SEC);
[...]
If you assume long long == 64 bit should not be a big problem
although you can still have the warning.
So, we all
On 6/27/19 11:40 AM, Frediano Ziglio wrote:
Interrupt/restart the video streams when the user changes the
preferred video-codecs (dcc_handle_preferred_video_codec_type) or when
the host admin updates the list of video-codecs allowed
(display_channel_set_video_codecs)
Hi,
This patch only stops
Hi
Suggestions:
Initialise -> Initialize (?) (Is this British vs American ?)
variable -> prev (?)
On 6/27/19 12:05 PM, Frediano Ziglio wrote:
Avoids to have not initialised variables before constructed is called.
I think this line can be removed, the next line explains what's needed.
T
On 6/27/19 12:05 PM, Frediano Ziglio wrote:
"image_surfaces_get" and "drawables_init" are already defined
in the same file earlier.
Signed-off-by: Frediano Ziglio
Ack.
Uri.
---
server/display-channel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/server/display-channel.c b/server
On 6/27/19 12:19 PM, Kevin Pouget wrote:
Hello Uri,
On Thu, Jun 27, 2019 at 11:04 AM Uri Lublin wrote:
On 6/27/19 11:40 AM, Frediano Ziglio wrote:
Interrupt/restart the video streams when the user changes the
preferred video-codecs (dcc_handle_preferred_video_codec_type) or when
the host
On 6/27/19 12:51 PM, Frediano Ziglio wrote:
Hi
Suggestions:
Initialise -> Initialize (?) (Is this British vs American ?)
Yes, US/UK :-)
variable -> prev (?)
"Initialize prev as soon as possible" ?
Sorry, I meant "priv"
(Was "affected" by rings, after reviewing Kevin's patch ;
On 5/13/19 12:45 PM, Frediano Ziglio wrote:
Do not declare the structure as aligned.
The start/end-packed.h headers affects only MingW or Microsoft
compilers.
They also define/undef SPICE_ATTR_PACKED which affects Linux.
BTW, if we define PACKED as ALIGNED(1) does that work for Windows
too (I
On 7/1/19 6:19 PM, Frediano Ziglio wrote:
Fedora 30 / gcc 9.1.1 20190503 (Red Hat 9.1.1-1) fails to build
because of this error/warning:
gstreamer-encoder.c: In function 'set_video_bit_rate':
gstreamer-encoder.c:518:17: error: taking the absolute value of unsigned
type 'uint64_t' {aka 'long un
---
server/glz-encoder-dict.c | 2 +-
server/gstreamer-encoder.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/glz-encoder-dict.c b/server/glz-encoder-dict.c
index c3c4606c6..7bf16bfb2 100644
--- a/server/glz-encoder-dict.c
+++ b/server/glz-encoder-dict.c
@@ -410,7
---
Is "Client has sent an unknown ..." better ?
Or "Client sent an unknown ... "
---
server/dcc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/dcc.c b/server/dcc.c
index 71d09b77f..bd393e040 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -1177,7 +1177,7 @@ stat
unknow-> unknown
garanteed -> guaranteed
preceed -> precede
Uri Lublin (3):
typo: dcc: fix the spelling of unknown
typo: image-encoders: fix the spelling of guaranteed
typo: fix the spelling of precede
server/dcc.c | 2 +-
server/glz-encoder-dict.c | 2 +
---
server/image-encoders.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/image-encoders.c b/server/image-encoders.c
index d4d486c36..81dc076a8 100644
--- a/server/image-encoders.c
+++ b/server/image-encoders.c
@@ -217,7 +217,7 @@ static void encoder_data_reset(Encoder
In red_pipe_replace_rendered_drawables_with_images, the
value of pipe_item is re-written on the next iteration.
Since a78a7d251042892182b158650291d19a85bbd6b1 pipe_item
is no longer used to control the loop.
Found by Covscan.
Signed-off-by: Uri Lublin
---
server/dcc-send.c | 1 -
1 file
On 7/4/19 12:33 PM, Frediano Ziglio wrote:
Remove use-after-free introduced by a78a7d251042892182b158650291d19a85bbd6b1
---
server/dcc-send.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index 565a79f33..4582e3545 100644
---
On 7/4/19 4:31 PM, Frediano Ziglio wrote:
On 7/4/19 12:33 PM, Frediano Ziglio wrote:
Remove use-after-free introduced by
a78a7d251042892182b158650291d19a85bbd6b1
---
server/dcc-send.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/server/dcc-send.c b/server/dc
On 5/20/19 10:39 AM, Frediano Ziglio wrote:
- copy missing recorder files;
- generate THANKS file.
Signed-off-by: Frediano Ziglio
---
Makefile.am | 1 +
build-aux/meson-dist | 28
meson.build | 2 +-
3 files changed, 30 insertions(+), 1 dele
On 5/20/19 10:39 AM, Frediano Ziglio wrote:
Make sure Meson is able to generate a correct tarball.
Signed-off-by: Frediano Ziglio
---
.gitlab-ci.yml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a6cb2cda..5ddb4db8 100644
--- a/.gitlab-ci.yml
On 5/20/19 10:39 AM, Frediano Ziglio wrote:
Make sure we can build distribution.
Some small updates also to fix some minor issues.
CI results at https://gitlab.freedesktop.org/fziglio/spice-gtk/pipelines/37744
Ack series with some comments in 3/4 and 4/4
Frediano Ziglio (4):
ci: Test we
On 7/8/19 4:10 PM, Frediano Ziglio wrote:
On 5/20/19 10:39 AM, Frediano Ziglio wrote:
Make sure Meson is able to generate a correct tarball.
Signed-off-by: Frediano Ziglio
---
.gitlab-ci.yml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index a
On 7/8/19 3:00 PM, Frediano Ziglio wrote:
This series is from Marc-André, I just rebased it on current master.
Not much left of the original series.
I think it's time to get back to it.
Does meson work well for mingw-spice-gtk ?
I think a safer path is to make a release with Meson
before remo
On 7/9/19 5:16 PM, Victor Toso wrote:
Hi,
On Tue, Jul 09, 2019 at 07:47:18AM -0400, Frediano Ziglio wrote:
On 7/8/19 3:00 PM, Frediano Ziglio wrote:
This series is from Marc-André, I just rebased it on current master.
Not much left of the original series.
I think it's time to get back to it.
From: Frediano Ziglio
Signed-off-by: Frediano Ziglio
---
server/dcc-send.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index 565a79f33..e0f3b8183 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -725,7 +725,6 @@ static
In red_pipe_replace_rendered_drawables_with_images, the
value of pipe_item is re-written on the next iteration.
Since a78a7d251042892182b158650291d19a85bbd6b1 pipe_item
is no longer used to control the loop.
Found by Covscan.
Signed-off-by: Uri Lublin
---
server/dcc-send.c | 1 -
1 file
'l' is being freed within the loop
Found-by: Frediano Ziglio
Signed-off-by: Uri Lublin
---
server/dcc-send.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/server/dcc-send.c b/server/dcc-send.c
index e0f3b8183..4a92ce8cd 100644
--- a/server/dcc-send.c
+++ b/
Frediano Ziglio (1):
dcc-send: remove unused variable 'image'
Uri Lublin (2):
dcc-send: remove useless pipe_item assignment pipe_item
dcc-send: fix use-after-free
server/dcc-send.c | 12 +---
1 file changed, 5 insertions(+)
On 7/16/19 1:55 PM, Snir Sheriber wrote:
This allows to set plugin key=value properties on run time.
To add encoder plugin property use the following syntax:
-gst.prop="key=value"
Is this the correct syntax, or do you need a -c ?
Make sure syntax is accurate and that the property is supported
On 6/27/19 6:03 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
Ack.
Uri.
---
server/websocket.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/server/websocket.h b/server/websocket.h
index 22120d939..7707e6804 100644
--- a/server/websocket.h
+++ b/server/websocket.h
@
On 6/27/19 6:03 PM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
Ack, with comment/suggestion below.
---
server/websocket.h | 4
1 file changed, 4 insertions(+)
diff --git a/server/websocket.h b/server/websocket.h
index 7707e6804..ec452038b 100644
--- a/server/websocket.h
+
On 7/17/19 1:41 PM, Frediano Ziglio wrote:
video_codecs can be freed so use it before.
Signed-off-by: Frediano Ziglio
Ack.
I had a similar patch, you sent your faster :)
Uri.
---
server/reds.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/reds.c b/s
On 7/17/19 2:32 PM, Frediano Ziglio wrote:
inttypes.h contains macro for format string while
stdint.h more specifically contains type definitions (like uint8_t).
Signed-off-by: Frediano Ziglio
Ack :)
---
server/websocket.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 7/17/19 12:46 PM, Frediano Ziglio wrote:
This remove this error running test-listen test on a Fedora 30 docker
image:
(/builds/spice/spice/build/server/tests/test-listen:2233): GLib-GIO-CRITICAL
**: 15:29:03.123: g_file_new_for_path: assertion 'path != NULL' failed
This error is due to some
On 7/18/19 10:32 AM, Frediano Ziglio wrote:
Signed-off-by: Frediano Ziglio
Hi Frediano,
I've been playing with it too.
Had similar rules but different.
Your version works for me.
Some minor comments below.
---
server/tests/valgrind/spice.supp | 25 +
1 file chang
On 7/18/19 10:32 AM, Frediano Ziglio wrote:
This series split and update Valgrind suppression files in
order for make Gitlab CI pass.
Works for me.
Some minor comments for patch 3.
Ack series.
Uri.
Results at
https://gitlab.freedesktop.org/fziglio/spice/-/jobs/430006.
Note that to pass Va
On 7/18/19 5:31 PM, Jeremy White wrote:
Signed-off-by: Jeremy White
Hi,
The patch looks good to me.
See a comment below.
---
src/options.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/src/options.c b/src/options.c
index b7f487c5..0d3138d0
On 7/17/19 3:06 PM, Frediano Ziglio wrote:
This remove this error running test-listen test on a Fedora 30 docker
image:
(/builds/spice/spice/build/server/tests/test-listen:2233): GLib-GIO-CRITICAL
**: 15:29:03.123: g_file_new_for_path: assertion 'path != NULL' failed
This error is due to some
---
server/tests/Makefile.am | 6 +++---
server/tests/meson.build | 2 +-
server/tests/{video-encoders => test-video-encoders} | 0
3 files changed, 4 insertions(+), 4 deletions(-)
rename server/tests/{video-encoders => test-video-encoders}
This fixes the following warning:
./configure: line 7040: /usr/bin/file: No such file or directory
Signed-off-by: Uri Lublin
---
.gitlab-ci.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 316a860dd..33210cb9d 100644
--- a/.gitlab
On 7/19/19 12:18 PM, Frediano Ziglio wrote:
Do not pass unaligned QXLPHYSICAL but pass a valid pointer and
then cast.
Signed-off-by: Frediano Ziglio
Ack.
Uri.
---
server/red-replay-qxl.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
Changes since v1:
- remov
Hi Frediano,
On 7/23/19 11:21 PM, Frediano Ziglio wrote:
The decoding is wrong, the Red and QXL structures are different so
code is not doing what is expected. red-parse-qxl translate from QXL
to Red structures, red-record-qxl saves Red structure to file,
red-replay-qxl is supposed to read from
On 7/24/19 2:37 PM, Frediano Ziglio wrote:
Hi Frediano,
On 7/23/19 11:21 PM, Frediano Ziglio wrote:
The decoding is wrong, the Red and QXL structures are different so
code is not doing what is expected. red-parse-qxl translate from QXL
to Red structures, red-record-qxl saves Red structure to f
rs. To enable QUIC encoding I added "image-compression=quic"
and "streaming-video=off" to "-spice" Qemu option in order to force
QUIC encoding in the guest driver (thanks to Uri Lublin for the help
reproducing it).
Signed-off-by: Frediano Ziglio
Ack.
1 - 100 of 1198 matches
Mail list logo
