Re: [Spice-devel] [PATCH 2/2] spice client: add ipv6 support.

2010-02-21 Thread Uri Lublin
On 02/19/2010 01:21 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmannkra...@redhat.com --- client/red_peer.cpp | 89 +++--- 1 files changed, 41 insertions(+), 48 deletions(-) diff --git a/client/red_peer.cpp b/client/red_peer.cpp index

Re: [Spice-devel] Project Information

2010-02-25 Thread Uri Lublin
On 02/24/2010 03:32 AM, Kris Lyttle wrote: Hello, I came across your website while researching systems that will remotely control a virtualized computer environment or virtual machine (VM) via the internet, i.e., controlling a VM as if it were a physical machine using VNC, VPN, etc., and it

[Spice-devel] [PATCH] spice server: fix typo in private key error message

2010-04-15 Thread Uri Lublin
From: Dan Kenigsberg dan...@redhat.com --- server/reds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/reds.c b/server/reds.c index 7d7fd44..e6fc9c4 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3230,7 +3230,7 @@ static void reds_init_ssl()

[Spice-devel] [PATCH] server: add missing ifdef USE_OGL (red_worker.c)

2010-07-06 Thread Uri Lublin
--- server/red_worker.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 255a46e..38f5e1c 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -37,8 +37,10 @@ #include spice/protocol.h #include red_worker.h

Re: [Spice-devel] SPICE USB redirection support

2010-07-27 Thread Uri Lublin
On 07/27/2010 06:35 AM, steven wrote: I noticed that this is a future development; just wondering if anyone has dived into it yet and could share his/her experience. Specifically I'm looking for printer and scanner support. SPICE USB support is not yet available. We plan on developing it in

Re: [Spice-devel] [PATCH] qxl: add 800x480 resolution to qxl_modes (n900 native)

2010-08-04 Thread Uri Lublin
On 08/03/2010 11:39 AM, Alon Levy wrote: Required for full screen in n900. Our vdagent is currently broken in that if you request a resolution that isn't supported by the driver you are left with a white screen, so this fixes spicec --full-screen=auto-conf for n900. Review please. ---

Re: [Spice-devel] [PATCH 1/2] Release more drawables on OOM

2010-09-20 Thread Uri Lublin
On 09/09/2010 07:56 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com We've changed how resources are released so they are now being freed continuosly, rather than on OOM, since we want to free as early possible to avoid fragmentation. So, OOM situations should be a bit less

Re: [Spice-devel] [PATCH 2/2] server: Ensure we flush the release pipe after an oom

2010-09-20 Thread Uri Lublin
On 09/09/2010 07:56 PM, al...@redhat.com wrote: From: Alexander Larssonal...@redhat.com We really need to flush the ring to ensure that we push something on the release ring. If we don't do this and the ring is not pushed for other reasons we will timeout in the guest driver waiting for the

Re: [Spice-devel] [PATCH] spicec-win: remove redundent strdup buggy free

2010-10-25 Thread Uri Lublin
On 10/25/2010 12:03 PM, Arnon Gilboa wrote: text refered a substr of item_dup and was used after free(item_dup). no need to strdup, we can destroy the resource string. ACK. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] [PATCH 04/12] spice codegen: fix copy-o, no such variable value

2010-10-28 Thread Uri Lublin
On 10/27/2010 06:36 PM, Alon Levy wrote: --- python_modules/ptypes.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 0ae57ec..9c4b7de 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@

Re: [Spice-devel] [PATCH spice 1/1] spicec-win: ignore MSVCRT.lib in x86 build

2010-11-07 Thread Uri Lublin
On 11/07/2010 02:44 PM, Arnon Gilboa wrote: Same as in x64 build, for using the updated wspice-0.6.3 --- client/windows/redc.vcproj |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/client/windows/redc.vcproj b/client/windows/redc.vcproj index 15a77ac..c75adea

Re: [Spice-devel] [PATCH] build: make it silent

2010-11-17 Thread Uri Lublin
On 11/12/2010 02:38 PM, Marc-André Lureau wrote: This patch make it easier to spot warnings in compilation. It should work with older versions of automake that don't support silent rules. If you want verbose build, make V=1. --- configure.ac |2 ++ 1 files changed, 2 insertions(+), 0

[Spice-devel] [PATCH] spice-client migration: fix minor for old migration support.

2011-01-09 Thread Uri Lublin
For not too old spice-migration, minor is 1. For older (ancient) spice-migration, minor is 0. Affects only VM migration while a spice client is connected. --- client/red_client.cpp |2 +- spice1.proto |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [Spice-devel] [PATCH 00/10] server test fixes

2011-01-10 Thread Uri Lublin
On 01/08/2011 04:23 PM, Alon Levy wrote: These patches rewrite most of the display test, adding a cursor channel test (but not used in current tester), and making it easier to add future tests by creating a command queue, see test_display_no_ssl.c and test_display_streaming.c The patches

[Spice-devel] [PATCH] spice server tests: Makefile.am: use AM_LDFLAGS (not LDFLAGS)

2011-01-19 Thread Uri Lublin
This enables configuration using autoreconf. --- server/tests/Makefile.am | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index 11cc5f2..f93a4ad 100644 --- a/server/tests/Makefile.am +++

Re: [Spice-devel] [RFC] client: --help should not need X

2011-01-26 Thread Uri Lublin
On 01/26/2011 01:55 AM, Alon Levy wrote: separate initialization into before command line parsing and after, call later only if command line parsing succeeds (in particular, it fails if --help is given). Good. This one has been waiting for someone to fix for quite some time. ---

[Spice-devel] [PATCH] client: rename connect_unsecure to connect_to_peer (rhbz#653545)

2011-02-07 Thread Uri Lublin
Both connect_secure() and connect_unsecure() call connect_to_peer(). Prior to this commit spicec.log reported all connections as unsecure, as connect_secure() called connect_unsecure() to make the connection. --- client/red_peer.cpp | 17 + client/red_peer.h |1 + 2 files

Re: [Spice-devel] [PATCH 1/1] configure.ac: use AC_LANG_SOURCE in AC_COMPILE_IFELSE, silence remaining warnings

2011-02-07 Thread Uri Lublin
On 01/17/2011 01:27 AM, Alon Levy wrote: --- configure.ac |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 8719f32..740abe7 100644 --- a/configure.ac +++ b/configure.ac @@ -314,7 +314,7 @@ AC_DEFUN([SPICE_CC_TRY_FLAG], [

Re: [Spice-devel] [PATCH] server/red_worker: fix used but uninitialized warning (gcc 4.6.0)

2011-02-08 Thread Uri Lublin
On 02/07/2011 03:11 PM, Alon Levy wrote: --- server/red_worker.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index f899ff2..f163a71 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -6219,7 +6219,7 @@ static

Re: [Spice-devel] [PATCH spice 1/1] client/windows: use SPICE_COMMON_DIR instead of ..\..\..\spice-protocol in project include dirs

2011-02-09 Thread Uri Lublin
On 02/09/2011 05:15 PM, Arnon Gilboa wrote: relative path to another git tree is a bit ugly, since it requires spice-protocol to be in a specific location. SPICE_COMMON_DIR is also used in windows qxl and vdagent, so it's netural using it here as well. Ack. Can we in the near future rename

[Spice-devel] [PATCH] spice client: simplify link_err reporting

2011-02-10 Thread Uri Lublin
--- client/red_channel.cpp |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/client/red_channel.cpp b/client/red_channel.cpp index f4cdf52..0d95f3a 100644 --- a/client/red_channel.cpp +++ b/client/red_channel.cpp @@ -195,9 +195,7 @@ void RedChannelBase::link(uint32_t

Re: [Spice-devel] [PATCH] fix spice-server segfault on migration

2011-02-15 Thread Uri Lublin
On 02/15/2011 11:39 AM, Gerd Hoffmann wrote: spice-server tries to use the migration information without checking whenever this is available in the first place ... Signed-off-by: Gerd Hoffmannkra...@redhat.com --- server/reds.c |4 1 files changed, 4 insertions(+), 0 deletions(-)

[Spice-devel] [PATCH] client: exit nicely for --controller with no SPICE_XPI_SOCKET (#644292)

2011-03-01 Thread Uri Lublin
When starting spicec with --controller, SPICE_XPI_SOCKET environment variable must be defined so spicec and the controller can be connected. --- client/controller.cpp |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/client/controller.cpp b/client/controller.cpp index

Re: [Spice-devel] [PATCH] server/reds: allow call to reds_agent_remove even if it is gone

2011-03-06 Thread Uri Lublin
On 03/04/2011 01:52 PM, Alon Levy wrote: The current assert(reds-agent_state.connected) tiggers if when the agent disconnected there was still data waiting to be sent (for instance if there is a bug in the client handling clipboard and it is killed while a large clipboard transfer is in

Re: [Spice-devel] [PATCH] qxl_dev: introduce defines for rings sizes

2011-03-07 Thread Uri Lublin
On 03/07/2011 08:47 PM, Alon Levy wrote: --- spice/qxl_dev.h | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 7219bfc..e3e0696 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -200,10 +200,14 @@ typedef struct

Re: [Spice-devel] [PATCH] server/tests: add test_playback

2011-03-22 Thread Uri Lublin
On 03/08/2011 10:03 PM, Alon Levy wrote: --- server/tests/Makefile.am |5 ++- server/tests/test_playback.c | 99 ++ server/tests/test_util.h |2 + 3 files changed, 105 insertions(+), 1 deletions(-) create mode 100644

Re: [Spice-devel] [PATCH] server/red_worker: fix dump_bitmap (disabled unless DUMP_BITMAP is defined)

2011-04-04 Thread Uri Lublin
On 04/04/2011 07:58 PM, Alon Levy wrote: --- server/red_worker.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index f163a71..dce1313 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -10347,6 +10347,7 @@

Re: [Spice-devel] [PATCH 09/15] client: remove c++ wrappers

2011-04-21 Thread Uri Lublin
On 04/21/2011 02:53 PM, Christophe Fergeau wrote: client/ contains several .cpp file which only #include a .c file of the same name. This is unusual and seems to only be done to get C++ name mangling on the symbols defined in the C file. Now that all headers files in common/ use extern C, these

Re: [Spice-devel] [PATCH 0/2] client/windows: fix broken build

2011-05-22 Thread Uri Lublin
On 05/22/2011 03:04 PM, Arnon Gilboa wrote: Arnon Gilboa (2): common: add WIN64 ifdef for spice_bit_find_msb (fix broken windows x64 build) client/windows: remove precompiled header for common.h (fix broken windows debug build) client/windows/redc.vcproj |8

Re: [Spice-devel] [PATCH 1/2] client/windows: remove slash from x64 build dir

2011-05-24 Thread Uri Lublin
On 05/24/2011 04:35 PM, Arnon Gilboa wrote: otherwise x64 is built in root if REDC_BUILD_DIR is not defined --- client/windows/redc.vcproj |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client/windows/redc.vcproj b/client/windows/redc.vcproj index

Re: [Spice-devel] [PATCH 1/1] client/windows: enable image randomization (ASLR) rhbz#701111

2011-05-29 Thread Uri Lublin
On 05/29/2011 12:18 PM, Arnon Gilboa wrote: Enable image randomized base address, hindering some types of security attacks by making it more difficult for an attacker to predict target addresses. --- client/windows/redc.vcproj |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[Spice-devel] [PATCH] client: log formatted time (#674013)

2011-05-30 Thread Uri Lublin
--- client/application.cpp | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index 606f7e2..85a4804 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -2496,12 +2496,23 @@ static inline

Re: [Spice-devel] SPICE and libjpeg-turbo

2011-06-19 Thread Uri Lublin
On 06/18/2011 11:02 PM, John A. Sullivan III wrote: As I think about tweaking video performance, I wonder if libjpeg-turbo would help at all. We installed on a Fedora 15 KVM host from RPM. Are those compiled against libjpeg or libjpeg-turbo? In Fedora 15, only libjpeg-turbo is available (out

Re: [Spice-devel] repository reorg

2011-06-22 Thread Uri Lublin
On 06/22/2011 06:00 PM, Alon Levy wrote: Hi All, We currently have the following repositories: spice-protocol spice spice-gtk also spice-vdagent (for both Windows and Linux) spice-xpi/active-x (as mentioned below) spice-protocol contains the following parts:

Re: [Spice-devel] repository reorg

2011-06-23 Thread Uri Lublin
On 06/23/2011 02:10 PM, Alon Levy wrote: On Thu, Jun 23, 2011 at 12:18:11PM +0200, Alon Levy wrote: On Wed, Jun 22, 2011 at 05:00:10PM +0200, Alon Levy wrote: Hi All, Ok, so take three: (1) spice-protocol - remains unchanged. specifically, despite the name, will not contain the

Re: [Spice-devel] [PATCH] plugin: try to run only /usr/libexec/spice-xpi-client

2011-06-28 Thread Uri Lublin
On 06/28/2011 01:55 AM, Marc-André Lureau wrote: Although not really important, the previous code was racy (stat + exec). What seems to be the problem with it ? I propose running /usr/libexec/spice-xpi-client without parameters, which could be a shell script with the required arguments to

Re: [Spice-devel] [PATCH] Server: Changed uint64_t printing format from %ld to %lld

2011-07-04 Thread Uri Lublin
On 07/03/2011 04:27 PM, Rami Vaknin wrote: From: rootroot@fed15.localdomain Compiling with gcc-c++-4.6.0-9.fc15.i686 on Fedora 15 --- server/main_channel.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/main_channel.c b/server/main_channel.c index

Re: [Spice-devel] Purpose of interface version checks in server/reds.c

2011-07-05 Thread Uri Lublin
On 07/05/2011 11:57 AM, Christophe Fergeau wrote: On Mon, Jul 04, 2011 at 02:37:09PM +0200, Christophe Fergeau wrote: On Mon, Jul 04, 2011 at 01:27:16PM +0200, Gerd Hoffmann wrote: On 07/01/11 15:58, Christophe Fergeau wrote: if (strcmp(interface-type, SPICE_INTERFACE_RECORD) == 0) {

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-14 Thread Uri Lublin
On 07/14/2011 10:50 AM, Alon Levy wrote: Add a backtrace printing function copied from xserver os/backtrace.c that uses gstack which seems to be available enough that xserver uses it :) Used in ASSERT, tested on F15. --- diff --git a/common/backtrace.c b/common/backtrace.c + +while

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-18 Thread Uri Lublin
On 07/18/2011 12:47 PM, Alon Levy wrote: On Mon, Jul 18, 2011 at 11:13:50AM +0200, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 11:57:47AM +0300, Alon Levy wrote: On Mon, Jul 18, 2011 at 10:13:27AM +0200, Christophe Fergeau wrote: What use case do you have in mind for this? Is it meant

Re: [Spice-devel] [PATCH v2] common: add backtrace via gstack or glibc backtrace

2011-07-18 Thread Uri Lublin
On 07/18/2011 07:21 PM, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 06:42:14PM +0300, Alon Levy wrote: diff --git a/common/spice_common.h b/common/spice_common.h index bc74486..6c5154c 100644 --- a/common/spice_common.h +++ b/common/spice_common.h @@ -22,9 +22,11 @@ #includestdint.h

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-19 Thread Uri Lublin
On 07/18/2011 01:32 PM, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 01:19:05PM +0300, Uri Lublin wrote: On Mon, Jul 18, 2011 at 11:13:50AM +0200, Christophe Fergeau wrote: Or this can be checked for in configure.ac I'm not sure configure.ac is the place to check it. Why not? If you

[Spice-devel] [PATCH V2] client: log formatted time (#674013)

2011-07-20 Thread Uri Lublin
V2 changes: moved get_timestamp into the if() condition. initialize ts[0]='\0' before calling get_timestamp. --- client/application.cpp | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index

Re: [Spice-devel] [PATCH vdagent-win] virtio_vdi_port: if async read returns with ERROR_OPERATION_ABORTED, cancel pending (rhbz#725734)

2011-08-01 Thread Uri Lublin
On 08/01/2011 11:27 AM, Arnon Gilboa wrote: Therefore in case of virtio-serial ReadFile timeout (new driver behavior), the next VirtioVDIPort::read() call by the service will be performed, since it is now (!_read.pending). Ack. Do we need something similar for the _write.pending ?

Re: [Spice-devel] [PATCH] client/red_client: fix broken switch host migration (RHBZ 727969)

2011-08-03 Thread Uri Lublin
On 08/03/2011 10:54 PM, Alon Levy wrote: 3f8d7e59dbd94b1837503f37b5065698df3ffbc7 introduced a regression, after sending one attach_channels message we never send another one. Fix by resetting on disconnect. --- client/red_client.cpp |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

Re: [Spice-devel] [RFC qxl-win 2/2] display: handle interrupt handler disappearance (rhbz 721118)

2011-09-21 Thread Uri Lublin
On 09/21/2011 04:13 PM, Alon Levy wrote: This patch handles the surprise removal whql test. The surprise removal test sends a surprise removal IRP via a filter driver to qxl.sys. The handling of that IRP is actually done in videoprt.sys, and there is no API to get notified. The side effect of

Re: [Spice-devel] Help with TLS and SPICE client

2011-09-27 Thread Uri Lublin
On 09/22/2011 10:40 PM, Kirkpatrick, Jeffrey W wrote: I followed the guidance on this page http://spice-space.org/page/SSLConnection and http://fedoraproject.org/wiki/QA:Testcase_Virtualization_Manually_set_spice_listening_port_with_TLS_port_set for setting up SSL authentication for the SPICE

Re: [Spice-devel] [PATCH 0.8] server/smartcard: error packet sending. RHBZ 741259

2011-09-27 Thread Uri Lublin
On 09/27/2011 11:24 PM, Alon Levy wrote: fix wrongly applied master patch. With this it is identical to the change in master commit b37182426923124470bf3701f4cff2a6bb345b8d --- server/smartcard.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/server/smartcard.c

Re: [Spice-devel] [PATCH v3 04/22] server, proto: tell the client to connect to the migration target before migraton starts

2011-09-27 Thread Uri Lublin
On 09/25/2011 03:36 PM, Yonit Halperin wrote: (1) send SPICE_MSG_MAIN_MIGRATE_BEGIN upon spice_server_migrate_connect (2) wait for SPICE_MSGC_MAIN_MIGRATE_(CONNECTED|CONNECT_ERROR), or a timeout, in order to complete client_migrate_info monitor command Signed-off-by: Yonit

[Spice-devel] [master PATCH 1/2] server: netstat: modify network bandwidth calculation

2011-10-18 Thread Uri Lublin
Currently spice-server network bandwidth estimation is: send an empty ping packet to the client (and ignore it) (warmup) send an empty ping packet and calculate time till pong is received (latency) send a ping packet with data (256KB) and calculate time till pong (roundtrip) bandwidth =

[Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-18 Thread Uri Lublin
WAN accelerators may compress the zeros which results with a wrong bandwidth calculation. The buffer is initialized once. --- server/main_channel.c | 32 1 files changed, 28 insertions(+), 4 deletions(-) diff --git a/server/main_channel.c

Re: [Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-19 Thread Uri Lublin
On 10/18/2011 11:50 PM, Yaniv Kaul wrote: On 18/10/2011 19:20, Uri Lublin wrote: WAN accelerators may compress the zeros which results with a wrong bandwidth calculation. Is this really the right approach? Why not calculate the latency based on the time it takes to send the first image

Re: [Spice-devel] [master PATCH 1/2] server: netstat: modify network bandwidth calculation

2011-10-19 Thread Uri Lublin
On 10/18/2011 11:53 PM, Yaniv Kaul wrote: On 18/10/2011 19:20, Uri Lublin wrote: Currently spice-server network bandwidth estimation is: send an empty ping packet to the client (and ignore it) (warmup) Useless. 'warmup' of what exactly? The TCP MSS and everything else is already set

Re: [Spice-devel] [PATCH 3/3] data: add test.html page

2011-10-24 Thread Uri Lublin
On 09/28/2011 04:13 PM, Marc-André Lureau wrote: Originally provided by Alon Levy and Peter Hatina. Actually, the author of test.html is Yuval Kashtan. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] [PATCH v2 vdagent-win] vdlog: change log times to human readable date time rhbz#672828

2011-11-21 Thread Uri Lublin
On 11/21/2011 09:50 AM, Arnon Gilboa wrote: -use RHEV log format -add log levels macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 common/vdlog.h | 54 +++--- 2 files changed, 39 insertions(+), 19 deletions(-) diff

Re: [Spice-devel] [PATCH v3 vdagent-win] vdlog: change log times to human readable date time rhbz#672828

2011-11-22 Thread Uri Lublin
On 11/21/2011 02:13 PM, Arnon Gilboa wrote: -use RHEV log format -add log levels macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 --- common/vdlog.h | 62 - 2 files changed, 47 insertions(+), 19 deletions(-) Ack.

Re: [Spice-devel] [PATCH 0.8 2/2] client: handle the redundant right ctrl windows' message send when a alt-gr is pressed bz#709074

2011-11-24 Thread Uri Lublin
On 11/14/2011 12:51 PM, Gal Hammer wrote: Hello, The second patch check to see if Windows is sending a fake VK_CONTROL message when the user pressed Alt-Gr when using a non-US keyboard layout (German, Czech, etc...). If the function is_fake_ctrl return true and key event is translated to a

Re: [Spice-devel] [PATCH 0.8 1/2] client: handle the redundant right ctrl windows' message send when a alt-gr is pressed bz#709074

2011-11-24 Thread Uri Lublin
On 11/14/2011 12:51 PM, Gal Hammer wrote: Hello, I first updated the translate_key function. It now requires the windows message as parameter (will be used later). It also use the raw wparam and lparam parameters in order to remove the code duplication when calling the function. Gal.

[Spice-devel] [PATCH 1/4] client controller/foreign_menu: use memmove instead of memcpy in readers

2011-12-20 Thread Uri Lublin
When src/dst memory areas may overlap, it's safer to use memmove. --- client/controller.cpp |2 +- client/foreign_menu.cpp |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/controller.cpp b/client/controller.cpp index e7c4b95..91c0021 100644 ---

[Spice-devel] [PATCH 2/4] client: menu: make RedWindow::set_menu() return an error-code (#758260)

2011-12-20 Thread Uri Lublin
RedWindow::set_menu() can fail (on Windows when in fullscreen mode). For Windows spice-client, when in fullscreen mode, the system-menu is NULL. Returns 0 upon success, non-0 (currently only -1) upon failure. --- client/red_window.h |2 +- client/windows/red_window.cpp | 14

[Spice-devel] [PATCH 3/4] client: update menu if needed when exiting full-screen mode (#758260)

2011-12-20 Thread Uri Lublin
--- client/screen.cpp |7 ++- client/screen.h |1 + 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/client/screen.cpp b/client/screen.cpp index 94f3bdc..0b3ba6f 100644 --- a/client/screen.cpp +++ b/client/screen.cpp @@ -100,6 +100,7 @@ RedScreen::RedScreen(Application

[Spice-devel] [PATCH 4/4] client: foreign-menu: pass active param when creating a ForeignMenu (#769020)

2011-12-20 Thread Uri Lublin
The default stays the same -- false. A race could prevent setting ForeignMenu::_active correctly. That happened when Application::on_app_activated was called before _foriegn_menu was created. When foriegn_menu was created its _active defaults to false, and that has not changed, until focus was

[Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Uri Lublin
Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3 --- client/screen.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/screen.cpp b/client/screen.cpp index 0b3ba6f..a0dc0df 100644 --- a/client/screen.cpp +++ b/client/screen.cpp @@ -87,6 +87,7 @@

[Spice-devel] [PATCH] client: screen: fix typo _forec_update_timer

2011-12-22 Thread Uri Lublin
sed -i 's/_forec_update_timer/_force_update_timer/' screen.cpp screen.h --- client/screen.cpp | 10 +- client/screen.h |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/client/screen.cpp b/client/screen.cpp index a0dc0df..dc33455 100644 --- a/client/screen.cpp

Re: [Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update

2011-12-22 Thread Uri Lublin
On 12/22/2011 11:26 AM, Christophe Fergeau wrote: On Thu, Dec 22, 2011 at 11:23:48AM +0200, Uri Lublin wrote: On 12/22/2011 11:11 AM, Christophe Fergeau wrote: What do you mean exactly by fix? Just that it's better to put field initialization in the order it will actually happen? Or something

Re: [Spice-devel] access local files and folder from remote VM

2011-12-26 Thread Uri Lublin
On 12/26/2011 08:28 AM, Charles.Tsai-蔡清海-工程部 wrote: All, I am wondering if SPICE allows a remote VM to access local files or folder as RDP does. In RDP, the local files or folder can be accessed by the remote desktop if it is configured. But I do not find such a feature to be provided by

Re: [Spice-devel] [PATCH vdagent-win 1/1] vdservice: fix vdagent first launch (during startup) failure handling rhbz#750037

2011-12-27 Thread Uri Lublin
On 12/26/2011 12:58 PM, Arnon Gilboa wrote: In case of agent launch failure: if connection state is not active(*), wait for agent launch on the next session connection. Otherwise, the service is stopped. (*) The failure was due to system startup timings and logon settings, causing the

[Spice-devel] [spice-xpi PATCH 2/3] logging: add logging of messages sent to the client (#753155)

2012-01-01 Thread Uri Lublin
Password is not logged. --- SpiceXPI/src/plugin/plugin.cpp |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp index 0b2ec4e..a48c94f 100644 --- a/SpiceXPI/src/plugin/plugin.cpp +++

[Spice-devel] [spice-xpi PATCH 3/3] logging: add logging of spice-client command line and pid (#753155)

2012-01-01 Thread Uri Lublin
spice-client pid was already logged, by both parent and child (value 0). It was moved to only be logged in the parent (spice-xpi). --- SpiceXPI/src/plugin/plugin.cpp |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/SpiceXPI/src/plugin/plugin.cpp

Re: [Spice-devel] Should we auto-redirect USB devices when we show the USB device selection menu?

2012-02-22 Thread Uri Lublin
On 02/21/2012 12:09 PM, Hans de Goede wrote: Hi, I'm working on some better / prettier error reporting for the usb device widget, and I was wondering should we auto-redirect newly plugged in USB devices when auto-redir is enabled and they get plugged on while showing the USB device

Re: [Spice-devel] [PATCH] server: fix segfault on client disconnect

2012-02-26 Thread Uri Lublin
On 02/26/2012 02:34 PM, Alon Levy wrote: ..as a result of missing initialization of newly introduced pre_disconnect in main channel. --- server/main_channel.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/server/main_channel.c b/server/main_channel.c index

Re: [Spice-devel] [PATCH 2/2] server: more logging about certificates used

2012-03-02 Thread Uri Lublin
On 03/02/2012 05:52 PM, Christophe Fergeau wrote: This commit adds some log messages indicating which certificates could be loaded (or not). Fixes rhbz#787678 --- server/reds.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/server/reds.c

Re: [Spice-devel] [PATCH 1/6] mingw: use uintptr_t when converting a pointer to an int

2012-03-04 Thread Uri Lublin
On 02/29/2012 08:01 PM, Christophe Fergeau wrote: win64 uses 32 bit long, so we cannot use a long to hold a 64 bit pointer. Thankfully, there's a [u]intptr_t type available exactly for these uses. --- client/canvas.cpp |2 +- client/cursor.cpp |2 +- common/draw.h |

Re: [Spice-devel] [spice-xpi 1/4] Add nsPluginInstance::SendBool

2012-03-05 Thread Uri Lublin
On 03/05/2012 03:33 PM, Christophe Fergeau wrote: ::SendVal will not send messages when the value is 0, which is not what is expected when sending a boolean value. --- SpiceXPI/src/plugin/plugin.cpp |6 ++ SpiceXPI/src/plugin/plugin.h |1 + 2 files changed, 7 insertions(+), 0

Re: [Spice-devel] [spice-xpi] Default to enabling Ctrl+Alt+Del

2012-03-05 Thread Uri Lublin
On 03/05/2012 05:51 PM, Christophe Fergeau wrote: On Linux, the default behaviour of the client is to have Ctrl+Alt+Del passthrough enabled, so it's better to default to enabling it from the controller as well to avoid getting a different behaviour when the client handles controller messages

[Spice-devel] [PATCH] usb-acl-helper: add a missing break

2012-03-29 Thread Uri Lublin
--- gtk/usb-acl-helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gtk/usb-acl-helper.c b/gtk/usb-acl-helper.c index 12596d0..a3ba14d 100644 --- a/gtk/usb-acl-helper.c +++ b/gtk/usb-acl-helper.c @@ -135,6 +135,7 @@ static gboolean cb_out_watch(GIOChannel

[Spice-devel] [PATCH spice-gtk] setsockopt: check for ENOTSUP only if defined

2012-04-19 Thread Uri Lublin
For windows (mingw32) ENOTSUP is not defined. Related to 3bfadb8587f59a74d373e26385d348a105c2e425 --- gtk/spice-channel.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c index 783b94a..3952e9a 100644 ---

[Spice-devel] [PATCH spice-xpi] SetSSLChannels: remove leading 's' from all channel names (#790416)

2012-04-23 Thread Uri Lublin
--- SpiceXPI/src/plugin/plugin.cpp | 25 - 1 files changed, 16 insertions(+), 9 deletions(-) diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp index 8acde24..76f2768 100644 --- a/SpiceXPI/src/plugin/plugin.cpp +++

[Spice-devel] [usbredir PATCH 0/6] support building usbredir for Windows with mingw

2012-05-03 Thread Uri Lublin
(mingw) Uri Lublin (5): configure: Windows: ignore usbredirserver and usbredirtestclient subdirs usbredirhost: undef ERROR if already defined autogen.sh: do not run ./configure if env variable NOCONFIGURE is defined usbredirhost: add LIBUSB_CALL to libusb complete-callback-functions

[Spice-devel] [usbredir PATCH 1/6] configure: Windows: ignore usbredirserver and usbredirtestclient subdirs

2012-05-03 Thread Uri Lublin
--- Makefile.am |5 - configure.ac | 14 ++ 2 files changed, 18 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9d392d5..6b77127 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,2 +1,5 @@ -SUBDIRS = usbredirparser usbredirhost usbredirserver

[Spice-devel] [usbredir PATCH 2/6] usbredirhost: undef ERROR if already defined

2012-05-03 Thread Uri Lublin
On Windows (mingw), ERROR is already defined (to i0) This fixes the following compiler warning: warning: ERROR redefined [enabled by default] --- usbredirhost/usbredirhost.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/usbredirhost/usbredirhost.c

[Spice-devel] [usbredir PATCH 3/6] autogen.sh: do not run ./configure if env variable NOCONFIGURE is defined

2012-05-03 Thread Uri Lublin
--- autogen.sh |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/autogen.sh b/autogen.sh index 52083e5..568f718 100755 --- a/autogen.sh +++ b/autogen.sh @@ -1,4 +1,6 @@ #!/bin/sh autoreconf -fi -./configure $@ +if [ -z $NOCONFIGURE ]; then +./configure $@ +fi --

[Spice-devel] [usbredir PATCH 4/6] usbredirhost: add LIBUSB_CALL to libusb complete-callback-functions

2012-05-03 Thread Uri Lublin
In libusb.h the following definition appears: typedef void (LIBUSB_CALL *libusb_transfer_cb_fn)(struct libusb_transfer *transfer); Added LIBUSB_CALL to the following functions: usbredirhost_iso_packet_complete usbredirhost_interrupt_packet_complete

[Spice-devel] [usbredir PATCH 5/6] usbredirhost: claim/release: ignore NOT_SUPPORTED on attach|detach kernel driver

2012-05-03 Thread Uri Lublin
On Windows libusb_(attach|detach)_kernel_driver are not supported. A libusb driver is already installed (device was successfully opened). In that case just continue as if operation was successful. --- usbredirhost/usbredirhost.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff

[Spice-devel] [usbredir PATCH 6/6] usbredirfilter: fix filter parsing for windows (mingw)

2012-05-03 Thread Uri Lublin
From: Arnon Gilboa agil...@redhat.com no strtok_r (reentrent) available, so use strtok instead. Modified-by: Uri Lublin u...@redhat.com --- usbredirparser/usbredirfilter.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/usbredirparser/usbredirfilter.c b

[Spice-devel] [spice-common PATCH] rect.h: rename variable small to sml

2012-05-07 Thread Uri Lublin
Apparently when compiling spice-gtk with mingw, small is defined as char. I found the following in rpcndr.h under mingw/include (not sure what includes it) #define small char This fixes the following compilation errer: In file included from ../spice-common/common/canvas_base.c:36:0,

Re: [Spice-devel] [spice-common PATCH] rect.h: rename variable small to sml

2012-05-07 Thread Uri Lublin
On 05/07/2012 11:22 AM, Yaniv Kaul wrote: - Original Message - Hi, Hmm I don't really like the name sml, but I cannot come up with anything better, so: ACK. small_rect and big_rect? Y. Fine, I'll send another patch. thanks, Uri. ___

[Spice-devel] [spice-gtk Win32 PATCH 0/7] usb-redir support for Windows (mingw32)

2012-05-07 Thread Uri Lublin
stuff to fix - Prevents crashes. Patch 6 adds usb-redir support in spicy - Add code to register for Windows USB events. Patch 7 can be merged into Patch 3 if people want. Review and comments are most welcome. Thanks, Uri (modified to keep order as detailed above) Uri Lublin (2

[Spice-devel] [spice-gtk Win32 PATCH 1/7] Move err variable definition to beginning of the function

2012-05-07 Thread Uri Lublin
This fixes the following compilation error: channel-usbredir.c: In function 'spice_usbredir_channel_connect_device_async': channel-usbredir.c:313:9: error: jump skips variable initialization [-Werror=jump-misses-init] --- gtk/channel-usbredir.c |4 +++- 1 files changed, 3 insertions(+), 1

[Spice-devel] [spice-gtk Win32 PATCH 2/7] configure.ac: add --enable_gudev

2012-05-07 Thread Uri Lublin
Instead of requiring it when usbredir is configured. The default value is auto, which is yes for linux and no for Windows --- configure.ac| 29 - gtk/Makefile.am |2 ++ 2 files changed, 30 insertions(+), 1 deletions(-) diff --git a/configure.ac

[Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice GUdevClient

2012-05-07 Thread Uri Lublin
From: Arnon Gilboa agil...@redhat.com With this patch usb-device-manager can work with little change on windows too. -add uevent signal based on WM_DEVICECHANGE -add spice_usb_device_manager_set_window for setting winproc (which is needed for event registration) Modified-by: Uri Lublin u

[Spice-devel] [spice-gtk Win32 PATCH 5/7] Windows usb: Comment out some memory cleanups not working on Windows

2012-05-07 Thread Uri Lublin
It's not nice, but better than crashing. --- gtk/usb-device-manager.c |9 + gtk/usbutil.c|1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index b60f1f0..377b774 100644 ---

[Spice-devel] [spice-gtk Win32 PATCH 6/7] Windows: spicy: listen to USB device plug/unplug events

2012-05-07 Thread Uri Lublin
--- gtk/spicy.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index f44642f..4c9708b 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -1319,6 +1319,21 @@ static SpiceWindow *create_spice_window(spice_connection *conn, int id,

Re: [Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice GUdevClient

2012-05-08 Thread Uri Lublin
Hi Marc-Andre, Thanks for the quick and helpful review. Some comments/questions (additional to Arnon's) are below. On 05/08/2012 11:55 AM, Arnon Gilboa wrote: Marc-André Lureau wrote: Hi On Mon, May 7, 2012 at 3:15 PM, Uri Lublin u...@redhat.com wrote: +WIN_USB_HDRS

Re: [Spice-devel] [PATCH spice-xpi] SetSSLChannels: add ssmartcard, susbredir, stunnel

2012-05-09 Thread Uri Lublin
On 05/09/2012 12:08 PM, Alon Levy wrote: Adding some more channels to the RHEL 5 list. The longer winded story is that ovirt-engine passes us those values because vdsm unconditionally removes the first letter of every channel name in the secure channels list (aka SSLChannels here). Instead of

Re: [Spice-devel] [usbredir PATCH 6/6] usbredirfilter: fix filter parsing for windows (mingw)

2012-05-09 Thread Uri Lublin
On 05/09/2012 01:07 PM, Christophe Fergeau wrote: Hey, On Mon, May 07, 2012 at 04:30:22PM +0300, Uri Lublin wrote: On 05/03/2012 07:09 PM, Christophe Fergeau wrote: On Thu, May 03, 2012 at 06:04:39PM +0300, Uri Lublin wrote: From: Arnon Gilboaagil...@redhat.com no strtok_r (reentrent

Re: [Spice-devel] [PATCH] server/red_worker: don't release self_bitmap unless refcount is 0

2012-05-14 Thread Uri Lublin
On 05/13/2012 02:40 PM, Alon Levy wrote: From: Yonit Halperinyhalp...@redhat.com RHBZ: 808936 --- server/red_worker.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 473d0d6..60f30d3 100644 ---

Re: [Spice-devel] [usbredir PATCH 1/6] configure: Windows: ignore usbredirserver and usbredirtestclient subdirs

2012-05-14 Thread Uri Lublin
On 05/03/2012 06:48 PM, Christophe Fergeau wrote: What's wrong with the test client on Windows? The socket code? I spent some time trying to make usbredirtestclient to work on Windows, but not too much. Various things needs to be ported (some are as easy as adding an include, some not as

Re: [Spice-devel] [PATCH 3/3] server/red_worker: fix possible leak of self_bitmap

2012-05-15 Thread Uri Lublin
On 05/15/2012 11:57 AM, Yonit Halperin wrote: Hi, Instead of this patch series and the previous self_bitmap patch, I think we should do the following: Both GLZDrawable and Drawable share references to RedDrawable and self_bitmap, and self_bitmap life time is equal to RedDrawable's one. So we

Re: [Spice-devel] spice windows client

2012-05-16 Thread Uri Lublin
On 05/16/2012 03:51 PM, Arnon Gilboa wrote: Hi Joris, see below. Enjoy, Arnon joris wrote: Dear list most likely I'm doing something stupid, but i searched all over google and cannot find the answer. I also looked through the docs on the spice website and still nothing. The problem however

  1   2   3   4   5   6   7   8   9   10   >