Re: [Spice-devel] [PATCH spice-server 08/12] Do not declare image_encoders_compress_lz4 if LZ4 is not available

2016-10-20 Thread Frediano Ziglio 
> 
> I assume this is fixing a warning?
> 

Not exactly. This changes a possible linking error in
a compiler error.

> Acked-by: Jonathon Jongsma 
> 

Frediano

> 
> On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio 
> > ---
> >  server/image-encoders.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/server/image-encoders.h b/server/image-encoders.h
> > index 6b4999e..a755bf3 100644
> > --- a/server/image-encoders.h
> > +++ b/server/image-encoders.h
> > @@ -202,8 +202,10 @@ int image_encoders_compress_lz(ImageEncoders
> > *enc, SpiceImage *dest,
> > SpiceBitmap *src,
> > compress_send_data_t* o_comp_data);
> >  int image_encoders_compress_jpeg(ImageEncoders *enc, SpiceImage
> > *dest,
> >   SpiceBitmap *src,
> > compress_send_data_t* o_comp_data);
> > +#ifdef USE_LZ4
> >  int image_encoders_compress_lz4(ImageEncoders *enc, SpiceImage
> > *dest,
> >  SpiceBitmap *src,
> > compress_send_data_t* o_comp_data);
> > +#endif
> >  int image_encoders_compress_glz(ImageEncoders *enc, SpiceImage
> > *dest,
> >  SpiceBitmap *src,
> >  RedDrawable *red_drawable,
> 
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-server 08/12] Do not declare image_encoders_compress_lz4 if LZ4 is not available

2016-10-19 Thread Jonathon Jongsma 
I assume this is fixing a warning?

Acked-by: Jonathon Jongsma 


On Tue, 2016-10-18 at 10:09 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio 
> ---
>  server/image-encoders.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/server/image-encoders.h b/server/image-encoders.h
> index 6b4999e..a755bf3 100644
> --- a/server/image-encoders.h
> +++ b/server/image-encoders.h
> @@ -202,8 +202,10 @@ int image_encoders_compress_lz(ImageEncoders
> *enc, SpiceImage *dest,
> SpiceBitmap *src,
> compress_send_data_t* o_comp_data);
>  int image_encoders_compress_jpeg(ImageEncoders *enc, SpiceImage
> *dest,
>   SpiceBitmap *src,
> compress_send_data_t* o_comp_data);
> +#ifdef USE_LZ4
>  int image_encoders_compress_lz4(ImageEncoders *enc, SpiceImage
> *dest,
>  SpiceBitmap *src,
> compress_send_data_t* o_comp_data);
> +#endif
>  int image_encoders_compress_glz(ImageEncoders *enc, SpiceImage
> *dest,
>  SpiceBitmap *src,
>  RedDrawable *red_drawable,
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-server 08/12] Do not declare image_encoders_compress_lz4 if LZ4 is not available

2016-10-18 Thread Frediano Ziglio 
Signed-off-by: Frediano Ziglio 
---
 server/image-encoders.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/server/image-encoders.h b/server/image-encoders.h
index 6b4999e..a755bf3 100644
--- a/server/image-encoders.h
+++ b/server/image-encoders.h
@@ -202,8 +202,10 @@ int image_encoders_compress_lz(ImageEncoders *enc, 
SpiceImage *dest,
SpiceBitmap *src, compress_send_data_t* 
o_comp_data);
 int image_encoders_compress_jpeg(ImageEncoders *enc, SpiceImage *dest,
  SpiceBitmap *src, compress_send_data_t* 
o_comp_data);
+#ifdef USE_LZ4
 int image_encoders_compress_lz4(ImageEncoders *enc, SpiceImage *dest,
 SpiceBitmap *src, compress_send_data_t* 
o_comp_data);
+#endif
 int image_encoders_compress_glz(ImageEncoders *enc, SpiceImage *dest,
 SpiceBitmap *src,
 RedDrawable *red_drawable,
-- 
2.7.4

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel