Re: [Spice-devel] [PATCH spice-streaming-agent v2] tests: Fix tests names

2018-02-13 Thread Lukáš Hrázký 
On Tue, 2018-02-13 at 13:48 +, Frediano Ziglio wrote:
> The test-hexdump was more an utility to test hexdump function instead
> of a proper test.
> Rename hexdump.sh to test-hexdump as this is the real test executed
> during "make check".
> 
> Signed-off-by: Frediano Ziglio 
> ---
>  src/unittests/.gitignore  |  2 +-
>  src/unittests/Makefile.am | 12 ++--
>  src/unittests/{test-hexdump.c => hexdump.c}   |  0
>  src/unittests/{hexdump.sh => test-hexdump.sh} |  2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)
>  rename src/unittests/{test-hexdump.c => hexdump.c} (100%)
>  rename src/unittests/{hexdump.sh => test-hexdump.sh} (91%)
> 
> Changes since v1:
> - rename test-hexdump to test-hexdump.sh;
> - added again wrongly removed target.
> 
> diff --git a/src/unittests/.gitignore b/src/unittests/.gitignore
> index 36548a1..bb238d7 100644
> --- a/src/unittests/.gitignore
> +++ b/src/unittests/.gitignore
> @@ -1 +1 @@
> -/test-hexdump
> +/hexdump
> diff --git a/src/unittests/Makefile.am b/src/unittests/Makefile.am
> index ef6c253..a70a4b4 100644
> --- a/src/unittests/Makefile.am
> +++ b/src/unittests/Makefile.am
> @@ -13,27 +13,27 @@ AM_CFLAGS = \
>   $(NULL)
>  
>  check_PROGRAMS = \
> - test-hexdump \
> + hexdump \
>   $(NULL)
>  
>  TESTS = \
> - hexdump.sh \
> + test-hexdump.sh \
>   $(NULL)
>  
>  noinst_PROGRAMS = \
>   $(check_PROGRAMS) \
>   $(NULL)
>  
> -test_hexdump_SOURCES = \
> - test-hexdump.c \
> +hexdump_SOURCES = \
> + hexdump.c \
>   $(NULL)
>  
> -test_hexdump_LDADD = \
> +hexdump_LDADD = \
>   ../libstreaming-utils.a \
>   $(NULL)
>  
>  EXTRA_DIST = \
> - hexdump.sh \
> + test-hexdump.sh \
>   hexdump1.in \
>   hexdump1.out \
>   hexdump2.in \
> diff --git a/src/unittests/test-hexdump.c b/src/unittests/hexdump.c
> similarity index 100%
> rename from src/unittests/test-hexdump.c
> rename to src/unittests/hexdump.c
> diff --git a/src/unittests/hexdump.sh b/src/unittests/test-hexdump.sh
> similarity index 91%
> rename from src/unittests/hexdump.sh
> rename to src/unittests/test-hexdump.sh
> index 691b264..69fc7aa 100755
> --- a/src/unittests/hexdump.sh
> +++ b/src/unittests/test-hexdump.sh
> @@ -12,7 +12,7 @@ for f in "$SRCDIR"/hexdump*.in; do
>  reference=`echo $f | sed 's,\.in,.out,'`
>  out=`basename $reference`.test
>  rm -f $out
> -./test-hexdump $out < $f
> +./hexdump $out < $f
>  cmp $out $reference
>  rm -f $out
>  done

Acked-by: Lukáš Hrázký 
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-streaming-agent v2] tests: Fix tests names

2018-02-13 Thread Frediano Ziglio 
The test-hexdump was more an utility to test hexdump function instead
of a proper test.
Rename hexdump.sh to test-hexdump as this is the real test executed
during "make check".

Signed-off-by: Frediano Ziglio 
---
 src/unittests/.gitignore  |  2 +-
 src/unittests/Makefile.am | 12 ++--
 src/unittests/{test-hexdump.c => hexdump.c}   |  0
 src/unittests/{hexdump.sh => test-hexdump.sh} |  2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)
 rename src/unittests/{test-hexdump.c => hexdump.c} (100%)
 rename src/unittests/{hexdump.sh => test-hexdump.sh} (91%)

Changes since v1:
- rename test-hexdump to test-hexdump.sh;
- added again wrongly removed target.

diff --git a/src/unittests/.gitignore b/src/unittests/.gitignore
index 36548a1..bb238d7 100644
--- a/src/unittests/.gitignore
+++ b/src/unittests/.gitignore
@@ -1 +1 @@
-/test-hexdump
+/hexdump
diff --git a/src/unittests/Makefile.am b/src/unittests/Makefile.am
index ef6c253..a70a4b4 100644
--- a/src/unittests/Makefile.am
+++ b/src/unittests/Makefile.am
@@ -13,27 +13,27 @@ AM_CFLAGS = \
$(NULL)
 
 check_PROGRAMS = \
-   test-hexdump \
+   hexdump \
$(NULL)
 
 TESTS = \
-   hexdump.sh \
+   test-hexdump.sh \
$(NULL)
 
 noinst_PROGRAMS = \
$(check_PROGRAMS) \
$(NULL)
 
-test_hexdump_SOURCES = \
-   test-hexdump.c \
+hexdump_SOURCES = \
+   hexdump.c \
$(NULL)
 
-test_hexdump_LDADD = \
+hexdump_LDADD = \
../libstreaming-utils.a \
$(NULL)
 
 EXTRA_DIST = \
-   hexdump.sh \
+   test-hexdump.sh \
hexdump1.in \
hexdump1.out \
hexdump2.in \
diff --git a/src/unittests/test-hexdump.c b/src/unittests/hexdump.c
similarity index 100%
rename from src/unittests/test-hexdump.c
rename to src/unittests/hexdump.c
diff --git a/src/unittests/hexdump.sh b/src/unittests/test-hexdump.sh
similarity index 91%
rename from src/unittests/hexdump.sh
rename to src/unittests/test-hexdump.sh
index 691b264..69fc7aa 100755
--- a/src/unittests/hexdump.sh
+++ b/src/unittests/test-hexdump.sh
@@ -12,7 +12,7 @@ for f in "$SRCDIR"/hexdump*.in; do
 reference=`echo $f | sed 's,\.in,.out,'`
 out=`basename $reference`.test
 rm -f $out
-./test-hexdump $out < $f
+./hexdump $out < $f
 cmp $out $reference
 rm -f $out
 done
-- 
2.14.3

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel