Re: [Spice-devel] [spice] server: Remove a redundant IncomingHandler typedef
On Fri, 2016-10-14 at 12:08 +0200, Francois Gouget wrote: > On Fri, 14 Oct 2016, Frediano Ziglio wrote: > [...] > > > typedef struct RedChannel RedChannel; > > > typedef struct RedClient RedClient; > > > -typedef struct IncomingHandler IncomingHandler; > > > > > > typedef struct RedChannelClient RedChannelClient; > > > typedef struct RedChannelClientClass RedChannelClientClass; > > > > For me > > > > Acked-by: Frediano Ziglio > > > > However I'll wait to understand if others prefer to > > remove the typedef from the structure declaration... > > but both would work, just style preferences. > > I chose that approach to match OutgoingHandler. It is matter of preferences, I also prefer this way but for instance in virt-viewer or spice-gtk is common to have it the other way (no typedef at struct). Maybe it is common for glib based projects ? Pavel > > RedChannelClient is a bit different in that the typedef is already > defined in two places: red-channel.h and red-channel-client.h (this > also causes compilation errors on RHEL 6.8 btw). > ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice] server: Remove a redundant IncomingHandler typedef
On Fri, 14 Oct 2016, Frediano Ziglio wrote: [...] > > typedef struct RedChannel RedChannel; > > typedef struct RedClient RedClient; > > -typedef struct IncomingHandler IncomingHandler; > > > > typedef struct RedChannelClient RedChannelClient; > > typedef struct RedChannelClientClass RedChannelClientClass; > > For me > > Acked-by: Frediano Ziglio > > However I'll wait to understand if others prefer to > remove the typedef from the structure declaration... > but both would work, just style preferences. I chose that approach to match OutgoingHandler. RedChannelClient is a bit different in that the typedef is already defined in two places: red-channel.h and red-channel-client.h (this also causes compilation errors on RHEL 6.8 btw). -- Francois Gouget ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice] server: Remove a redundant IncomingHandler typedef
> > This fixes a compilation error with gcc 4.4.7 on RHEL 6.8. > > Signed-off-by: Francois Gouget > --- > server/red-channel-client.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/server/red-channel-client.h b/server/red-channel-client.h > index 0b180b3..3b9e34c 100644 > --- a/server/red-channel-client.h > +++ b/server/red-channel-client.h > @@ -51,7 +51,6 @@ G_BEGIN_DECLS > > typedef struct RedChannel RedChannel; > typedef struct RedClient RedClient; > -typedef struct IncomingHandler IncomingHandler; > > typedef struct RedChannelClient RedChannelClient; > typedef struct RedChannelClientClass RedChannelClientClass; For me Acked-by: Frediano Ziglio However I'll wait to understand if others prefer to remove the typedef from the structure declaration... but both would work, just style preferences. Frediano ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [spice] server: Remove a redundant IncomingHandler typedef
This fixes a compilation error with gcc 4.4.7 on RHEL 6.8. Signed-off-by: Francois Gouget --- server/red-channel-client.h | 1 - 1 file changed, 1 deletion(-) diff --git a/server/red-channel-client.h b/server/red-channel-client.h index 0b180b3..3b9e34c 100644 --- a/server/red-channel-client.h +++ b/server/red-channel-client.h @@ -51,7 +51,6 @@ G_BEGIN_DECLS typedef struct RedChannel RedChannel; typedef struct RedClient RedClient; -typedef struct IncomingHandler IncomingHandler; typedef struct RedChannelClient RedChannelClient; typedef struct RedChannelClientClass RedChannelClientClass; -- 2.9.3 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel