Re: [Spice-devel] [spice-gtk v1 00/11] misc improvements in channel-display
Hi, On Thu, Mar 29, 2018 at 01:53:44PM +0200, Victor Toso wrote: > Hi, > > On Tue, Mar 13, 2018 at 12:25:31PM +0100, Victor Toso wrote: > > From: Victor Toso > > > > Hi, > > > > The first four patches are related to using hash table to track stream's > > structure, discussed with Lukas at [0]. The others are trying to: > > - reduce too much code in one place; > > - reduce the verbose logs we have with streaming; > > > > [0] > > https://lists.freedesktop.org/archives/spice-devel/2018-March/042529.html > > Friendly ping. Most about debug stuff. Creating spice_frame_new() and spice_frame_free() helps with some metrics, like, how many frames are alive? how long it takes from the frame being created to be decoded, rendered, etc. Cheers, > > > Thanks for your input, > > toso > > > > Victor Toso (11): > > channel-display: remove id parameter from helper function > > channel-display: rename display_stream_destroy() > > channel-display: remove unneeded function > > channel-display: use GHashTable to keep stream's structure > > channel-display: add spice_frame_free() helper > > channel-display: add spice_frame_new() helper > > channel-display: add display_stream_stats_save() helper > > channel-display: add display_stream_stats_debug() helper > > channel-display: don't debug latency for each frame > > channel-display-gst: summarize number of frames dropped > > channel-display-mjpeg: remove verbose logs > > > > src/channel-display-gst.c | 19 +-- > > src/channel-display-mjpeg.c | 24 +--- > > src/channel-display-priv.h | 6 +- > > src/channel-display.c | 313 > > ++-- > > 4 files changed, 201 insertions(+), 161 deletions(-) > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel signature.asc Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-gtk v1 00/11] misc improvements in channel-display
Hi, On Tue, Mar 13, 2018 at 12:25:31PM +0100, Victor Toso wrote: > From: Victor Toso > > Hi, > > The first four patches are related to using hash table to track stream's > structure, discussed with Lukas at [0]. The others are trying to: > - reduce too much code in one place; > - reduce the verbose logs we have with streaming; > > [0] https://lists.freedesktop.org/archives/spice-devel/2018-March/042529.html Friendly ping. > Thanks for your input, > toso > > Victor Toso (11): > channel-display: remove id parameter from helper function > channel-display: rename display_stream_destroy() > channel-display: remove unneeded function > channel-display: use GHashTable to keep stream's structure > channel-display: add spice_frame_free() helper > channel-display: add spice_frame_new() helper > channel-display: add display_stream_stats_save() helper > channel-display: add display_stream_stats_debug() helper > channel-display: don't debug latency for each frame > channel-display-gst: summarize number of frames dropped > channel-display-mjpeg: remove verbose logs > > src/channel-display-gst.c | 19 +-- > src/channel-display-mjpeg.c | 24 +--- > src/channel-display-priv.h | 6 +- > src/channel-display.c | 313 > ++-- > 4 files changed, 201 insertions(+), 161 deletions(-) signature.asc Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [spice-gtk v1 00/11] misc improvements in channel-display
From: Victor Toso Hi, The first four patches are related to using hash table to track stream's structure, discussed with Lukas at [0]. The others are trying to: - reduce too much code in one place; - reduce the verbose logs we have with streaming; [0] https://lists.freedesktop.org/archives/spice-devel/2018-March/042529.html Thanks for your input, toso Victor Toso (11): channel-display: remove id parameter from helper function channel-display: rename display_stream_destroy() channel-display: remove unneeded function channel-display: use GHashTable to keep stream's structure channel-display: add spice_frame_free() helper channel-display: add spice_frame_new() helper channel-display: add display_stream_stats_save() helper channel-display: add display_stream_stats_debug() helper channel-display: don't debug latency for each frame channel-display-gst: summarize number of frames dropped channel-display-mjpeg: remove verbose logs src/channel-display-gst.c | 19 +-- src/channel-display-mjpeg.c | 24 +--- src/channel-display-priv.h | 6 +- src/channel-display.c | 313 ++-- 4 files changed, 201 insertions(+), 161 deletions(-) -- 2.16.2 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
