Re: [Spice-devel] [spice-gtk v1 3/4] channel-display-gst: improve check for decoder element

2016-10-19 Thread Victor Toso
Hi, On Wed, Oct 19, 2016 at 06:26:18PM +0200, Francois Gouget wrote: > On Wed, 19 Oct 2016, Victor Toso wrote: > [...] > > > But I don't think this necessarily impacts gstvideo_has_codec() if > > > implemented using create_gstreamer_decoder() whereas with your code it > > > will necessarily be imp

Re: [Spice-devel] [spice-gtk v1 3/4] channel-display-gst: improve check for decoder element

2016-10-19 Thread Francois Gouget
On Wed, 19 Oct 2016, Victor Toso wrote: [...] > > But I don't think this necessarily impacts gstvideo_has_codec() if > > implemented using create_gstreamer_decoder() whereas with your code it > > will necessarily be impacted. > > Well, my point is simply why create the whole pipeline if we only ne

Re: [Spice-devel] [spice-gtk v1 3/4] channel-display-gst: improve check for decoder element

2016-10-19 Thread Victor Toso
Hi, On Wed, Oct 19, 2016 at 04:43:12PM +0200, Francois Gouget wrote: > On Wed, 19 Oct 2016, Victor Toso wrote: > [...] > > > In a different context I have found that I can fnid dfbvideosink and > > > even instantiate it. But it will refuse to switch to the READY state and > > > is thus unusable. T

Re: [Spice-devel] [spice-gtk v1 3/4] channel-display-gst: improve check for decoder element

2016-10-19 Thread Francois Gouget
On Wed, 19 Oct 2016, Victor Toso wrote: [...] > > In a different context I have found that I can fnid dfbvideosink and > > even instantiate it. But it will refuse to switch to the READY state and > > is thus unusable. That makes sense since I was not using it in a Direct > > FB context. > > Intere

Re: [Spice-devel] [spice-gtk v1 3/4] channel-display-gst: improve check for decoder element

2016-10-19 Thread Victor Toso
Hey, On Wed, Oct 19, 2016 at 12:42:34PM +0200, Victor Toso wrote: > Hi, > > On Wed, Oct 19, 2016 at 12:11:53PM +0200, Francois Gouget wrote: > > On Tue, 18 Oct 2016, Victor Toso wrote: > > [...] > > > +elements = g_strsplit(gst_opts[codec_type].dec_name, "!", 0); > > > > This would not work i

Re: [Spice-devel] [spice-gtk v1 3/4] channel-display-gst: improve check for decoder element

2016-10-19 Thread Victor Toso
Hi, On Wed, Oct 19, 2016 at 12:11:53PM +0200, Francois Gouget wrote: > On Tue, 18 Oct 2016, Victor Toso wrote: > [...] > > +elements = g_strsplit(gst_opts[codec_type].dec_name, "!", 0); > > This would not work if one of the elements takes options. > (not the case right now but if we can keep t

Re: [Spice-devel] [spice-gtk v1 3/4] channel-display-gst: improve check for decoder element

2016-10-19 Thread Francois Gouget
On Tue, 18 Oct 2016, Victor Toso wrote: [...] > +elements = g_strsplit(gst_opts[codec_type].dec_name, "!", 0); This would not work if one of the elements takes options. (not the case right now but if we can keep the option open) > +for (i = 0; elements[i] != NULL; i++) { > +GstEl

[Spice-devel] [spice-gtk v1 3/4] channel-display-gst: improve check for decoder element

2016-10-18 Thread Victor Toso
From: Victor Toso Instead of creating the whole pipeline and check for errors (which would create and destroy the SpiceGstDecoder), let's use gst_element_factory_find() function. Signed-off-by: Victor Toso --- src/channel-display-gst.c | 25 ++--- 1 file changed, 18 inserti