Re: [Spice-devel] [spice-server 2/8] build: Bump glib version
On Wed, Mar 07, 2018 at 05:13:57AM -0500, Frediano Ziglio wrote: > > > > Hey, > > > > On Wed, Mar 07, 2018 at 01:56:20AM -0500, Frediano Ziglio wrote: > > > > > > > > From spice-gtk b312ca08 commit: > > > > "At the moment: > > > > - Fedora 26 has 2.52 > > > > - Fedora 25 has 2.50 > > > > - Fedora 24 has 2.48 > > > > - CentOS 7 has 2.46 > > > > - Debian 9 has 2.50" > > > > > > > > RHEL6 only have 2.28, but glib 2.32 is only used in a test case at the > > > > moment. > > > > > > Well... or is supported or is not supported, in the > > > past we changed requirements for specific tests, I would > > > follow that style. > > > > > > Honestly... if you send a patch saying that we stop RHEL6 support > > > I'll ack in 2 ms! > > > > In my opinion, we don't have to try very hard to support RHEL6 in the > > 0.14 branch. > > > > Christophe > > > > Or is supported or not, there's not try. If you need 2.32 functions > on spice-server is not supported, if you need 2.32 functions on a > specific test that specific test can disable the checks. > This patch won't allow RHEL6 to compile spice-server so is dropping > RHEL6 support. People will have to patch the build in order to > build spice-server. > > As I said an ack to this patch requires explicit agreement of > the support drop. I agree! Just have to be explicit. I would say it's ok if this does not build out of the box, if we can avoid breaking rhel6 too much, even better ;) Christophe signature.asc Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-server 2/8] build: Bump glib version
> > Hey, > > On Wed, Mar 07, 2018 at 01:56:20AM -0500, Frediano Ziglio wrote: > > > > > > From spice-gtk b312ca08 commit: > > > "At the moment: > > > - Fedora 26 has 2.52 > > > - Fedora 25 has 2.50 > > > - Fedora 24 has 2.48 > > > - CentOS 7 has 2.46 > > > - Debian 9 has 2.50" > > > > > > RHEL6 only have 2.28, but glib 2.32 is only used in a test case at the > > > moment. > > > > Well... or is supported or is not supported, in the > > past we changed requirements for specific tests, I would > > follow that style. > > > > Honestly... if you send a patch saying that we stop RHEL6 support > > I'll ack in 2 ms! > > In my opinion, we don't have to try very hard to support RHEL6 in the > 0.14 branch. > > Christophe > Or is supported or not, there's not try. If you need 2.32 functions on spice-server is not supported, if you need 2.32 functions on a specific test that specific test can disable the checks. This patch won't allow RHEL6 to compile spice-server so is dropping RHEL6 support. People will have to patch the build in order to build spice-server. As I said an ack to this patch requires explicit agreement of the support drop. I agree! Just have to be explicit. Frediano ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-server 2/8] build: Bump glib version
Hey, On Wed, Mar 07, 2018 at 01:56:20AM -0500, Frediano Ziglio wrote: > > > > From spice-gtk b312ca08 commit: > > "At the moment: > > - Fedora 26 has 2.52 > > - Fedora 25 has 2.50 > > - Fedora 24 has 2.48 > > - CentOS 7 has 2.46 > > - Debian 9 has 2.50" > > > > RHEL6 only have 2.28, but glib 2.32 is only used in a test case at the > > moment. > > Well... or is supported or is not supported, in the > past we changed requirements for specific tests, I would > follow that style. > > Honestly... if you send a patch saying that we stop RHEL6 support > I'll ack in 2 ms! In my opinion, we don't have to try very hard to support RHEL6 in the 0.14 branch. Christophe signature.asc Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-server 2/8] build: Bump glib version
> > From spice-gtk b312ca08 commit: > "At the moment: > - Fedora 26 has 2.52 > - Fedora 25 has 2.50 > - Fedora 24 has 2.48 > - CentOS 7 has 2.46 > - Debian 9 has 2.50" > > RHEL6 only have 2.28, but glib 2.32 is only used in a test case at the > moment. Well... or is supported or is not supported, in the past we changed requirements for specific tests, I would follow that style. Honestly... if you send a patch saying that we stop RHEL6 support I'll ack in 2 ms! > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 9eb9bb492..bcd4bb4d5 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -161,8 +161,8 @@ SPICE_PROTOCOL_MIN_VER=0.12.14 > PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >= > $SPICE_PROTOCOL_MIN_VER]) > AC_SUBST([SPICE_PROTOCOL_MIN_VER]) > > -GLIB2_REQUIRED=2.28 > -GLIB2_ENCODED_VERSION="GLIB_VERSION_2_28" > +GLIB2_REQUIRED=2.32 > +GLIB2_ENCODED_VERSION="GLIB_VERSION_2_32" > PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= $GLIB2_REQUIRED gio-2.0 >= > $GLIB2_REQUIRED]) > GLIB2_CFLAGS="$GLIB2_CFLAGS > -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_ENCODED_VERSION \ >-DGLIB_VERSION_MAX_ALLOWED=$GLIB2_ENCODED_VERSION" Frediano ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [spice-server 2/8] build: Bump glib version
From spice-gtk b312ca08 commit: "At the moment: - Fedora 26 has 2.52 - Fedora 25 has 2.50 - Fedora 24 has 2.48 - CentOS 7 has 2.46 - Debian 9 has 2.50" RHEL6 only have 2.28, but glib 2.32 is only used in a test case at the moment. --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 9eb9bb492..bcd4bb4d5 100644 --- a/configure.ac +++ b/configure.ac @@ -161,8 +161,8 @@ SPICE_PROTOCOL_MIN_VER=0.12.14 PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >= $SPICE_PROTOCOL_MIN_VER]) AC_SUBST([SPICE_PROTOCOL_MIN_VER]) -GLIB2_REQUIRED=2.28 -GLIB2_ENCODED_VERSION="GLIB_VERSION_2_28" +GLIB2_REQUIRED=2.32 +GLIB2_ENCODED_VERSION="GLIB_VERSION_2_32" PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= $GLIB2_REQUIRED gio-2.0 >= $GLIB2_REQUIRED]) GLIB2_CFLAGS="$GLIB2_CFLAGS -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_ENCODED_VERSION \ -DGLIB_VERSION_MAX_ALLOWED=$GLIB2_ENCODED_VERSION" -- 2.14.3 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
